From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 3/3] Constify two local variables.
Date: Mon, 30 Nov 2015 09:38:32 +0000 [thread overview]
Message-ID: <20151130093832.5321126d@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20151130032153.GH2504@tarsus.local2>
On Mon, 30 Nov 2015 03:21:53 +0000
Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> I assume that v->pm->gsu.a->getfn() has no access to v->start and
> v->end, hence changing the order is safe.
Yes, the getfn() is very low level, dealing only with storage for that
parameter and having no knowledge at all of any expansion/substitution
happening above it.
> Are there any compilers that choke on 'char **const' (const pointer to pointer
> to char)?
I suspect we ditched those some years ago when we started making more
use of const, but there might be a few oddballs lying around.
By the way...
> See for example the number of uses of mkarry()
that should have been "mkarray()". I see 19 uses, then there's
also hmkarray() which comes from the heap and is only used 3 times.
pws
next prev parent reply other threads:[~2015-11-30 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 3:21 Daniel Shahaf
2015-11-30 9:38 ` Peter Stephenson [this message]
2015-11-30 15:59 ` Daniel Shahaf
2015-11-30 16:28 ` Bart Schaefer
2015-11-30 16:42 ` Peter Stephenson
2015-11-30 20:39 ` Bart Schaefer
2015-11-30 21:36 ` Bart Schaefer
2015-12-02 0:36 ` Daniel Shahaf
2015-12-02 1:11 ` Bart Schaefer
2015-12-03 23:37 ` Daniel Shahaf
2015-12-04 0:36 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130093832.5321126d@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).