From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 3/3] Constify two local variables.
Date: Thu, 3 Dec 2015 23:37:19 +0000 [thread overview]
Message-ID: <20151203233719.GE1955@tarsus.local2> (raw)
In-Reply-To: <151201171121.ZM710@torch.brasslantern.com>
Bart Schaefer wrote on Tue, Dec 01, 2015 at 17:11:21 -0800:
> On Dec 2, 12:36am, Daniel Shahaf wrote:
> } Subject: Re: [PATCH 3/3] Constify two local variables.
> }
> } #define N (sizeof(void*) * arrlen(vals))
> } vals = getfn()
> } munge_in_place(vals)
> } dummy = zalloc(N)
> } memcpy(dummy, vals, N)
> } setfn(dummy)
>
> Would that memcpy() really work, or would it need to be zarrdup() to copy
> each of the elements as well? Because e.g. arrsetfn() does freearray().
I think it would work, because setarrvalue() in HEAD calls freearray()
on the values array, implying that the individual elements are already
permanently allocated.
---
In the meantime I've found a reproducible invalid free() with this
patchset (reproducible by invoking _gnu_generic on ": Sr<TAB>" in the
source tree). I haven't investigated yet.
Daniel
next prev parent reply other threads:[~2015-12-03 23:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 3:21 Daniel Shahaf
2015-11-30 9:38 ` Peter Stephenson
2015-11-30 15:59 ` Daniel Shahaf
2015-11-30 16:28 ` Bart Schaefer
2015-11-30 16:42 ` Peter Stephenson
2015-11-30 20:39 ` Bart Schaefer
2015-11-30 21:36 ` Bart Schaefer
2015-12-02 0:36 ` Daniel Shahaf
2015-12-02 1:11 ` Bart Schaefer
2015-12-03 23:37 ` Daniel Shahaf [this message]
2015-12-04 0:36 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203233719.GE1955@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).