From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: [PATCH 3/3] Constify two local variables.
Date: Mon, 30 Nov 2015 03:21:53 +0000 [thread overview]
Message-ID: <20151130032153.GH2504@tarsus.local2> (raw)
---
I assume that v->pm->gsu.a->getfn() has no access to v->start and v->end, hence
changing the order is safe.
Are there any compilers that choke on 'char **const' (const pointer to pointer
to char)?
Cheers,
Daniel
Src/params.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/Src/params.c b/Src/params.c
index d8bf83d..142697f 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -2552,18 +2552,20 @@ setarrvalue(Value v, char **val)
v->pm->node.nam);
return;
} else {
- char **old, **new, **p, **q, **r;
- int pre_assignment_length;
+ char **const old = v->pm->gsu.a->getfn(v->pm);
+ char **new;
+ char **p, **q, **r; /* index variables */
+ const int pre_assignment_length = arrlen(old);
int post_assignment_length;
int i;
+ q = old;
+
if ((v->flags & VALFLAG_INV) && unset(KSHARRAYS)) {
if (v->start > 0)
v->start--;
v->end--;
}
- q = old = v->pm->gsu.a->getfn(v->pm);
- pre_assignment_length = arrlen(old);
if (v->start < 0) {
v->start += pre_assignment_length;
if (v->start < 0)
--
2.1.4
next reply other threads:[~2015-11-30 3:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 3:21 Daniel Shahaf [this message]
2015-11-30 9:38 ` Peter Stephenson
2015-11-30 15:59 ` Daniel Shahaf
2015-11-30 16:28 ` Bart Schaefer
2015-11-30 16:42 ` Peter Stephenson
2015-11-30 20:39 ` Bart Schaefer
2015-11-30 21:36 ` Bart Schaefer
2015-12-02 0:36 ` Daniel Shahaf
2015-12-02 1:11 ` Bart Schaefer
2015-12-03 23:37 ` Daniel Shahaf
2015-12-04 0:36 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130032153.GH2504@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).