From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas)
Date: Tue, 30 May 2017 22:47:28 -0700 [thread overview]
Message-ID: <170530224728.ZM25709@torch.brasslantern.com> (raw)
In-Reply-To: <CAHYJk3QEJ__xMgiMNS8O8yLaPaF_XeYmwYTRaG-Dfrba4cmNWg@mail.gmail.com>
On May 29, 3:21pm, Mikael Magnusson wrote:
}
} Well, it never worked in the first place, that's why i put "bad" in
} the name. It's basically just a documentation of the places I found
} that would need to be updated to use a cached length value, but since
} it doesn't work I guess I didn't find all of them, or I misunderstood
} some parts of the code that I changed...
It also appears we've run out of bits for PM_CACHELEN and PM_CHECKEN,
the 19 and 20 bit positions are are now occupied by PM_DONTIMPORT_SUID
and PM_SINGLE, though I suppose PM_KSHSTORED and PM_ZSHSTORED could do
double duty as they won't apply to arrays and functions at once.
With respect to "it doesn't work" -- in commits f4ab07b4 and b7c2ddf6
you say you're adding typeset -C and typeset -c to control PM_CACHELEN
and PM_CHECKLEN but looking at the diffs you only added the argument
parsing; I can't find anywhere that PM_CACHELEN or PM_CHECKLEN are ever
assigned to the parameter flags?
I believe I've now merged params.c ... I tried forcing both of the new
flags on for non-special PM_ARRAY params in createparam(), and all tests
seem to pass except those involving the $match array, which implies one
of us did something wrong in setarrvalue() for post_assignment_length.
I think.
--
Barton E. Schaefer
next prev parent reply other threads:[~2017-05-31 5:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 5:04 Valgrind testing, ideas Sebastian Gniazdowski
2017-05-26 5:50 ` Bart Schaefer
2017-05-26 7:57 ` Sebastian Gniazdowski
2017-05-26 10:56 ` Daniel Shahaf
2017-05-26 23:48 ` Bart Schaefer
2017-05-28 19:43 ` mikachu/badarrays (Re: Valgrind testing, ideas) Bart Schaefer
2017-05-29 13:21 ` Mikael Magnusson
2017-05-31 5:47 ` Bart Schaefer [this message]
2017-06-01 16:31 ` Sebastian Gniazdowski
2017-06-01 20:35 ` Bart Schaefer
2017-06-02 1:40 ` Sebastian Gniazdowski
2017-06-02 22:00 ` Bart Schaefer
2017-06-04 0:49 ` Bart Schaefer
2017-06-04 7:08 ` Sebastian Gniazdowski
2017-06-01 21:22 ` Mikael Magnusson
2017-06-01 21:38 ` Bart Schaefer
2017-06-07 10:53 ` PM_ flags (Re: mikachu/badarrays ...) Oliver Kiddle
2017-06-07 18:15 ` Mikael Magnusson
2017-06-07 22:18 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170530224728.ZM25709@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).