From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas)
Date: Thu, 1 Jun 2017 14:38:08 -0700 [thread overview]
Message-ID: <170601143808.ZM1815@torch.brasslantern.com> (raw)
In-Reply-To: <CAHYJk3Tj0xynRk+cRsMosgnzwiv==VH8A6sTyjHf38dDV36Ong@mail.gmail.com>
On Jun 1, 11:22pm, Mikael Magnusson wrote:
} Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas)
}
} On Wed, May 31, 2017 at 7:47 AM, Bart Schaefer
} <schaefer@brasslantern.com> wrote:
} > It also appears we've run out of bits for PM_CACHELEN and PM_CHECKEN,
} > the 19 and 20 bit positions are are now occupied by PM_DONTIMPORT_SUID
} > and PM_SINGLE, though I suppose PM_KSHSTORED and PM_ZSHSTORED could do
} > double duty as they won't apply to arrays and functions at once.
}
} The existing code probably does something fun like assigning these
} flags based on the order of flags in the TYPESET_OPTSTR define.
Indeed, that's the case. So that means it's now essentially impossible
to add any more options to typeset, because bit positions 19+ are used
by values that must be assigned in the IPDEF(...) structs for params
used/set by the shell. In other words adding "cC" at the end of the
TYPEST_OPTSTR is now going to be broken by other things, unless we
add some special-case code.
} If you don't use typeset -c/-C for anything, then none of the new code
} should be activated and it is indeed expected that things would work.
As I mentioned:
} > I tried forcing both of the new
} > flags on for non-special PM_ARRAY params in createparam()
So they were getting used everywhere, even without "typeset -c". What
remained broken after that was the code that resizes an existing array.
next prev parent reply other threads:[~2017-06-01 21:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 5:04 Valgrind testing, ideas Sebastian Gniazdowski
2017-05-26 5:50 ` Bart Schaefer
2017-05-26 7:57 ` Sebastian Gniazdowski
2017-05-26 10:56 ` Daniel Shahaf
2017-05-26 23:48 ` Bart Schaefer
2017-05-28 19:43 ` mikachu/badarrays (Re: Valgrind testing, ideas) Bart Schaefer
2017-05-29 13:21 ` Mikael Magnusson
2017-05-31 5:47 ` Bart Schaefer
2017-06-01 16:31 ` Sebastian Gniazdowski
2017-06-01 20:35 ` Bart Schaefer
2017-06-02 1:40 ` Sebastian Gniazdowski
2017-06-02 22:00 ` Bart Schaefer
2017-06-04 0:49 ` Bart Schaefer
2017-06-04 7:08 ` Sebastian Gniazdowski
2017-06-01 21:22 ` Mikael Magnusson
2017-06-01 21:38 ` Bart Schaefer [this message]
2017-06-07 10:53 ` PM_ flags (Re: mikachu/badarrays ...) Oliver Kiddle
2017-06-07 18:15 ` Mikael Magnusson
2017-06-07 22:18 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170601143808.ZM1815@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).