zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas)
Date: Mon, 29 May 2017 15:21:15 +0200	[thread overview]
Message-ID: <CAHYJk3QEJ__xMgiMNS8O8yLaPaF_XeYmwYTRaG-Dfrba4cmNWg@mail.gmail.com> (raw)
In-Reply-To: <170528124337.ZM9444@torch.brasslantern.com>

On Sun, May 28, 2017 at 9:43 PM, Bart Schaefer
<schaefer@brasslantern.com> wrote:
> On May 26,  7:04am, Sebastian Gniazdowski wrote:
> }
> } The arrlen branch seems to faint. I had this idea of employing
> } valgrind, to get certain about code in the branch.
> }
> } Found 4 errors, instantly.
>
> I took a stab at merging mikachu/badarrays into the current master,
> and for the most part it was straightforward, but there are too many
> conflicting changes to Src/params.c (different numbers of values in
> the replacements for the whole suite of IPDEF macros, of which more
> have been added in the meantime; bug fixes in getarrvalue() that
> overlap the PM_CACHLEN changes).  I gave up on attempting to follow
> what would need to be be edited to bring the latest code up to date.
>
> I could push the current broken (won't compile) state up to the origin
> (I branched my merge as schaefer/badarrays) if Mikachu is interested in
> cleaning up params.c.  In the meantime it's probably not worthwhile to
> attempt memory checking on mikchu/badarrays.

Well, it never worked in the first place, that's why i put "bad" in
the name. It's basically just a documentation of the places I found
that would need to be updated to use a cached length value, but since
it doesn't work I guess I didn't find all of them, or I misunderstood
some parts of the code that I changed...

-- 
Mikael Magnusson


  reply	other threads:[~2017-05-29 13:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26  5:04 Valgrind testing, ideas Sebastian Gniazdowski
2017-05-26  5:50 ` Bart Schaefer
2017-05-26  7:57   ` Sebastian Gniazdowski
2017-05-26 10:56     ` Daniel Shahaf
2017-05-26 23:48       ` Bart Schaefer
2017-05-28 19:43 ` mikachu/badarrays (Re: Valgrind testing, ideas) Bart Schaefer
2017-05-29 13:21   ` Mikael Magnusson [this message]
2017-05-31  5:47     ` Bart Schaefer
2017-06-01 16:31       ` Sebastian Gniazdowski
2017-06-01 20:35         ` Bart Schaefer
2017-06-02  1:40           ` Sebastian Gniazdowski
2017-06-02 22:00             ` Bart Schaefer
2017-06-04  0:49             ` Bart Schaefer
2017-06-04  7:08               ` Sebastian Gniazdowski
2017-06-01 21:22       ` Mikael Magnusson
2017-06-01 21:38         ` Bart Schaefer
2017-06-07 10:53       ` PM_ flags (Re: mikachu/badarrays ...) Oliver Kiddle
2017-06-07 18:15         ` Mikael Magnusson
2017-06-07 22:18         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHYJk3QEJ__xMgiMNS8O8yLaPaF_XeYmwYTRaG-Dfrba4cmNWg@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).