zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Dagobert Michelsen <dam@blastwave.org>, zsh-workers@sunsite.dk
Subject: Re: * Re: Failed tests of zsh 4.3.5 in Solaris 10 w/Sun Studio 12 CC
Date: Tue, 26 Feb 2008 18:37:00 +0100	[thread overview]
Message-ID: <18951.1204047420@thecus> (raw)
In-Reply-To: <200802261610.m1QGAwJ3008939@news01.csr.com>

Peter wrote:
> > Is this an error from zsh or is this a bug in libiconv?

It's actually better to avoid using libiconv and stick to the builtin
iconv on Solaris. It handles 646 correctly. I always make a point of
making sure it doesn't find GNU libiconv when compiling.

> +		    if (!codessetstr || !*codsetstr ||
> +			!strcmp(codesetstr, "646"))
> +			codesetstr == "US-ASCII";

Is the last line of this correct? Isn't it meant to be an assignment?

I would be inclined to wrap the whole thing inside #ifdef
_libiconv_version because the problem only occurs when using GNU iconv
instead of the Solaris builtin one.

Oliver


  reply	other threads:[~2008-02-27  1:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26 13:18 Dagobert Michelsen
2008-02-26 14:14 ` Peter Stephenson
2008-02-26 14:42   ` Dagobert Michelsen
2008-02-26 14:57     ` Peter Stephenson
2008-02-26 15:18       ` Dagobert Michelsen
2008-02-26 16:10         ` * " Peter Stephenson
2008-02-26 17:37           ` Oliver Kiddle [this message]
2008-02-27 11:29             ` Peter Stephenson
2008-02-27 16:16               ` Bart Schaefer
2008-02-29  9:53               ` Oliver Kiddle
2008-03-03 12:08                 ` Peter Stephenson
2008-03-03 12:43                   ` Dagobert Michelsen
2008-03-03 12:59                     ` Peter Stephenson
2008-02-26 18:08           ` Peter Stephenson
2008-02-26 18:12             ` İsmail Dönmez
2008-02-26 19:19             ` Dagobert Michelsen
2008-02-26 19:47               ` Dagobert Michelsen
2008-02-26 20:42                 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18951.1204047420@thecus \
    --to=okiddle@yahoo.co.uk \
    --cc=dam@blastwave.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).