Re: * Re: Failed tests of zsh 4.3.5 in Solaris 10 w/Sun Studio 12 CC

[Dagobert Michelsen <dam@blastwave.org>]

Hi Peter,

Am 26.02.2008 um 19:08 schrieb Peter Stephenson:
> Er, except that there are three

Four ;-)

> mistakes in those three lines of code, as
> Geoff pointed out.  I was lulled into a false sense of security  
> because
> this doesn't get compiled on my machine.  I tried it specially.
>
> Index: Src/utils.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/utils.c,v
> retrieving revision 1.178
> diff -u -r1.178 utils.c
> --- Src/utils.c	26 Feb 2008 16:19:34 -0000	1.178
> +++ Src/utils.c	26 Feb 2008 18:05:59 -0000
> @@ -4885,9 +4885,9 @@
>  		     * It shouldn't ever be NULL, but while we're
>  		     * being paranoid...
>  		     */
> -		    if (!codessetstr || !*codsetstr ||
> +		    if (!codesetstr || !*codesetstr ||
>  			!strcmp(codesetstr, "646"))
> -			codesetstr == "US-ASCII";
> +			codesetstr = "US-ASCII";
>      	    	    cd = iconv_open(nl_langinfo(CODESET), "UCS-4BE");

      	    	    cd = iconv_open(codesetstr, "UCS-4BE");

>  		    if (cd == (iconv_t)-1) {
>  			zerr("cannot do charset conversion (iconv failed)");

Do you have a clue about the other failing tests?


Best regards

   -- Dago