zsh-workers
 help / color / mirror / code / Atom feed
From: Dagobert Michelsen <dam@blastwave.org>
To: Peter Stephenson <pws@csr.com>
Cc: "Zsh Hackers' List" <zsh-workers@sunsite.dk>
Subject: Re: * Re: Failed tests of zsh 4.3.5 in Solaris 10 w/Sun Studio 12 CC
Date: Mon, 3 Mar 2008 13:43:22 +0100	[thread overview]
Message-ID: <FC7FCD20-D9A8-484A-9D72-D9570FAC9D3E@blastwave.org> (raw)
In-Reply-To: <20080303120851.0c25f94f@news01>

Hi,

Am 03.03.2008 um 13:08 schrieb Peter Stephenson:
> On Fri, 29 Feb 2008 10:53:24 +0100
> Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
>> Peter wrote:
>>> The following is the best I've got:  it tests for _libiconv_version
>>> (which should be an external variable and hence tell us whether  
>>> we're
>>> actually linking against libiconv, whatever the header is) in  
>>> configure
>>
>> I'd have thought the AC_CHECK_DECL for _libiconv_version as used  
>> already
>> earlier in configure.ac is a sufficient test. If you try to  
>> compile zsh
>> with the iconv header file not matching what it links against, you  
>> get
>> bigger problems and it doesn't compile at all. In fact, there is
>> _LIBICONV_VERSION which is a #define so you could #ifdef that.
>
> I wanted to be safe about that and as far as I can tell checking if  
> we get
> _libiconv_version linked in should do that, right?

I posted the libiconv-issues on the libiconv-list and got the
following reply for reference:

> 	Von: 	  bruno@clisp.org
> 	Betreff: 	Re: [bug-gnu-libiconv] Solaris libiconv vs. GNU libiconv  
> in terms of 646
> 	Datum: 	28. Februar 2008 01:37:21 MEZ
> 	An: 	  dam@blastwave.org, bug-gnu-libiconv@gnu.org
>
> Hello,
>
> Dagobert Michelsen wrote:
>
>> I am currently packaging zsh for Solaris when I noticed
>> some failing tests due to problems with libiconv.
>> It looks like Solaris uses 646 as standard which is
>> known to Solaris libiconv but not GNU libiconv.
>>
>
> Yes, this is a known problem. Solaris uses "646" to denote the ASCII
> encoding, and GNU libiconv does not.
>
> What is standard in the realm of character encodings, is defined by  
> IANA,
> here:
>   http://www.iana.org/assignments/character-sets
>
>
>> I already found this in the notes:
>>
>>    Q: Support encodings mentioned in RFC 1345 ?
>>    A: No, they are not in use any more. Supporting ISO-646 variants
>> is pointless
>>       since ISO-8859-* have been adopted.
>>
>
> The issue is actually slightly different. The encoding itself is well
> supported by both Solaris iconv and GNU libiconv. Only the name used
> by Solaris is a fantasy name.
>
>
>> The troubles from the zsh-people is best described at
>>     <http://www.zsh.org/mla/workers/2008/msg00271.html>
>> The ZSH-people are currently building a workaround, but
>> this whole situation should be better addresses in libiconv.
>>
>
> This situation has been addressed in full generality - there is not  
> only
> Solaris and "646", there is also HP-UX and "hp15CN", and many others -
> in the gnulib module 'iconv_open', here:
>
>    http://www.gnu.org/software/gnulib/MODULES.html#module%3Diconv_open
>
> Regarding the workaround that you are doing:
>
>   - The idea to use "US-ASCII" for GNU libiconv but "646" for  
> Solaris iconv
>     is right.
>
>   - Instead of a configure-time test you can also use a simpler  
> compile-time
>     test:
>
>       #ifdef _LIBICONV_VERSION
>         /* using GNU libiconv */
>       #else
>         /* using the native system iconv */
>         #ifdef __sun
>           /* using the Solaris iconv */
>         #else
>           /* other systems */
>         #endif
>       #endif
>
>   - Regarding the recommendation to use Solaris iconv, I recommend the
>     opposite: Solaris iconv is known to crash in some situations.
>
> Bruno
>
> PS: This mail should appear as
> <http://lists.gnu.org/archive/html/bug-gnu-libiconv/2008-02/ 
> msg00003.html>



Best regards

   -- Dagobert


  reply	other threads:[~2008-03-03 12:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26 13:18 Dagobert Michelsen
2008-02-26 14:14 ` Peter Stephenson
2008-02-26 14:42   ` Dagobert Michelsen
2008-02-26 14:57     ` Peter Stephenson
2008-02-26 15:18       ` Dagobert Michelsen
2008-02-26 16:10         ` * " Peter Stephenson
2008-02-26 17:37           ` Oliver Kiddle
2008-02-27 11:29             ` Peter Stephenson
2008-02-27 16:16               ` Bart Schaefer
2008-02-29  9:53               ` Oliver Kiddle
2008-03-03 12:08                 ` Peter Stephenson
2008-03-03 12:43                   ` Dagobert Michelsen [this message]
2008-03-03 12:59                     ` Peter Stephenson
2008-02-26 18:08           ` Peter Stephenson
2008-02-26 18:12             ` İsmail Dönmez
2008-02-26 19:19             ` Dagobert Michelsen
2008-02-26 19:47               ` Dagobert Michelsen
2008-02-26 20:42                 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FC7FCD20-D9A8-484A-9D72-D9570FAC9D3E@blastwave.org \
    --to=dam@blastwave.org \
    --cc=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).