From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Cc: Dagobert Michelsen <dam@blastwave.org>
Subject: Re: * Re: Failed tests of zsh 4.3.5 in Solaris 10 w/Sun Studio 12 CC
Date: Tue, 26 Feb 2008 18:08:07 +0000 [thread overview]
Message-ID: <20080226180807.10cd1476@news01> (raw)
In-Reply-To: <200802261610.m1QGAwJ3008939@news01.csr.com>
On Tue, 26 Feb 2008 16:10:58 +0000
Peter Stephenson <pws@csr.com> wrote:
> + if (!codessetstr || !*codsetstr ||
> + !strcmp(codesetstr, "646"))
> + codesetstr == "US-ASCII";
Er, except that there are three mistakes in those three lines of code, as
Geoff pointed out. I was lulled into a false sense of security because
this doesn't get compiled on my machine. I tried it specially.
Index: Src/utils.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/utils.c,v
retrieving revision 1.178
diff -u -r1.178 utils.c
--- Src/utils.c 26 Feb 2008 16:19:34 -0000 1.178
+++ Src/utils.c 26 Feb 2008 18:05:59 -0000
@@ -4885,9 +4885,9 @@
* It shouldn't ever be NULL, but while we're
* being paranoid...
*/
- if (!codessetstr || !*codsetstr ||
+ if (!codesetstr || !*codesetstr ||
!strcmp(codesetstr, "646"))
- codesetstr == "US-ASCII";
+ codesetstr = "US-ASCII";
cd = iconv_open(nl_langinfo(CODESET), "UCS-4BE");
if (cd == (iconv_t)-1) {
zerr("cannot do charset conversion (iconv failed)");
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
next prev parent reply other threads:[~2008-02-26 18:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 13:18 Dagobert Michelsen
2008-02-26 14:14 ` Peter Stephenson
2008-02-26 14:42 ` Dagobert Michelsen
2008-02-26 14:57 ` Peter Stephenson
2008-02-26 15:18 ` Dagobert Michelsen
2008-02-26 16:10 ` * " Peter Stephenson
2008-02-26 17:37 ` Oliver Kiddle
2008-02-27 11:29 ` Peter Stephenson
2008-02-27 16:16 ` Bart Schaefer
2008-02-29 9:53 ` Oliver Kiddle
2008-03-03 12:08 ` Peter Stephenson
2008-03-03 12:43 ` Dagobert Michelsen
2008-03-03 12:59 ` Peter Stephenson
2008-02-26 18:08 ` Peter Stephenson [this message]
2008-02-26 18:12 ` İsmail Dönmez
2008-02-26 19:19 ` Dagobert Michelsen
2008-02-26 19:47 ` Dagobert Michelsen
2008-02-26 20:42 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226180807.10cd1476@news01 \
--to=pws@csr.com \
--cc=dam@blastwave.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).