zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: [PATCH] history locking with fcntl
Date: Thu, 17 Apr 2008 10:40:54 +0100	[thread overview]
Message-ID: <20080417104054.295003e3@news01> (raw)
In-Reply-To: <20080415153120.GE1223@prunille.vinc17.org>

On Tue, 15 Apr 2008 17:31:20 +0200
Vincent Lefevre <vincent@vinc17.org> wrote:
> I've rewritten my patch to lock the history with fcntl, and added
> an option. It works well with my settings (INC_APPEND_HISTORY), but
> I haven't tested it with other settings.

Thanks, I've committed it with modified documentation.  It will no doubt
need some field testing.

I think ftruncate() probably needs a configure test.  I haven't done
this yet.

pindex(HIST_FCNTL_LOCK)
item(tt(HIST_FCNTL_LOCK))(
When writing out the history file, by default zsh uses ad-hoc file locking
to avoid known problems with locking on some operating systems.  With this
option locking is done by means of the system's tt(fcntl) call, where
this method is available.  On recent operating systems this may
provide better performance, in particular avoiding history corruption when
files are stored on NFS.
)

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


  reply	other threads:[~2008-04-17  9:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-15 15:31 Vincent Lefevre
2008-04-17  9:40 ` Peter Stephenson [this message]
2008-04-17 13:58   ` Bart Schaefer
2008-04-18  0:49     ` Vincent Lefevre
2008-04-18  1:24       ` Bart Schaefer
2008-04-17 16:23 ` Wayne Davison
2008-04-17 16:35   ` Peter Stephenson
2008-04-18  0:59   ` Vincent Lefevre
2008-04-19  2:31     ` Wayne Davison
2008-04-19  5:23       ` Bart Schaefer
2008-04-19 18:35         ` Wayne Davison
2008-04-21 13:19       ` Vincent Lefevre
2008-05-05  1:25         ` Wayne Davison
2009-01-01  4:01           ` Vincent Lefevre
2009-01-01  4:12             ` Vincent Lefevre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080417104054.295003e3@news01 \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).