From: Wayne Davison <wayned@users.sourceforge.net>
To: zsh-workers@sunsite.dk
Subject: Re: [PATCH] history locking with fcntl
Date: Sun, 4 May 2008 18:25:51 -0700 [thread overview]
Message-ID: <20080505012551.GC11804@blorf.net> (raw)
In-Reply-To: <20080421131937.GM4304@prunille.vinc17.org>
On Mon, Apr 21, 2008 at 03:19:37PM +0200, Vincent Lefevre wrote:
> Note that since out has been closed, tmpfile is no longer locked.
> The target file isn't locked either.
The target file was locked prior to the rename (since that's the only
file my code is locking -- the HISTFILE itself). So, the rename does
essentially unlock the HISTFILE as far as fcntl() is concerned. Since
it is done with the write at that point, it should be OK (in my latest
version).
My code was deficient if it then went on to rewrite the HISTFILE before
returning, as it would not lock the file using fcntl() if it thought it
was already locked. I've fixed that, and checked in the result.
..wayne..
next prev parent reply other threads:[~2008-05-05 1:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 15:31 Vincent Lefevre
2008-04-17 9:40 ` Peter Stephenson
2008-04-17 13:58 ` Bart Schaefer
2008-04-18 0:49 ` Vincent Lefevre
2008-04-18 1:24 ` Bart Schaefer
2008-04-17 16:23 ` Wayne Davison
2008-04-17 16:35 ` Peter Stephenson
2008-04-18 0:59 ` Vincent Lefevre
2008-04-19 2:31 ` Wayne Davison
2008-04-19 5:23 ` Bart Schaefer
2008-04-19 18:35 ` Wayne Davison
2008-04-21 13:19 ` Vincent Lefevre
2008-05-05 1:25 ` Wayne Davison [this message]
2009-01-01 4:01 ` Vincent Lefevre
2009-01-01 4:12 ` Vincent Lefevre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080505012551.GC11804@blorf.net \
--to=wayned@users.sourceforge.net \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).