From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: [PATCH] history locking with fcntl
Date: Thu, 17 Apr 2008 17:35:03 +0100 [thread overview]
Message-ID: <200804171635.m3HGZ3dD007677@news01.csr.com> (raw)
In-Reply-To: <20080417162307.GB22594@blorf.net>
Wayne Davison wrote:
> I personally think this patch goes too far. There is a lockhistfile()
> call that is done to give a particular shell exclusive control over the
> history files. I'd prefer to see any extra locking done there.
Sounds reasonable to me, but you have more idea of the structure of this
bit.
> Additional discussion: I think the option name should be made more
> generic so that it can be made to support more types of file locking,
> such as the flock() call. Perhaps call it HIST_EXTRA_LOCKING?
I wondered about that, but something along the lines of Bart's concerns
came to me. Consequently, I was quite happy with an option that read as
THIS_IS_A_BIT_TECHY_AND_YOU_PROBABLY_OUGHT_TO_KNOW_WHAT_YOU_ARE_DONG
rather than GREAT_NEW_OPTION_TRY_ME_TRY_ME. However, a suitably worded
caveat in the documentation might be a better method.
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
next prev parent reply other threads:[~2008-04-17 16:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 15:31 Vincent Lefevre
2008-04-17 9:40 ` Peter Stephenson
2008-04-17 13:58 ` Bart Schaefer
2008-04-18 0:49 ` Vincent Lefevre
2008-04-18 1:24 ` Bart Schaefer
2008-04-17 16:23 ` Wayne Davison
2008-04-17 16:35 ` Peter Stephenson [this message]
2008-04-18 0:59 ` Vincent Lefevre
2008-04-19 2:31 ` Wayne Davison
2008-04-19 5:23 ` Bart Schaefer
2008-04-19 18:35 ` Wayne Davison
2008-04-21 13:19 ` Vincent Lefevre
2008-05-05 1:25 ` Wayne Davison
2009-01-01 4:01 ` Vincent Lefevre
2009-01-01 4:12 ` Vincent Lefevre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804171635.m3HGZ3dD007677@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).