can't set tty pgrp

can't set tty pgrp

[Vin Shelton]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

The process group changes seem to have broken something:


: ~ Thu 19 6:52; vi
^Z
zsh: suspended  vi
: ~ Thu 19 6:52; fg
[1]  + continued  vi
zsh: can't set tty pgrp: no such process


This is built from the latest sources, on debian.

Thanks,
  Vin

Re: can't set tty pgrp

[Peter Stephenson]

On Thu, 19 Apr 2018 06:57:40 -0400
Vin Shelton <acs@alumni.princeton.edu> wrote:
> The process group changes seem to have broken something:
> 
> 
> : ~ Thu 19 6:52; vi
> ^Z
> zsh: suspended  vi
> : ~ Thu 19 6:52; fg
> [1]  + continued  vi
> zsh: can't set tty pgrp: no such process

Yep, I remember thinking about this and forgetting to do anything...

The following looks like it ought to be safe.

diff --git a/Src/signals.c b/Src/signals.c
index 2a6aa3f..6e12158 100644
--- a/Src/signals.c
+++ b/Src/signals.c
@@ -537,7 +537,8 @@ wait_for_processes(void)
 #else
 		update_process(pn, status);
 #endif
-		if (pn->pid == jn->gleader) {
+		if (WIFEXITED(status) &&
+		    pn->pid == jn->gleader) {
 		    jn->gleader = 0;
 		    if (!(jn->stat & STAT_NOSTTY)) {
 			/*


pws

Re: can't set tty pgrp

[Vin Shelton]

[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]

Seems to work.  Thanks.  I think this is serious enough to merit a 5.5.2
release.  Thoughts?

  - Vin

On Thu, Apr 19, 2018 at 7:33 AM, Peter Stephenson <p.stephenson@samsung.com>
wrote:

> On Thu, 19 Apr 2018 06:57:40 -0400
> Vin Shelton <acs@alumni.princeton.edu> wrote:
> > The process group changes seem to have broken something:
> >
> >
> > : ~ Thu 19 6:52; vi
> > ^Z
> > zsh: suspended  vi
> > : ~ Thu 19 6:52; fg
> > [1]  + continued  vi
> > zsh: can't set tty pgrp: no such process
>
> Yep, I remember thinking about this and forgetting to do anything...
>
> The following looks like it ought to be safe.
>
> diff --git a/Src/signals.c b/Src/signals.c
> index 2a6aa3f..6e12158 100644
> --- a/Src/signals.c
> +++ b/Src/signals.c
> @@ -537,7 +537,8 @@ wait_for_processes(void)
>  #else
>                 update_process(pn, status);
>  #endif
> -               if (pn->pid == jn->gleader) {
> +               if (WIFEXITED(status) &&
> +                   pn->pid == jn->gleader) {
>                     jn->gleader = 0;
>                     if (!(jn->stat & STAT_NOSTTY)) {
>                         /*
>
>
> pws
>

Re: can't set tty pgrp

[Peter Stephenson]

On Thu, 19 Apr 2018 09:51:39 -0400
Vin Shelton <acs@alumni.princeton.edu> wrote:
> Seems to work.  Thanks.  I think this is serious enough to merit a
> 5.5.2 release.  Thoughts?

That change didn't go into 5.5.1; I applied it as soon as 5.5.1
was out of the way.

pws

Re: can't set tty pgrp

[Bart Schaefer]

On Thu, Apr 19, 2018 at 4:33 AM, Peter Stephenson
<p.stephenson@samsung.com> wrote:
> On Thu, 19 Apr 2018 06:57:40 -0400
> Vin Shelton <acs@alumni.princeton.edu> wrote:
>>
>> : ~ Thu 19 6:52; vi
>> ^Z
>> zsh: suspended  vi
>> : ~ Thu 19 6:52; fg
>> [1]  + continued  vi
>> zsh: can't set tty pgrp: no such process
>
> Yep, I remember thinking about this and forgetting to do anything...

Do we need a regression test for suspend+fg?

Re: can't set tty pgrp

[Peter Stephenson]

On Thu, 19 Apr 2018 07:33:04 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Thu, Apr 19, 2018 at 4:33 AM, Peter Stephenson
> <p.stephenson@samsung.com> wrote:
> > On Thu, 19 Apr 2018 06:57:40 -0400
> > Vin Shelton <acs@alumni.princeton.edu> wrote:  
> >>
> >> : ~ Thu 19 6:52; vi
> >> ^Z
> >> zsh: suspended  vi
> >> : ~ Thu 19 6:52; fg
> >> [1]  + continued  vi
> >> zsh: can't set tty pgrp: no such process  
> >
> > Yep, I remember thinking about this and forgetting to do
> > anything...  
> 
> Do we need a regression test for suspend+fg?

I haven't looked at W02jobs.ztst in any great detail (I committed
it but didn't write it), but it looks like it would be very helpful
and we could do with adding a whole set of fg and bg tests.

pws