PATCH: Possible copy paste error?

PATCH: Possible copy paste error?

[Mikael Magnusson]

Coverity noticed that this first branch of the if statement has "meta"
added to all the variable names except this zlecs at the end, should it?
(I'm asking the same question)
---
 Src/Zle/zle_utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Src/Zle/zle_utils.c b/Src/Zle/zle_utils.c
index fa0868245a..5046ee8784 100644
--- a/Src/Zle/zle_utils.c
+++ b/Src/Zle/zle_utils.c
@@ -799,7 +799,7 @@ spaceinline(int ct)
 		if (rhp->start_meta - sub >= zlemetacs) {
 		    rhp->start_meta += ct;
 		}
-		if (rhp->end_meta - sub >= zlemetacs && (!predisplaylen || zlecs)) {
+		if (rhp->end_meta - sub >= zlemetacs && (!predisplaylen || zlemetacs)) {
 		    rhp->end_meta += ct;
 		}
 	    }
-- 
2.38.1

Re: PATCH: Possible copy paste error?

[Peter Stephenson]

> On 28/02/2023 13:37 Mikael Magnusson <mikachu@gmail.com> wrote:
> Coverity noticed that this first branch of the if statement has "meta"
> added to all the variable names except this zlecs at the end, should it?
> (I'm asking the same question)

It should be all or nothing, yes.  Either the metafied version is valid
or it isn't and if it is the non-metafied version isn't currently useful.
(You might get away with it depending on what changed since conversion.)

pws