[PATCH] zsh x font family completion

[PATCH] zsh x font family completion

[Marko Myllynen]

Hi,

I'm working on completions for a command which has an option to select
the font family to use, I was wondering whether X font family
completions would be worthwhile to add for others to use as well?

Currently there's no any kind of caching, not sure would that be needed
on modern systems? When I looked at x_font for inspiration, it had a
big fat sign that its caching "*has* to be improved" so not sure what
would be considered elegant or optimal here.

Tested on RHEL 7.

---
 Completion/X/Type/_x_font_family | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 Completion/X/Type/_x_font_family

diff --git a/Completion/X/Type/_x_font_family b/Completion/X/Type/_x_font_family
new file mode 100644
index 0000000..48a1f23
--- /dev/null
+++ b/Completion/X/Type/_x_font_family
@@ -0,0 +1,6 @@
+#autoload
+
+local expl
+
+_wanted font-families expl 'font family' compadd "$@" \
+  ${(f)"$(fc-list : -f "%{family|downcase|delete( )|translate(\,,\n)}\n")"}

Thanks,

-- 
Marko Myllynen

Re: [PATCH] zsh x font family completion

[Mikael Magnusson]

On Mon, May 9, 2016 at 2:54 PM, Marko Myllynen <myllynen@redhat.com> wrote:
> Hi,
>
> I'm working on completions for a command which has an option to select
> the font family to use, I was wondering whether X font family
> completions would be worthwhile to add for others to use as well?
>
> Currently there's no any kind of caching, not sure would that be needed
> on modern systems? When I looked at x_font for inspiration, it had a
> big fat sign that its caching "*has* to be improved" so not sure what
> would be considered elegant or optimal here.
>
> Tested on RHEL 7.
>
> ---
>  Completion/X/Type/_x_font_family | 6 ++++++
>  1 file changed, 6 insertions(+)
>  create mode 100644 Completion/X/Type/_x_font_family
>
> diff --git a/Completion/X/Type/_x_font_family b/Completion/X/Type/_x_font_family
> new file mode 100644
> index 0000000..48a1f23
> --- /dev/null
> +++ b/Completion/X/Type/_x_font_family
> @@ -0,0 +1,6 @@
> +#autoload
> +
> +local expl
> +
> +_wanted font-families expl 'font family' compadd "$@" \
> +  ${(f)"$(fc-list : -f "%{family|downcase|delete( )|translate(\,,\n)}\n")"}
>
> Thanks,

It would probably be less confusing if this was called
_fc_font_family, since X fonts are something else. This one should
probably not even be in the X/ directory.

-- 
Mikael Magnusson

Re: [PATCH] zsh x font family completion

[Marko Myllynen]

Hi,

On 2016-05-09 16:04, Mikael Magnusson wrote:
> On Mon, May 9, 2016 at 2:54 PM, Marko Myllynen <myllynen@redhat.com> wrote:
>>
>> I'm working on completions for a command which has an option to select
>> the font family to use, I was wondering whether X font family
>> completions would be worthwhile to add for others to use as well?
>>
>> Currently there's no any kind of caching, not sure would that be needed
>> on modern systems? When I looked at x_font for inspiration, it had a
>> big fat sign that its caching "*has* to be improved" so not sure what
>> would be considered elegant or optimal here.
>>
>> +_wanted font-families expl 'font family' compadd "$@" \
>> +  ${(f)"$(fc-list : -f "%{family|downcase|delete( )|translate(\,,\n)}\n")"}
>>
> 
> It would probably be less confusing if this was called
> _fc_font_family, since X fonts are something else. This one should
> probably not even be in the X/ directory.

Fair enough - would you happen to have any suggestions on the new name
and location, I could send an updated patch then?

Thanks,

-- 
Marko Myllynen

Re: [PATCH] zsh x font family completion

[Oliver Kiddle]

Marko Myllynen wrote:
>
> I'm working on completions for a command which has an option to select
> the font family to use, I was wondering whether X font family
> completions would be worthwhile to add for others to use as well?

Note that there is an existing _xft_fonts function which does something
close to this. Would it work with the command you're writing a
completion for. It might be better to give it an option to limit it to
completing font families. Or does the command actually allow a size to
be specified.

Unlike for old style X fonts, the method of describing the newer fonts
is not as precisely defined.

Oliver

Re: [PATCH] zsh x font family completion

[Marko Myllynen]

Hi,

On 2016-05-11 18:01, Oliver Kiddle wrote:
> Marko Myllynen wrote:
>>
>> I'm working on completions for a command which has an option to select
>> the font family to use, I was wondering whether X font family
>> completions would be worthwhile to add for others to use as well?
> 
> Note that there is an existing _xft_fonts function which does something
> close to this. Would it work with the command you're writing a
> completion for. It might be better to give it an option to limit it to
> completing font families. Or does the command actually allow a size to
> be specified.

Hmm, not sure I managed to miss _xft_fonts but it does what I want,
let's forget this patch. (Although, FWIW, I must say I prefer the format
I had chosen over xft_fonts, i.e., lower-cased without spaces,
applications seem to accept both.)

Thanks,

-- 
Marko Myllynen