zsh-workers
 help / color / mirror / code / Atom feed
From: dana <dana@dana.is>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Peter Stephenson <p.stephenson@samsung.com>,
	Guillaume Chazarain <guichaz@gmail.com>,
	"zsh-workers@zsh.org" <zsh-workers@zsh.org>,
	Warepire - <warepire.ml@gmail.com>
Subject: Re: "off by one fix in multiple prompts" breaks multiline prompt
Date: Mon, 13 Aug 2018 17:44:32 -0500	[thread overview]
Message-ID: <8201EC10-DCE3-4E29-8B9A-C047E843153A@dana.is> (raw)
In-Reply-To: <CAH+w=7YdxsrwWdMtgtnvyojRae-m7g0BdawU9VUWgzC6shrk=Q@mail.gmail.com>

On 13 Aug 2018, at 16:45, Bart Schaefer <schaefer@brasslantern.com> wrote:
>This is why for years we tried to limit everything to 1 column less
>than the exact width.

Oh, yeah :/

On 13 Aug 2018, at 16:45, Bart Schaefer <schaefer@brasslantern.com> wrote:
>Presumably ZLE_RPROMPT_INDENT=0 helps in that case?

As far as i can tell, in Apple Terminal...

... when the check is > (as it is in the repo now), setting it to 0 causes the
editor to get lost as soon as i go past the last column. I think that's the same
behaviour Warepire found (can't remember in which terminal, but not Apple's)
when testing that setting at your suggestion before.

... when the check is >= (as it was before the previous change), setting it to 0
makes no difference. In the case of the last line wrapping, it works as expected
either way, and in the case of a new-line after the last column, the prompt
swallows the preceding line of input either way.

The change from >= to > seems bogus to me now — it only works by accident in
that one case. As far as the new-line check, i'm not sure how to determine if
that's a good direction, besides just trying it in different terminals. I can do
that later if it's not completely disproven already.

dana


  reply	other threads:[~2018-08-13 22:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180810072702epcas5p4ecaa5cffa5dc7668e2b2aa3a30824f36@epcas5p4.samsung.com>
2018-08-10  7:26 ` Guillaume Chazarain
2018-08-13  8:42   ` Peter Stephenson
2018-08-13 11:22     ` Guillaume Chazarain
2018-08-13 11:36       ` Peter Stephenson
2018-08-13 11:42         ` Guillaume Chazarain
2018-08-13 12:58           ` Peter Stephenson
2018-08-13 14:19             ` dana
2018-08-13 18:34               ` Guillaume Chazarain
2018-08-13 21:29               ` dana
2018-08-13 21:45                 ` Bart Schaefer
2018-08-13 22:44                   ` dana [this message]
2018-08-14  8:30                     ` Peter Stephenson
2018-08-14  6:41                 ` Guillaume Chazarain
     [not found]       ` <20180813123639.5899f64e@camnpupstephen.cam.scsc.local>
2018-08-13 11:40         ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8201EC10-DCE3-4E29-8B9A-C047E843153A@dana.is \
    --to=dana@dana.is \
    --cc=guichaz@gmail.com \
    --cc=p.stephenson@samsung.com \
    --cc=schaefer@brasslantern.com \
    --cc=warepire.ml@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).