From: Peter Stephenson <p.stephenson@samsung.com>
To: Guillaume Chazarain <guichaz@gmail.com>, <zsh-workers@zsh.org>
Cc: <warepire.ml@gmail.com>
Subject: Re: "off by one fix in multiple prompts" breaks multiline prompt
Date: Mon, 13 Aug 2018 12:40:58 +0100 [thread overview]
Message-ID: <20180813114059eucas1p22be8ab1a3db1eafa23a1f30b87418723~Kbs9Rspp11802018020eucas1p2-@eucas1p2.samsung.com> (raw)
In-Reply-To: <20180813123639.5899f64e@camnpupstephen.cam.scsc.local>
On Mon, 13 Aug 2018 12:36:39 +0100
Peter Stephenson <p.stephenson@samsung.com> wrote:
> On Mon, 13 Aug 2018 13:22:31 +0200
> Guillaume Chazarain <guichaz@gmail.com> wrote:
> > On Mon, Aug 13, 2018 at 10:43 AM Peter Stephenson
> > <p.stephenson@samsung.com> wrote:
> >
> > > The problem with this is all terminals are a bit different in
> > > generally undetectable ways
> >
> > Is there a graphical terminal emulator that works on Linux and that
> > does not exhibit the multi-line issue
> > <https://gfycat.com/DecimalAdmiredJumpingbean>?
> > I could reproduce the issue on gnome-terminal, xterm, rxvt.
> > And I could also reproduce the issue that the commit fixed:
> > http://www.zsh.org/mla/workers/2018/msg00093.html
> > So I see a consistent behavior across these 3 terminals.
>
> So you're saying the commit you say is causing the problem isn't
> fixing the problem it was supposed to fix? That implies something
> else changed, since dana tried it out at the time and said it worked.
>
> I will certainly not be jumping into this myself now --- does someone
> else want to look?
or is this comment from dana about the original patch relevant?
> PS: When i was testing it i had changed the comparison in both places;
> as mentioned, the patch as submitted only changes the first one.
pws
prev parent reply other threads:[~2018-08-13 11:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180810072702epcas5p4ecaa5cffa5dc7668e2b2aa3a30824f36@epcas5p4.samsung.com>
2018-08-10 7:26 ` Guillaume Chazarain
2018-08-13 8:42 ` Peter Stephenson
2018-08-13 11:22 ` Guillaume Chazarain
2018-08-13 11:36 ` Peter Stephenson
2018-08-13 11:42 ` Guillaume Chazarain
2018-08-13 12:58 ` Peter Stephenson
2018-08-13 14:19 ` dana
2018-08-13 18:34 ` Guillaume Chazarain
2018-08-13 21:29 ` dana
2018-08-13 21:45 ` Bart Schaefer
2018-08-13 22:44 ` dana
2018-08-14 8:30 ` Peter Stephenson
2018-08-14 6:41 ` Guillaume Chazarain
[not found] ` <20180813123639.5899f64e@camnpupstephen.cam.scsc.local>
2018-08-13 11:40 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20180813114059eucas1p22be8ab1a3db1eafa23a1f30b87418723~Kbs9Rspp11802018020eucas1p2-@eucas1p2.samsung.com' \
--to=p.stephenson@samsung.com \
--cc=guichaz@gmail.com \
--cc=warepire.ml@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).