From: dana <dana@dana.is>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: Guillaume Chazarain <guichaz@gmail.com>,
zsh-workers@zsh.org, warepire.ml@gmail.com
Subject: Re: "off by one fix in multiple prompts" breaks multiline prompt
Date: Mon, 13 Aug 2018 09:19:41 -0500 [thread overview]
Message-ID: <3F00E10A-6A65-4201-A4E2-2A29929111C1@dana.is> (raw)
In-Reply-To: <20180813125810eucas1p181a58cb55dc815863d6d81e1cd629d71~KcwV9B7ZD1627716277eucas1p1o@eucas1p1.samsung.com>
On 13 Aug 2018, at 07:58, Peter Stephenson <p.stephenson@samsung.com> wrote:
>I suspect dana was saying we need something like this? Has this got
>anything to do with it? (Second guessing other people's fixes is really
>hard work...)
Yeah, i probably should have tested the patch that was actually submitted,
sorry. We were kind of working on it in parallel after Wapire suggested on IRC
that that might be a fix to their problem.
The additional change you mentioned addresses the difference between the patch
as submitted and what i was testing. However, i just tried it and it does not
fix this issue (where the last 'hard' line of the prompt wraps).
Looking at that function again, i wonder if the original problem was actually
related to the fact that it compares the current column count (and
potentially increments the height) before checking whether the current character
is a new-line? That would explain why it was producing an extra cup when it
encountered a line that was exactly as wide as the screen.
dana
next prev parent reply other threads:[~2018-08-13 14:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180810072702epcas5p4ecaa5cffa5dc7668e2b2aa3a30824f36@epcas5p4.samsung.com>
2018-08-10 7:26 ` Guillaume Chazarain
2018-08-13 8:42 ` Peter Stephenson
2018-08-13 11:22 ` Guillaume Chazarain
2018-08-13 11:36 ` Peter Stephenson
2018-08-13 11:42 ` Guillaume Chazarain
2018-08-13 12:58 ` Peter Stephenson
2018-08-13 14:19 ` dana [this message]
2018-08-13 18:34 ` Guillaume Chazarain
2018-08-13 21:29 ` dana
2018-08-13 21:45 ` Bart Schaefer
2018-08-13 22:44 ` dana
2018-08-14 8:30 ` Peter Stephenson
2018-08-14 6:41 ` Guillaume Chazarain
[not found] ` <20180813123639.5899f64e@camnpupstephen.cam.scsc.local>
2018-08-13 11:40 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F00E10A-6A65-4201-A4E2-2A29929111C1@dana.is \
--to=dana@dana.is \
--cc=guichaz@gmail.com \
--cc=p.stephenson@samsung.com \
--cc=warepire.ml@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).