From: Bart Schaefer <schaefer@brasslantern.com>
To: dana <dana@dana.is>
Cc: Peter Stephenson <p.stephenson@samsung.com>,
Guillaume Chazarain <guichaz@gmail.com>,
"zsh-workers@zsh.org" <zsh-workers@zsh.org>,
Warepire - <warepire.ml@gmail.com>
Subject: Re: "off by one fix in multiple prompts" breaks multiline prompt
Date: Mon, 13 Aug 2018 14:45:37 -0700 [thread overview]
Message-ID: <CAH+w=7YdxsrwWdMtgtnvyojRae-m7g0BdawU9VUWgzC6shrk=Q@mail.gmail.com> (raw)
In-Reply-To: <383CC796-865C-4774-A9C2-AD44997784B4@dana.is>
On Mon, Aug 13, 2018 at 2:29 PM, dana <dana@dana.is> wrote:
>
> I think that was in fact the problem. So if we revert the previous change, and
> then add an additional check for a last-column new-line, we end up with
> something like the attached. This seems to fix both the original issue and the
> new one for me, but obviously further testing would be nice
There are terminals that immediately scroll upon a newline being
written after the last column, especially if it is the last column of
the last line (which is where the prompt most often is). So sometimes
a double-increment may be necessary, and its hard to tell when.
This is why for years we tried to limit everything to 1 column less
than the exact width.
Presumably ZLE_RPROMPT_INDENT=0 helps in that case?
next prev parent reply other threads:[~2018-08-13 21:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180810072702epcas5p4ecaa5cffa5dc7668e2b2aa3a30824f36@epcas5p4.samsung.com>
2018-08-10 7:26 ` Guillaume Chazarain
2018-08-13 8:42 ` Peter Stephenson
2018-08-13 11:22 ` Guillaume Chazarain
2018-08-13 11:36 ` Peter Stephenson
2018-08-13 11:42 ` Guillaume Chazarain
2018-08-13 12:58 ` Peter Stephenson
2018-08-13 14:19 ` dana
2018-08-13 18:34 ` Guillaume Chazarain
2018-08-13 21:29 ` dana
2018-08-13 21:45 ` Bart Schaefer [this message]
2018-08-13 22:44 ` dana
2018-08-14 8:30 ` Peter Stephenson
2018-08-14 6:41 ` Guillaume Chazarain
[not found] ` <20180813123639.5899f64e@camnpupstephen.cam.scsc.local>
2018-08-13 11:40 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YdxsrwWdMtgtnvyojRae-m7g0BdawU9VUWgzC6shrk=Q@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=dana@dana.is \
--cc=guichaz@gmail.com \
--cc=p.stephenson@samsung.com \
--cc=warepire.ml@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).