From: Bart Schaefer <schaefer@brasslantern.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org,
"Philippe Altherr" <philippe.altherr@gmail.com>,
"Lawrence Velázquez" <larryv@zsh.org>
Subject: Re: Submitting multiple patches (was: Re: [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements)
Date: Wed, 23 Nov 2022 13:54:42 -0800 [thread overview]
Message-ID: <CAH+w=7a2QDhHQc2sHZi1dpvHfBYDK37tsoyfz59HA3cmbbcBWQ@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7akMutXBaRCxVxG1eUQ0SH2Km_EXxojX5Yq9Xa0zgOp+A@mail.gmail.com>
On Wed, Nov 23, 2022 at 1:11 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> The ONLY issue with Philippe's message, if there is any
> problem with it at all, is that two of the patches overlapped on one
> of the files, such that one backed out a change and then another put
> that same change back again.
This also seems to reflect a philosophical point that it might be
worth mentioning in the development guide (which is probably overdue
for an overhaul in general). Namely, Philippe felt it important to
have one patch that completely backed out two or more of my previous
patches, followed by a patch that incorporated a useful part of one of
those patches.
This isn't generally how we've approached things -- we just move
forward incrementally from the tip of the branch.
next prev parent reply other threads:[~2022-11-23 21:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 14:40 [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements Philippe Altherr
2022-11-19 13:39 ` Philippe Altherr
2022-11-21 0:43 ` Bart Schaefer
2022-11-21 7:22 ` Lawrence Velázquez
2022-11-22 2:52 ` Philippe Altherr
2022-11-22 4:51 ` Bart Schaefer
2022-11-22 10:17 ` Peter Stephenson
2022-11-23 8:11 ` Lawrence Velázquez
2022-11-23 6:59 ` Lawrence Velázquez
2022-11-23 9:43 ` Philippe Altherr
2022-11-23 16:11 ` Bart Schaefer
2022-11-23 20:57 ` Submitting multiple patches (was: Re: [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements) Daniel Shahaf
2022-11-23 21:11 ` Bart Schaefer
2022-11-23 21:22 ` Bart Schaefer
2022-11-23 21:54 ` Bart Schaefer [this message]
2022-11-24 2:21 ` Philippe Altherr
2022-11-26 2:28 ` Bart Schaefer
2022-11-26 4:02 ` Philippe Altherr
2022-11-24 1:47 ` [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements Philippe Altherr
2022-11-24 4:28 ` Lawrence Velázquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7a2QDhHQc2sHZi1dpvHfBYDK37tsoyfz59HA3cmbbcBWQ@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=d.s@daniel.shahaf.name \
--cc=larryv@zsh.org \
--cc=philippe.altherr@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).