From: Bart Schaefer <schaefer@brasslantern.com>
To: Roman Perepelitsa <roman.perepelitsa@gmail.com>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: Incorrect cursor position when ZLE_RPROMPT_INDENT=0 (with a fix)
Date: Sun, 19 May 2019 10:04:48 -0700 [thread overview]
Message-ID: <CAH+w=7bYdLornMBJmjE_RHgiRcywT05FXkOQdSapZHkdT30X0A@mail.gmail.com> (raw)
In-Reply-To: <CAN=4vMpx_B5TRNQzDAvBoTFszoKea2=uQr5xjd0vZVH6py+oVA@mail.gmail.com>
We constantly go around on this. If we un-break it for one terminal
type it breaks for another. It's an acknowledged problem that in some
cases you can't set ZLE_RPROMPT_INDENT=0, that's why the variable
exists in the first place; if it always worked to set it to zero we'd
remove it.
All your patch does is remove a test for the value of that variable.
A more correct change would be to add to the test condition a check
for whether placing a character in the rightmost column (or the
rightmost/bottom-most position) causes the terminal to auto-wrap (or
not) the cursor onto the next line. Unfortunately there's no way to
reliably determine that (e.g., there's no termcap/terminfo value that
reports it consistently).
What $ZSH_PATCHLEVEL were you testing against? There was a related
change committed only a month ago, and there has not been a release in
the meantime.
next prev parent reply other threads:[~2019-05-19 17:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-19 15:38 Roman Perepelitsa
2019-05-19 15:41 ` Roman Perepelitsa
2019-05-19 17:04 ` Bart Schaefer [this message]
2019-05-19 17:34 ` Roman Perepelitsa
2019-05-19 18:09 ` Roman Perepelitsa
2019-05-19 18:51 ` Roman Perepelitsa
2019-05-19 20:12 ` Bart Schaefer
2019-05-19 21:07 ` Roman Perepelitsa
2019-05-20 8:21 ` Yannic Schröder
2019-05-20 8:36 ` Roman Perepelitsa
2019-05-20 10:21 ` Charles Blake
2019-05-20 10:46 ` Roman Perepelitsa
2019-05-20 11:06 ` Daniel Shahaf
2019-05-20 11:07 ` Charles Blake
2019-05-20 11:11 ` Peter Stephenson
2019-05-20 11:32 ` Roman Perepelitsa
2019-05-20 12:41 ` Charles Blake
2019-05-20 13:16 ` Roman Perepelitsa
[not found] ` <CAKiz1a-nOkAe42JoxFRgMJ+LXZ3fgMxqgwNZOW+2Y45oqzu8hA@mail.gmail.com>
2019-05-20 13:55 ` Roman Perepelitsa
2019-05-23 5:48 ` Roman Perepelitsa
2019-05-23 21:36 ` Daniel Shahaf
2019-05-23 22:52 ` Roman Perepelitsa
2019-05-24 12:18 ` Daniel Shahaf
2019-05-27 15:36 ` Roman Perepelitsa
2019-05-27 21:51 ` Peter Stephenson
2019-05-28 8:44 ` Peter Stephenson
2019-05-28 8:46 ` Roman Perepelitsa
2019-05-28 14:26 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7bYdLornMBJmjE_RHgiRcywT05FXkOQdSapZHkdT30X0A@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=roman.perepelitsa@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).