From: Mikael Magnusson <mikachu@gmail.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Remove redundancies from `git` completion
Date: Mon, 30 Aug 2021 13:41:17 +0200 [thread overview]
Message-ID: <CAHYJk3SpQ1KibJtbjOvEputdVL3XEeJywKewk-xxEgZxgLXowg@mail.gmail.com> (raw)
In-Reply-To: <CAHLkEDt9=VdVFqvvwUfXb8HBO_uxZAnaS7f_gtBTSHy_XLMWsg@mail.gmail.com>
On 8/30/21, Marlon Richert <marlon.richert@gmail.com> wrote:
> In _git-show, remove calls to __git_commits and __git_tags.
> Rationale: 'commits' and 'tags' are already added by __git_trees.
> Adding them twice makes `zstyle ... tag-order` give unexpected
> results.
>
> In __git_recent_commits, remove the line that adds 'heads'.
> Rationale: The completion for most subcommands already adds
> 'heads-local' and 'heads-remote'. Adding an additional 'heads' inside
> __git_recent_commits results in heads being listed twice in two
> separate groups.
>
>
> By the way: Why is there a `(( $+functions[_git-XXX] )) ||` statement
> in front of each function inside Completion/Unix/Command/_git ? Can
> those be removed?
They are there so that you can override their implementation easily.
--
Mikael Magnusson
next prev parent reply other threads:[~2021-08-30 11:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 11:17 Marlon Richert
2021-08-30 11:41 ` Mikael Magnusson [this message]
2021-08-30 12:34 ` Marlon Richert
2021-08-30 12:42 ` Mikael Magnusson
2021-08-31 5:52 ` Marlon Richert
2021-09-01 14:03 ` Daniel Shahaf
2021-09-01 18:22 ` Bart Schaefer
2021-09-02 6:17 ` Marlon Richert
2021-09-02 20:51 ` Oliver Kiddle
2021-09-02 20:54 ` Bart Schaefer
2021-09-02 21:17 ` Oliver Kiddle
2021-09-01 13:56 ` Daniel Shahaf
2021-09-02 8:57 ` Marlon Richert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3SpQ1KibJtbjOvEputdVL3XEeJywKewk-xxEgZxgLXowg@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).