zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: zsh-workers@zsh.org, Oliver Kiddle <opk@zsh.org>, dana <dana@dana.is>
Subject: Re: [PATCH] prompt: support generic non-visible regions
Date: Wed, 10 Aug 2022 20:59:21 +0200	[thread overview]
Message-ID: <CAHYJk3SvZEWxiN9Tvy9jm5H2qKbO1yUZtA9iPVw2-YMxiG=5Xw@mail.gmail.com> (raw)
In-Reply-To: <20220810115120.182853-1-felipe.contreras@gmail.com>

On 8/10/22, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> readline assumes anything between \001 (start of header) and \002 (start
> of text) is non-visible characters.
>
> In zsh we do this with `%F{color}`, but we could support
> `\001\e[31m\002` as well.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>
> I don't know if this is the right way to do it, but in my limited
> testing it seems to work fine.

The commit message seems a bit confused, %F has nothing to do with
marking characters as 0-width, rather everything between %{ and %}
will be treated as such. You can use %{%} (or \001 and \002) to set
colors via the specific \e [ Ps m code, but also to send any other
codes handled by the terminal.

That aside, I don't really see a reason to add support for
bash-specific prompt sequences that are more cumbersome to use than
the already existing zsh ones. Bash prompts are already completely
incompatible anyway.

-- 
Mikael Magnusson


  reply	other threads:[~2022-08-10 19:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10 11:51 Felipe Contreras
2022-08-10 18:59 ` Mikael Magnusson [this message]
2022-08-10 19:56   ` Felipe Contreras
2022-08-11 14:02     ` Mikael Magnusson
2022-08-11 14:26       ` Felipe Contreras
2022-08-11 18:32         ` Mikael Magnusson
2022-08-11 18:47           ` Felipe Contreras
2022-08-11 18:54             ` Mikael Magnusson
2022-08-11 19:46               ` Felipe Contreras
2022-08-11 20:38                 ` Bart Schaefer
2022-08-11 23:22                   ` Felipe Contreras
2022-08-11 14:37 ` Roman Perepelitsa
2022-08-11 15:21   ` Bart Schaefer
2022-08-11 16:20     ` Felipe Contreras
2022-08-11 16:49       ` Bart Schaefer
2022-08-11 18:48         ` Felipe Contreras
2022-08-11 17:24   ` Roman Perepelitsa
2022-08-11 18:55     ` Roman Perepelitsa
2022-08-11 19:23     ` Felipe Contreras
2022-08-11 19:35       ` Roman Perepelitsa
2022-08-11 19:44         ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHYJk3SvZEWxiN9Tvy9jm5H2qKbO1yUZtA9iPVw2-YMxiG=5Xw@mail.gmail.com' \
    --to=mikachu@gmail.com \
    --cc=dana@dana.is \
    --cc=felipe.contreras@gmail.com \
    --cc=opk@zsh.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).