From: Felipe Contreras <felipe.contreras@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Roman Perepelitsa <roman.perepelitsa@gmail.com>,
Zsh hackers list <zsh-workers@zsh.org>,
Oliver Kiddle <opk@zsh.org>, dana <dana@dana.is>
Subject: Re: [PATCH] prompt: support generic non-visible regions
Date: Thu, 11 Aug 2022 11:20:42 -0500 [thread overview]
Message-ID: <CAMP44s3HxGbUSe2Eauy20mknCLZ4DjVw0+QNZFW3dhd_FmcbYw@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7am4mzUae3+YAuWgvPsugGUbUCJkFys5eNZ87MUTTtR6Q@mail.gmail.com>
On Thu, Aug 11, 2022 at 10:21 AM Bart Schaefer
<schaefer@brasslantern.com> wrote:
>
> On Thu, Aug 11, 2022, 9:38 AM Roman Perepelitsa <roman.perepelitsa@gmail.com> wrote:
>>
>> I like this patch but for a different reason. It closes the capability
>> gap in zsh prompts with and without prompt_percent.
>
> I've been traveling this week without access to the source code so haven't otherwise commented on this, but:
>
> 1. Roman's point above is valid.
>
> 2. As previously mentioned by others, this is related to %{ %} rather than to %F, and should be implemented and documented as such. One cannot write $'\001red\002' (I presume) and it would not be generally useful in that context.
More related, yes, but %F does do the equivalent of %{%} internally (I
didn't know what %{%} did when I wrote the commit message).
For reference bash does have the equivalent of that with \[ \], but
that's specific to bash and it's converted to \001 \002 internally
which is what readline understands. A prompt function (like
__git_ps1()) cannot return \[ \].
> 3. Escapes for ctrl-a and ctrl-b also work? Or this is explicitly looking for \001 \002 ? Any possible conflicts?
^A ^B are another way to say \001 \002 is it not? Or \x01 \x02. At the
end of the day are the same values.
I don't know how to echo ^A in order to test though.
--
Felipe Contreras
next prev parent reply other threads:[~2022-08-11 16:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 11:51 Felipe Contreras
2022-08-10 18:59 ` Mikael Magnusson
2022-08-10 19:56 ` Felipe Contreras
2022-08-11 14:02 ` Mikael Magnusson
2022-08-11 14:26 ` Felipe Contreras
2022-08-11 18:32 ` Mikael Magnusson
2022-08-11 18:47 ` Felipe Contreras
2022-08-11 18:54 ` Mikael Magnusson
2022-08-11 19:46 ` Felipe Contreras
2022-08-11 20:38 ` Bart Schaefer
2022-08-11 23:22 ` Felipe Contreras
2022-08-11 14:37 ` Roman Perepelitsa
2022-08-11 15:21 ` Bart Schaefer
2022-08-11 16:20 ` Felipe Contreras [this message]
2022-08-11 16:49 ` Bart Schaefer
2022-08-11 18:48 ` Felipe Contreras
2022-08-11 17:24 ` Roman Perepelitsa
2022-08-11 18:55 ` Roman Perepelitsa
2022-08-11 19:23 ` Felipe Contreras
2022-08-11 19:35 ` Roman Perepelitsa
2022-08-11 19:44 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s3HxGbUSe2Eauy20mknCLZ4DjVw0+QNZFW3dhd_FmcbYw@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=dana@dana.is \
--cc=opk@zsh.org \
--cc=roman.perepelitsa@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).