[BUG] Appending by arr[@]//(#e)/... crashes Zsh on WSL

[BUG] Appending by arr[@]//(#e)/... crashes Zsh on WSL

[Sebastian Gniazdowski]

Hello,
I've just fixed a long standing bug in F-Sy-H:

https://github.com/zdharma/fast-syntax-highlighting/issues/146

by a patch that changed appending to an array from:

arr=( ${arr[@]//(#e)/an-appendage} )

with a manual loop:

for __ in ${arr[@]}; do
__s+=( ${__}an-appendage )
done

The exact commit is:
https://github.com/zdharma/fast-syntax-highlighting/commit/9a6f

I guess that a Valgrind run would be helpful. BTW. How are the
automatic Valgrind tests doing? They would be helpful now.

-- 
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org

Re: [BUG] Appending by arr[@]//(#e)/... crashes Zsh on WSL

[Sebastian Gniazdowski]

PS. The commit might seem to be doing more, but in an investigation
branch the step was only the append-method switch:

https://github.com/zdharma/fast-syntax-highlighting/commit/6590

On Mon, 21 Oct 2019 at 15:30, Sebastian Gniazdowski
<sgniazdowski@gmail.com> wrote:
>
> Hello,
> I've just fixed a long standing bug in F-Sy-H:
>
> https://github.com/zdharma/fast-syntax-highlighting/issues/146
>
> by a patch that changed appending to an array from:
>
> arr=( ${arr[@]//(#e)/an-appendage} )
>
> with a manual loop:
>
> for __ in ${arr[@]}; do
> __s+=( ${__}an-appendage )
> done
>
> The exact commit is:
> https://github.com/zdharma/fast-syntax-highlighting/commit/9a6f
>
> I guess that a Valgrind run would be helpful. BTW. How are the
> automatic Valgrind tests doing? They would be helpful now.
>
> --
> Sebastian Gniazdowski
> News: https://twitter.com/ZdharmaI
> IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
> Blog: http://zdharma.org



-- 
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org