Re: [9front] core-i5(TypeSNB) and vesa mode

[kokamoto@hera.eonet.ne.jp]

> - 		p->fdi->txctl.v &= ~(7<<8 | 1);	/* clear auto training bits */
> - 		p->fdi->txctl.v &= ~(1<<31);
> - 		p->fdi->rxctl.v |= (1<<14);	/* enable pll */
> - 		loadreg(igfx, p->fdi->txctl);
> - 		sleep(5);
> + 		if(igfx->type == TypeSNB){	/* K.Okamoto */	
> + 			p->fdi->txctl.v |= (1<<14);	/* enable FDI pll K.Okamoto */
> + 			loadreg(igfx, p->fdi->txctl);
> + 			sleep(5);
> + 		}else{
> + 			p->fdi->txctl.v &= ~(7<<8 | 1);	/* clear auto training bits */
> + 			p->fdi->txctl.v &= ~(1<<31);	/* disable */
> + 			p->fdi->rxctl.v |= (1<<14);	/* DMI link reversal strap RO bit */
> + 			loadreg(igfx, p->fdi->txctl);
> + 			sleep(5);
> + 		}
> 
> this is interesting... in SNB code, you set txtctl bit 14, but
> in my previous code i set *RX*ctl bit 14, which is not even used
> because it is never written to hardware afterwards. so i wonder
> if the special case for SNB is actually needed... given that this
> looks like a typo on my side but it apparently has no problems
> on my IVY bridge machine.

I'm now ignorant of TypeIVB(I have no haerware), so there may be some faults.
I just tried to use TypeSNB, because I still have no clear view of the igfx.c. :-)
So, I expect you can incorporate with my code, and write better one.

> i propose you change the code to:
> 
> 		p->fdi->txctl.v &= ~(7<<8 | 1);	/* clear auto training bits */
> 		p->fdi->txctl.v &= ~(1<<31);	/* disable */
> 		p->fdi->txctl.v |= (1<<14);	/* DMI link reversal strap RO bit */
> 		loadreg(igfx, p->fdi->txctl);
> 		sleep(5);
> 
> and see if this still works. can you do that?

Before it, I noticed the my code doen't work for my another display
(s2231wA, 1680x1050x32), and I'm now working for it.
If it could finish, I will try it.

Kenji