9front - general discussion about 9front
 help / color / mirror / Atom feed
From: ori@eigenstate.org
To: 9front@9front.org
Subject: Re: [9front] [PATCH] Fix assert macro to not break on commas
Date: Sun, 26 Nov 2023 17:52:52 -0500	[thread overview]
Message-ID: <8C8881A0ADB4FC714B2D0DBD3F1D1D7A@eigenstate.org> (raw)
In-Reply-To: <f950c502-003d-4a43-90d4-7af1d80977b5@invalid.invalid>

Quoth Blue-Maned_Hawk <bluemanedhawk@gmail.com>:
> On 11/26/23 13:13, ori@eigenstate.org wrote:
> > Quoth Blue-Maned_Hawk <bluemanedhawk@gmail.com>:
> >> I'm just new around here.
> > 
> > In general, we try pretty hard to avoid doing stuff
> > in macros. There are places where it's unavoidable,
> > but excluding ape, there's more #ifdef in ghostscript
> > than in the rest of the system combined.
> > 
> 
> I don't understand why you're bringing up ifdefs.  That's a completely 
> different part of the preprocessor, unrelated to macros (though usable 
> in combination with them).
> 
> What reason have y'all for avoiding macros?

Well, the fact that you need hacks like the one that started this
thread, for one; what if you had  macro that took *two* arguments?

	#define assert_msg(cond, msg) \
		...what here?

I don't see how you can avoid just saying "it's a macro, it's going
to be weird, don't even try".


  reply	other threads:[~2023-11-26 22:54 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 23:11 Blue-Maned_Hawk
2023-11-23  4:20 ` Jacob Moody
2023-11-25  0:27   ` Blue-Maned_Hawk
2023-11-25  1:09     ` Jacob Moody
2023-11-25  4:34     ` ori
2023-11-25 12:09       ` Blue-Maned_Hawk
2023-11-25 18:46         ` Kurt H Maier
2023-11-25 20:06           ` Steve Simon
2023-11-25 20:39             ` Dan Cross
2023-11-25 22:47               ` Steve Simon
2023-11-26  2:22               ` Kurt H Maier
2023-11-26 17:31                 ` Blue-Maned_Hawk
2023-11-26 18:13                   ` ori
2023-11-26 22:39                     ` Blue-Maned_Hawk
2023-11-26 22:52                       ` ori [this message]
2023-11-26 23:30                         ` Blue-Maned_Hawk
2023-11-27  0:00                           ` ori
2023-11-27 11:20                             ` Blue-Maned_Hawk
2023-11-27 15:38                               ` ori
2023-11-27 15:59                                 ` Dan Cross
2023-11-27 22:21                                 ` Blue-Maned_Hawk
2023-11-27 23:59                                   ` ori
2023-11-28  0:30                                     ` Blue-Maned_Hawk
2023-11-28  0:34                                       ` ori
2023-11-29  9:14                                         ` Blue-Maned_Hawk
2023-11-26 19:58                   ` Kurt H Maier
2023-11-26 22:37                     ` Blue-Maned_Hawk
2023-11-25  4:49     ` ori
2023-11-26 18:59     ` Amavect
     [not found]       ` <7025e6e9-fca5-4648-aaea-a80260c35739@sirjofri.de>
2023-11-26 21:11         ` sirjofri
2023-11-26 22:41       ` Blue-Maned_Hawk
2023-11-27 15:44         ` Amavect
2023-11-26 22:36 ` ori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8C8881A0ADB4FC714B2D0DBD3F1D1D7A@eigenstate.org \
    --to=ori@eigenstate.org \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).