Re: [9front] [PATCH] Fix assert macro to not break on commas

[ori@eigenstate.org]

Quoth Blue-Maned_Hawk <bluemanedhawk@gmail.com>:
> On 11/22/23 23:20, Jacob Moody wrote:
> > On 11/22/23 17:11, Blue-Maned_Hawk wrote:
> >> This is a pair of patches that changes the assert macro to be variadic,
> >> allowing expressions with commas in them to be used without needing a
> >> spare pair of parentheses, and updates the manpage accordingly.
> >> \x1f
> > 
> > For what reason does this need changed?
> 
> To avoid (admittedly, edge) cases where a comma in the expression being 
> asserted would be incorrectly interpretted as an attempt to invoke a 
> single-argument macro with two or more arguments.
> 
> > Is there some code you're working with expecting this?
> 
> No.
> 
> > I am inclined to prefer to keep this as is.
> 
> Why?
> 


...for that matter, I'd be more inclined to remove
the stringification from the assert, and just make
it into a regular function:

	void assert(int);

and make the relevant adjustments; you have the snap
when the abort triggers, so there's not really much
need to print the condition.