From: Amavect <amavect@gmail.com>
To: 9front@9front.org
Subject: Re: [9front] [PATCH] Fix assert macro to not break on commas
Date: Sun, 26 Nov 2023 12:59:21 -0600 [thread overview]
Message-ID: <CAGOW0YMn1rRNAw=COHLYFvVFJwwOZLhr=5GcKuCRgs-=-2XO+A@mail.gmail.com> (raw)
In-Reply-To: <8708ecaa-0b89-430d-ad06-2fd272680660@invalid.invalid>
On Fri, Nov 24, 2023 at 6:29 PM Blue-Maned_Hawk <bluemanedhawk@gmail.com> wrote:
> > For what reason does this need changed?
>
> To avoid (admittedly, edge) cases where a comma in the expression being
> asserted would be incorrectly interpretted as an attempt to invoke a
> single-argument macro with two or more arguments.
>
> > Is there some code you're working with expecting this?
>
> No.
Concurring opinion to not change this.
Worst case is some valid programs don't compile.
Don't add needless abstraction for situations you don't have.
If you have programs that you want to compile,
just share the relevant code and either we'd start arguing about how to
make that code better, or just commit the macro patch.
Thanks,
Amavect
next prev parent reply other threads:[~2023-11-26 19:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 23:11 Blue-Maned_Hawk
2023-11-23 4:20 ` Jacob Moody
2023-11-25 0:27 ` Blue-Maned_Hawk
2023-11-25 1:09 ` Jacob Moody
2023-11-25 4:34 ` ori
2023-11-25 12:09 ` Blue-Maned_Hawk
2023-11-25 18:46 ` Kurt H Maier
2023-11-25 20:06 ` Steve Simon
2023-11-25 20:39 ` Dan Cross
2023-11-25 22:47 ` Steve Simon
2023-11-26 2:22 ` Kurt H Maier
2023-11-26 17:31 ` Blue-Maned_Hawk
2023-11-26 18:13 ` ori
2023-11-26 22:39 ` Blue-Maned_Hawk
2023-11-26 22:52 ` ori
2023-11-26 23:30 ` Blue-Maned_Hawk
2023-11-27 0:00 ` ori
2023-11-27 11:20 ` Blue-Maned_Hawk
2023-11-27 15:38 ` ori
2023-11-27 15:59 ` Dan Cross
2023-11-27 22:21 ` Blue-Maned_Hawk
2023-11-27 23:59 ` ori
2023-11-28 0:30 ` Blue-Maned_Hawk
2023-11-28 0:34 ` ori
2023-11-29 9:14 ` Blue-Maned_Hawk
2023-11-26 19:58 ` Kurt H Maier
2023-11-26 22:37 ` Blue-Maned_Hawk
2023-11-25 4:49 ` ori
2023-11-26 18:59 ` Amavect [this message]
[not found] ` <7025e6e9-fca5-4648-aaea-a80260c35739@sirjofri.de>
2023-11-26 21:11 ` sirjofri
2023-11-26 22:41 ` Blue-Maned_Hawk
2023-11-27 15:44 ` Amavect
2023-11-26 22:36 ` ori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGOW0YMn1rRNAw=COHLYFvVFJwwOZLhr=5GcKuCRgs-=-2XO+A@mail.gmail.com' \
--to=amavect@gmail.com \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).