From: Blue-Maned_Hawk <bluemanedhawk@gmail.com>
To: 9front@9front.org
Subject: Re: [9front] [PATCH] Fix assert macro to not break on commas
Date: Sat, 25 Nov 2023 07:09:40 -0500 [thread overview]
Message-ID: <9636bf23-5c91-41bd-b9c4-98685cabf9c0@invalid.invalid> (raw)
In-Reply-To: <2BE1963ED309D739C71303706B8B520C@eigenstate.org>
On 11/24/23 23:34, ori@eigenstate.org wrote:
> Assert should largely behave like a function; the only reason
> it's a macro is for slightly better debug prints.
>
> We don't try to make functions take comma expressions in the
> argument lists either.
>
> sin(1,2); // also errors;
>
> If you really need a comma expression, you can parenthesize it,
> just like you would for a function call.
>
> assert((expr,list))
>
>
Ah, but see you now: there are situations which break for a macro
invocation, but not for a function call, such as the usage of a struct
literal, because the preprocessor doesn't tokenize in the same way as
the language itself. Consider the following obviously-contrived situation:
assert((struct Tm){.nsec = 0, .sec = 1}.sec);
next prev parent reply other threads:[~2023-11-25 12:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 23:11 Blue-Maned_Hawk
2023-11-23 4:20 ` Jacob Moody
2023-11-25 0:27 ` Blue-Maned_Hawk
2023-11-25 1:09 ` Jacob Moody
2023-11-25 4:34 ` ori
2023-11-25 12:09 ` Blue-Maned_Hawk [this message]
2023-11-25 18:46 ` Kurt H Maier
2023-11-25 20:06 ` Steve Simon
2023-11-25 20:39 ` Dan Cross
2023-11-25 22:47 ` Steve Simon
2023-11-26 2:22 ` Kurt H Maier
2023-11-26 17:31 ` Blue-Maned_Hawk
2023-11-26 18:13 ` ori
2023-11-26 22:39 ` Blue-Maned_Hawk
2023-11-26 22:52 ` ori
2023-11-26 23:30 ` Blue-Maned_Hawk
2023-11-27 0:00 ` ori
2023-11-27 11:20 ` Blue-Maned_Hawk
2023-11-27 15:38 ` ori
2023-11-27 15:59 ` Dan Cross
2023-11-27 22:21 ` Blue-Maned_Hawk
2023-11-27 23:59 ` ori
2023-11-28 0:30 ` Blue-Maned_Hawk
2023-11-28 0:34 ` ori
2023-11-29 9:14 ` Blue-Maned_Hawk
2023-11-26 19:58 ` Kurt H Maier
2023-11-26 22:37 ` Blue-Maned_Hawk
2023-11-25 4:49 ` ori
2023-11-26 18:59 ` Amavect
[not found] ` <7025e6e9-fca5-4648-aaea-a80260c35739@sirjofri.de>
2023-11-26 21:11 ` sirjofri
2023-11-26 22:41 ` Blue-Maned_Hawk
2023-11-27 15:44 ` Amavect
2023-11-26 22:36 ` ori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9636bf23-5c91-41bd-b9c4-98685cabf9c0@invalid.invalid \
--to=bluemanedhawk@gmail.com \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).