Re: [9front] [PATCH] Fix assert macro to not break on commas

[Jacob Moody <moody@posixcafe.org>]

On 11/24/23 18:27, Blue-Maned_Hawk wrote:
> On 11/22/23 23:20, Jacob Moody wrote:
>> On 11/22/23 17:11, Blue-Maned_Hawk wrote:
>>> This is a pair of patches that changes the assert macro to be variadic,
>>> allowing expressions with commas in them to be used without needing a
>>> spare pair of parentheses, and updates the manpage accordingly.
>>> \x1f
>>
>> For what reason does this need changed?
> 
> To avoid (admittedly, edge) cases where a comma in the expression being 
> asserted would be incorrectly interpretted as an attempt to invoke a 
> single-argument macro with two or more arguments.

This a problem that can be avoided by just using the interface correctly.

> 
>> Is there some code you're working with expecting this?
> 
> No.
> 
>> I am inclined to prefer to keep this as is.
> 
> Why?
> 

I am generally against increasing the complexity of our macros unless
there is a good enough usecase for it, which I have not been convinced of
here.