Gnus development mailing list
 help / color / mirror / Atom feed
* pgg passphrase caching
@ 2003-04-27 19:24 Jochen Küpper
  2003-04-27 20:36 ` Simon Josefsson
  2003-04-27 23:26 ` Michael Teichgräber
  0 siblings, 2 replies; 6+ messages in thread
From: Jochen Küpper @ 2003-04-27 19:24 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Just updated to cvs HEAD. Now pgg passphrase caching doesn't work any
more:( Used to work with OGnus-0.18. [1] (Using Emacs-21.2.1 on Cygwin).

,----[pgg settings]
| (setq pgg-cache-passphrase t
|       pgg-default-scheme 'gpg
|       pgg-default-user-id "CC1B0B4D"
|       pgg-passphrase-cache-expiry 1800
|       pgg-scheme 'gpg
|       )
`----

I don't see any significant change in lisp/pgg*.el in that timespan,
though.

Greetings,
Jochen

Footnotes: 
[1]  I have tested it with cvs o0-18 (works) and o0-19 (doesn't work).
-- 
Einigkeit und Recht und Freiheit                http://www.Jochen-Kuepper.de
    Liberté, Égalité, Fraternité                GnuPG key: CC1B0B4D
        Sex, drugs and rock-n-roll

[-- Attachment #2: Type: application/pgp-signature, Size: 185 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: pgg passphrase caching
  2003-04-27 19:24 pgg passphrase caching Jochen Küpper
@ 2003-04-27 20:36 ` Simon Josefsson
  2003-04-28 23:21   ` Jochen Küpper
  2003-04-27 23:26 ` Michael Teichgräber
  1 sibling, 1 reply; 6+ messages in thread
From: Simon Josefsson @ 2003-04-27 20:36 UTC (permalink / raw)
  Cc: ding

Jochen Küpper <jochen@jochen-kuepper.de> writes:

> Just updated to cvs HEAD. Now pgg passphrase caching doesn't work any
> more:( Used to work with OGnus-0.18. [1] (Using Emacs-21.2.1 on Cygwin).
...
> [1]  I have tested it with cvs o0-18 (works) and o0-19 (doesn't work).

Try a binary search of the dates between "cvs upd -D 2003-04-13" and
"cvs upd -D 2003-04-27" to spot which patch breaks it, this would help
alot.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: pgg passphrase caching
  2003-04-27 19:24 pgg passphrase caching Jochen Küpper
  2003-04-27 20:36 ` Simon Josefsson
@ 2003-04-27 23:26 ` Michael Teichgräber
  1 sibling, 0 replies; 6+ messages in thread
From: Michael Teichgräber @ 2003-04-27 23:26 UTC (permalink / raw)
  Cc: ding

[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]

Jochen Küpper <jochen@jochen-kuepper.de> writes:

> Just updated to cvs HEAD. Now pgg passphrase caching doesn't work any
> more:( Used to work with OGnus-0.18. [1] (Using Emacs-21.2.1 on Cygwin).

Does this happen on signing only, i.e. if you have entered your
passphrase to sign a mail, and on subsequent signings the cache turns
out not to work, or is decryption envolved too?

The first case, passphrase caching for subsequent signings, works for
me.

> [1]  I have tested it with cvs o0-18 (works) and o0-19 (doesn't work).

If it is passphrase caching for (mainly) decryption, that does not
work, did you verify this on the same message?

There still is the behaviour described in Message

  "pgg-decrypt-region: wrong key-ID displayed"
  <87he9ww7pt.fsf@iridium.renata.de>, news.gnus.org:gnus.gnus-bug

that has a side-effect on decrypting mails, which have the sender's
key ID -- not the receipient's -- in the first PGP packet: In this
case pgg-decrypt-region will ask the passphrase cache (that already
contains the passphrase with my secret key ID) for the wrong (the
sender's) key ID.

-- 
Michael

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: pgg passphrase caching
  2003-04-27 20:36 ` Simon Josefsson
@ 2003-04-28 23:21   ` Jochen Küpper
  2003-04-29  0:45     ` Simon Josefsson
  0 siblings, 1 reply; 6+ messages in thread
From: Jochen Küpper @ 2003-04-28 23:21 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

On Sun, 27 Apr 2003 22:36:27 +0200 Simon Josefsson wrote:

Simon> Jochen Küpper <jochen=W2i0oK7yYu0+t3nig+EZI7NAH6kLmebB@public.gmane.org> writes:

>> Just updated to cvs HEAD. Now pgg passphrase caching doesn't work any
>> more:( Used to work with OGnus-0.18. [1] (Using Emacs-21.2.1 on Cygwin).

Simon> to spot which patch breaks it, this would help alot.

The problem was introduced between cvs' -D 20030416 and 20030417.

The only change in lisp/pgg*.el was a (require 'cl) which isn't the
culprit.

On Mon, 28 Apr 2003 01:26:38 +0200 Michael Teichgräber wrote:

Michael> Does this happen on signing only, i.e. if you have entered
Michael> your passphrase to sign a mail, and on subsequent signings
Michael> the cache turns out not to work, or is decryption envolved
Michael> too?

I am only talking about signing here.

Greetings,
Jochen
-- 
Einigkeit und Recht und Freiheit                http://www.Jochen-Kuepper.de
    Liberté, Égalité, Fraternité                GnuPG key: CC1B0B4D
        Sex, drugs and rock-n-roll

[-- Attachment #2: Type: application/pgp-signature, Size: 185 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: pgg passphrase caching
  2003-04-28 23:21   ` Jochen Küpper
@ 2003-04-29  0:45     ` Simon Josefsson
  2003-04-29  7:50       ` Jochen Küpper
  0 siblings, 1 reply; 6+ messages in thread
From: Simon Josefsson @ 2003-04-29  0:45 UTC (permalink / raw)
  Cc: ding

Jochen Küpper <jochen@jochen-kuepper.de> writes:

> The problem was introduced between cvs' -D 20030416 and 20030417.

Thanks, it is the pgg-default-user-id addition to mml2015.el that
caused the problem:

(defun mml2015-pgg-sign (cont)
  (let ((pgg-errors-buffer mml2015-result-buffer)
	(boundary (funcall mml-boundary-function (incf mml-multipart-number)))
	(pgg-default-user-id (or (message-options-get 'message-sender)
				 pgg-default-user-id)))
...

The problem is that (message-options-get 'message-sender) always
return something, where we'd really only want it to return something
if the user specified a MML sender=0xfoobar tag.  Please upgrade to
HEAD to try the following patch.

2003-04-29  Simon Josefsson  <jas@extundo.com>

	* mml2015.el (mml2015-pgg-sign): Use mml-sender instead of
	message-sender.

	* mml.el (mml-generate-mime-1): Set mml-sender too.

--- mml.el.~6.74.~	Sun Apr 27 17:01:37 2003
+++ mml.el	Tue Apr 29 02:43:15 2003
@@ -541,7 +541,8 @@
 				 mml-encrypt-alist))
 	    sender recipients)
 	(when (or sign-item encrypt-item)
-	  (if (setq sender (cdr (assq 'sender cont)))
+	  (when (setq sender (cdr (assq 'sender cont)))
+	    (message-options-set 'mml-sender sender)
 	      (message-options-set 'message-sender sender))
 	  (if (setq recipients (cdr (assq 'recipients cont)))
 	      (message-options-set 'message-recipients recipients))
--- mml2015.el.~6.60.~	Wed Apr 16 21:19:32 2003
+++ mml2015.el	Tue Apr 29 02:43:28 2003
@@ -807,7 +807,7 @@
 (defun mml2015-pgg-sign (cont)
   (let ((pgg-errors-buffer mml2015-result-buffer)
 	(boundary (funcall mml-boundary-function (incf mml-multipart-number)))
-	(pgg-default-user-id (or (message-options-get 'message-sender)
+	(pgg-default-user-id (or (message-options-get 'mml-sender)
 				 pgg-default-user-id)))
     (unless (pgg-sign-region (point-min) (point-max))
       (pop-to-buffer mml2015-result-buffer)




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: pgg passphrase caching
  2003-04-29  0:45     ` Simon Josefsson
@ 2003-04-29  7:50       ` Jochen Küpper
  0 siblings, 0 replies; 6+ messages in thread
From: Jochen Küpper @ 2003-04-29  7:50 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

On Tue, 29 Apr 2003 02:45:43 +0200 Simon Josefsson wrote:

Simon> Jochen Küpper <jochen=W2i0oK7yYu0+t3nig+EZI7NAH6kLmebB@public.gmane.org> writes:

>> The problem was introduced between cvs' -D 20030416 and 20030417.

Simon> Please upgrade to HEAD to try the following patch.

Simon> * mml2015.el (mml2015-pgg-sign): Use mml-sender instead of
Simon> message-sender.

Simon> * mml.el (mml-generate-mime-1): Set mml-sender too.

Seems to work. Thanks!

Greetings,
Jochen
-- 
Einigkeit und Recht und Freiheit                http://www.Jochen-Kuepper.de
    Liberté, Égalité, Fraternité                GnuPG key: CC1B0B4D
        Sex, drugs and rock-n-roll

[-- Attachment #2: Type: application/pgp-signature, Size: 185 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2003-04-29  7:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-27 19:24 pgg passphrase caching Jochen Küpper
2003-04-27 20:36 ` Simon Josefsson
2003-04-28 23:21   ` Jochen Küpper
2003-04-29  0:45     ` Simon Josefsson
2003-04-29  7:50       ` Jochen Küpper
2003-04-27 23:26 ` Michael Teichgräber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).