Re: New "gnus-search" syntax and interface

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Adam Sjøgren <asjo@koldfront.dk> writes:

> Eric writes:
>
>> Past that, the fun stuff comes if you set
>> `gnus-search-use-parsed-queries' to t. That will enable the "generalized
>> query syntax", a single search syntax that can be used across any
>> supported search engine.
>
> I did that, placed point on nnml:normal and pressed G G as I usually do.
> Entered at string to search for at the Query: prompt, and instead of the
> expected results returned from notmuch, I got:
>
>   No search engine defined for nnml:
>   cl-no-applicable-method: No applicable method: gnus-search-run-search,
>   nil, "nnml:", ((parsed-query "Leaf") (query . "Leaf") (raw)),
>   ("nnml:normal")
>
> My mail method is defined like this:
>
>   (setq asjo-local-mail-method '(nnml ""
>                                       (nnir-search-engine notmuch)))
>
>     [...]
>
>   (setq gnus-secondary-select-methods
>         `(
>           ,asjo-local-mail-method
>       [...]
>
> (My archive method is also nnml - nnml:archive, and also has
> (nnir-search-engine notmuch).)
>
> I get the same error if I switch gnus-search-use-parsed-queries to nil.
>
> Do I need to tell Gnus that I want to use notmuch in a new way?

Apparently I borked the backward compatibility. The new way to define
the search engine (in your case) would be

(gnus-search-engine gnus-search-notmuch)

but old `nnir-search-engine' way should definitely be supported. Would
you please eval the below and confirm that it works correctly?

Thanks!

(defun gnus-search-server-to-engine (srv)
  (let* ((method (gnus-server-to-method srv))
	 (server
	  (or (assoc 'gnus-search-engine (cddr method))
	      (assoc (car method) gnus-search-default-engines)
	      (when-let ((old (assoc 'nnir-search-engine
				     (cddr method))))
		(nnheader-message
		 8 "\"nnir-search-engine\" is no longer a valid parameter")
		(pcase (nth 1 old)
		  ('notmuch 'gnus-search-notmuch)
		  ('namazu 'gnus-search-namazu)
		  ('find-grep 'gnus-search-find-grep)))))
	 (inst
	  (cond
	   ((null server) nil)
	   ((eieio-object-p (cadr server))
	    (cadr server))
	   ((class-p (cadr server))
	    (make-instance (cadr server)))
	   (t nil))))
    (if inst
	(when (cddr server)
	  (pcase-dolist (`(,key ,value) (cddr server))
	    (condition-case nil
		(setf (slot-value inst key) value)
	      ((invalid-slot-name invalid-slot-type)
	       (nnheader-message
		5 "Invalid search engine parameter: (%s %s)"
		key value)))))
      (nnheader-message 5 "No search engine defined for %s" srv))
    inst))