Re: new Mail-Followup-To patch...please take a look...

[prj@po.cwru.edu (Paul Jarc)]

Josh Huber <huber@alum.wpi.edu> wrote:
>  	 C-c C-f C-f  move to Followup-To
> +         C-c C-f C-m  move to Mail-Followup-To

Missed a M-x tabify, I guess.

> +      ;; Generate the Mail-Followup-To header if the header is not there...
> +      (if (and (or message-subscribed-regexps
> +		   message-subscribed-addresses
> +		   message-subscribed-address-functions)
> +	       (not (mail-fetch-field "mail-followup-to")))
> +	  (message-generate-headers
> +	   `(("Mail-Followup-To" . ,(message-make-mft))))
> +	;; otherwise, delete the MFT header if the field is empty
> +	(when (equal "" (mail-fetch-field "mail-followup-to"))
> +	  (message-remove-header "Mail-Followup-To")))
>        ;; Let the user do all of the above.
>        (run-hooks 'message-header-hook))

I had hoped that MFT would be enabled by default: existing
configurations would automatically get MFT when sending to any
to-address or to-list address.  (This would mean the 'subscribed
parameter would have to be replaced with a complementary
'not-subscribed parameter, among other things.)  But if that's not
going to be the case, then this chunk might as well be a hook
function.  It'll just be one extra line needed in .gnus to enable MFT.

> +(defun message-mft-helper (recipients regexps)
> +  `(or ,@(apply 'append

Might (cons 'or (apply ...)) be clearer?  See also below.

> +		(mapcar '(lambda (recipient)
> +			   (mapcar '(lambda (regexp)
> +				      (list 'string-match regexp recipient))
> +				   regexps))
> +			recipients))))

'(lambda ...) does not get byte-compiled.  (function (lambda ...))
does, and otherwise means the same thing.

> +    (when (eval (message-mft-helper recipients mft-regexps))
> +      msg-recipients)))

How about:
(save-match-data
  (when (eval (apply 'append '(or)
                     (mapcar
                      (function (lambda (regexp)
                                  (mapcar
                                   (function (lambda (recipient)
                                               `(string-match ,regexp
                                                              ,recipient)))
                                   recipients)))
                      mft-regexps)))
    msg-recipients))

This absorbs (the equivalent of) message-mft-helper into
message-make-mft, doesn't trample match-data, and might evaluate fewer
string-matches on average.  (It checks the first address against each
regexp, then the second address, ..., instead of checking the first
regexp against each address, ....  I'm guessing that when there is a
match, the first address is likely to match, and the first regexp is
not.)


paul