[Edbrowse-dev] my_ErrorReporter

[Edbrowse-dev] my_ErrorReporter

[Karl Dahlke]

Looks very much the same in Adam's latest as in mine.
A small change, just to be safe, make the last line

if(report) report->flags = 0;

This function uses JS-smprintf and JS_free,
and these are only used one other place in jsloc.c,
and I don't get why the sprintf call doesn't need the js context,
but the corresponding free call does.
That just makes me nervous.
No I don't think that's any of our bug problems so far,
but it's something we should address before a stable release.
And the funny thing is, JS_smprintf is almost pointless in the C++ world,
just concatenate the strings together and C++ will manage everything.
And in my_ErrorReporter we could even use cerr directly.
So might be we don't even need the silly function,
I'm just saying I don't quite understand it.

As you see from this, I finally cloned your code.
I plan to read through it first, then find / install moz 24,
then build and play.

Karl Dahlke

Re: [Edbrowse-dev] my_ErrorReporter

[Adam Thompson]

On Fri, Jan 24, 2014 at 07:13:20AM -0500, Karl Dahlke wrote:
> Looks very much the same in Adam's latest as in mine.
> A small change, just to be safe, make the last line
> 
> if(report) report->flags = 0;

I've removed the JS_smprintf usage from jsloc.cpp and jsdom.cpp.

> That just makes me nervous.
What made me nervous about this was we were relying on something which isn't
really publicly exposed in SpiderMonkey and they freely admit they change the
internals (and public api) with no thought for backward compatability and very 
little notice.

> No I don't think that's any of our bug problems so far,
> but it's something we should address before a stable release.

Agreed.

> And the funny thing is, JS_smprintf is almost pointless in the C++ world,
> just concatenate the strings together and C++ will manage everything.
> And in my_ErrorReporter we could even use cerr directly.
> So might be we don't even need the silly function,
> I'm just saying I don't quite understand it.

We don't, and it's gone as per my last set of commits.

> As you see from this, I finally cloned your code.
> I plan to read through it first, then find / install moz 24,
> then build and play.

Cool. I've just pushed the commits removing JS_smprintf and reformatting the
code using ebindent.

Cheers,
Adam.