From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] data-* attributes
Date: Fri, 24 Nov 2017 16:19:45 -0500 [thread overview]
Message-ID: <20171024161945.eklhad@comcast.net> (raw)
In-Reply-To: <alpine.LRH.2.03.1711220020230.20270@carhart.net>
[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]
I have addressed the problem uncovered by Kevin, wherein foo=bar in an html tag does not make it over to the js world.
Well it doesn't get there because I didn't implement it. Just didn't do it.
The only tricky part here is identifying all the exceptions.
Example <a style="style directives">
we have special code to manage this, creating a style object under the a object, then in that style object things like background=red and so on,
and if I then mindlessly set style to its string, as if it was foo=bar, then all that work is thrown away and it doesn't work.
Same comments for onclick = some javascript function, which actually compiles the function and puts that in under onclick, and you wouldn't want that thrown away and replaced with its string.
So there's a list of exception attributes that we manage specialy, and if not in this list, then I go ahead and set object.attribute=value.
The cookie set by oranges.com when you go somewhere else should now be correct, for whatever that's worth.
As always, we hope this makes a few other things work too.
Karl Dahlke
next prev parent reply other threads:[~2017-11-24 21:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 12:29 [Edbrowse-dev] Tidy error reporting Karl Dahlke
2017-11-22 8:43 ` [Edbrowse-dev] data-* attributes Kevin Carhart
2017-11-22 9:33 ` Kevin Carhart
2017-11-22 15:48 ` Karl Dahlke
2017-11-22 21:36 ` Kevin Carhart
2017-11-23 1:23 ` Kevin Carhart
2017-11-24 21:19 ` Karl Dahlke [this message]
2017-11-25 0:20 ` [Edbrowse-dev] data-* attributes / new work on RC Kevin Carhart
2017-11-25 0:56 ` Karl Dahlke
2017-11-25 1:15 ` Kevin Carhart
2017-11-25 1:22 ` Karl Dahlke
2017-11-25 1:44 ` Kevin Carhart
2017-11-25 2:28 ` Karl Dahlke
2017-11-25 3:10 ` Kevin Carhart
2017-11-25 5:02 ` Karl Dahlke
2017-11-25 5:35 ` Kevin Carhart
2017-11-26 13:14 ` Karl Dahlke
2017-11-27 1:03 ` Kevin Carhart
2017-11-27 1:48 ` Kevin Carhart
2017-11-27 2:58 ` Karl Dahlke
2017-11-27 3:37 ` Kevin Carhart
2017-11-26 22:43 ` Karl Dahlke
2017-11-27 3:19 ` Kevin Carhart
2017-11-27 4:23 ` Karl Dahlke
2017-11-27 4:51 ` Kevin Carhart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024161945.eklhad@comcast.net \
--to=eklhad@comcast.net \
--cc=Edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).