From: Kevin Carhart <kevin@carhart.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] data-* attributes / new work on RC
Date: Fri, 24 Nov 2017 17:15:02 -0800 (PST) [thread overview]
Message-ID: <alpine.LRH.2.03.1711241714290.5490@carhart.net> (raw)
In-Reply-To: <20171024195602.eklhad@comcast.net>
Yep, thank you for improving it, please fire away.
Kevin
On Fri, 24 Nov 2017, Karl Dahlke wrote:
> This is lovely!
> I applied your startwindow.js file and was going to push but I had to change something and wanted to check with you first.
> You have localStorage in eb$master but I don't think that works.
> I suspect each window has its own local storage.
> Furthermore, if one window could access the local storage of another window it is probably a security hole that some clever person could exploit for bad things.
> So I put it in the standard window, including localStorage.attributes = [] which you forgot but setAttribute() needs.
> If this seems right to you I'll push.
>
> Karl Dahlke
>
--------
Kevin Carhart * 415 225 5306 * The Ten Ninety Nihilists
next prev parent reply other threads:[~2017-11-25 1:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 12:29 [Edbrowse-dev] Tidy error reporting Karl Dahlke
2017-11-22 8:43 ` [Edbrowse-dev] data-* attributes Kevin Carhart
2017-11-22 9:33 ` Kevin Carhart
2017-11-22 15:48 ` Karl Dahlke
2017-11-22 21:36 ` Kevin Carhart
2017-11-23 1:23 ` Kevin Carhart
2017-11-24 21:19 ` Karl Dahlke
2017-11-25 0:20 ` [Edbrowse-dev] data-* attributes / new work on RC Kevin Carhart
2017-11-25 0:56 ` Karl Dahlke
2017-11-25 1:15 ` Kevin Carhart [this message]
2017-11-25 1:22 ` Karl Dahlke
2017-11-25 1:44 ` Kevin Carhart
2017-11-25 2:28 ` Karl Dahlke
2017-11-25 3:10 ` Kevin Carhart
2017-11-25 5:02 ` Karl Dahlke
2017-11-25 5:35 ` Kevin Carhart
2017-11-26 13:14 ` Karl Dahlke
2017-11-27 1:03 ` Kevin Carhart
2017-11-27 1:48 ` Kevin Carhart
2017-11-27 2:58 ` Karl Dahlke
2017-11-27 3:37 ` Kevin Carhart
2017-11-26 22:43 ` Karl Dahlke
2017-11-27 3:19 ` Kevin Carhart
2017-11-27 4:23 ` Karl Dahlke
2017-11-27 4:51 ` Kevin Carhart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.03.1711241714290.5490@carhart.net \
--to=kevin@carhart.net \
--cc=Edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).