* [musl-cross-make] [PATCH] litecross: Pass --enable-deterministic-archives to binutils, not gcc
@ 2018-11-06 6:36 Michael Forney
2019-02-10 19:27 ` Michael Forney
0 siblings, 1 reply; 3+ messages in thread
From: Michael Forney @ 2018-11-06 6:36 UTC (permalink / raw)
To: musl
When the gcc and binutils build trees were separated in defdbb4505,
--enable-deterministic-archives was accidentally left in FULL_GCC_CONFIG.
This had the effect of reverting commit e83fe4b8ce, breaking
reproducible builds (unless it was specified explicitly in config.mak).
---
litecross/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/litecross/Makefile b/litecross/Makefile
index 2f78157..4ecfa93 100644
--- a/litecross/Makefile
+++ b/litecross/Makefile
@@ -61,7 +61,8 @@ FULL_BINUTILS_CONFIG = \
--disable-werror \
--target=$(TARGET) --prefix= \
--libdir=/lib --disable-multilib \
- --with-sysroot=$(SYSROOT)
+ --with-sysroot=$(SYSROOT) \
+ --enable-deterministic-archives
FULL_GCC_CONFIG = --enable-languages=c,c++ \
$(GCC_CONFIG_FOR_TARGET) \
@@ -74,7 +75,6 @@ FULL_GCC_CONFIG = --enable-languages=c,c++ \
--disable-libmudflap --disable-libsanitizer \
--disable-gnu-indirect-function \
--disable-libmpx \
- --enable-deterministic-archives \
--enable-libstdcxx-time
FULL_MUSL_CONFIG = $(MUSL_CONFIG) \
--
2.19.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [musl-cross-make] [PATCH] litecross: Pass --enable-deterministic-archives to binutils, not gcc
2018-11-06 6:36 [musl-cross-make] [PATCH] litecross: Pass --enable-deterministic-archives to binutils, not gcc Michael Forney
@ 2019-02-10 19:27 ` Michael Forney
2019-02-11 23:30 ` Rich Felker
0 siblings, 1 reply; 3+ messages in thread
From: Michael Forney @ 2019-02-10 19:27 UTC (permalink / raw)
To: musl
On 2018-11-05, Michael Forney <mforney@mforney.org> wrote:
> When the gcc and binutils build trees were separated in defdbb4505,
> --enable-deterministic-archives was accidentally left in FULL_GCC_CONFIG.
> This had the effect of reverting commit e83fe4b8ce, breaking
> reproducible builds (unless it was specified explicitly in config.mak).
> ---
> litecross/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/litecross/Makefile b/litecross/Makefile
> index 2f78157..4ecfa93 100644
> --- a/litecross/Makefile
> +++ b/litecross/Makefile
> @@ -61,7 +61,8 @@ FULL_BINUTILS_CONFIG = \
> --disable-werror \
> --target=$(TARGET) --prefix= \
> --libdir=/lib --disable-multilib \
> - --with-sysroot=$(SYSROOT)
> + --with-sysroot=$(SYSROOT) \
> + --enable-deterministic-archives
>
> FULL_GCC_CONFIG = --enable-languages=c,c++ \
> $(GCC_CONFIG_FOR_TARGET) \
> @@ -74,7 +75,6 @@ FULL_GCC_CONFIG = --enable-languages=c,c++ \
> --disable-libmudflap --disable-libsanitizer \
> --disable-gnu-indirect-function \
> --disable-libmpx \
> - --enable-deterministic-archives \
> --enable-libstdcxx-time
>
> FULL_MUSL_CONFIG = $(MUSL_CONFIG) \
> --
> 2.19.1
Ping. I think this patch should be pretty uncontroversial. It is a
simple fix for a regression introduced in defdbb4505.
Would you prefer a github pull request instead?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: [musl-cross-make] [PATCH] litecross: Pass --enable-deterministic-archives to binutils, not gcc
2019-02-10 19:27 ` Michael Forney
@ 2019-02-11 23:30 ` Rich Felker
0 siblings, 0 replies; 3+ messages in thread
From: Rich Felker @ 2019-02-11 23:30 UTC (permalink / raw)
To: musl
On Sun, Feb 10, 2019 at 11:27:21AM -0800, Michael Forney wrote:
> On 2018-11-05, Michael Forney <mforney@mforney.org> wrote:
> > When the gcc and binutils build trees were separated in defdbb4505,
> > --enable-deterministic-archives was accidentally left in FULL_GCC_CONFIG.
> > This had the effect of reverting commit e83fe4b8ce, breaking
> > reproducible builds (unless it was specified explicitly in config.mak).
> > ---
> > litecross/Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/litecross/Makefile b/litecross/Makefile
> > index 2f78157..4ecfa93 100644
> > --- a/litecross/Makefile
> > +++ b/litecross/Makefile
> > @@ -61,7 +61,8 @@ FULL_BINUTILS_CONFIG = \
> > --disable-werror \
> > --target=$(TARGET) --prefix= \
> > --libdir=/lib --disable-multilib \
> > - --with-sysroot=$(SYSROOT)
> > + --with-sysroot=$(SYSROOT) \
> > + --enable-deterministic-archives
> >
> > FULL_GCC_CONFIG = --enable-languages=c,c++ \
> > $(GCC_CONFIG_FOR_TARGET) \
> > @@ -74,7 +75,6 @@ FULL_GCC_CONFIG = --enable-languages=c,c++ \
> > --disable-libmudflap --disable-libsanitizer \
> > --disable-gnu-indirect-function \
> > --disable-libmpx \
> > - --enable-deterministic-archives \
> > --enable-libstdcxx-time
> >
> > FULL_MUSL_CONFIG = $(MUSL_CONFIG) \
> > --
> > 2.19.1
>
> Ping. I think this patch should be pretty uncontroversial. It is a
> simple fix for a regression introduced in defdbb4505.
>
> Would you prefer a github pull request instead?
Sorry, it was just an oversight. Applying. Thanks!
Rich
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-11 23:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-06 6:36 [musl-cross-make] [PATCH] litecross: Pass --enable-deterministic-archives to binutils, not gcc Michael Forney
2019-02-10 19:27 ` Michael Forney
2019-02-11 23:30 ` Rich Felker
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).