* [PATCH] Fix unintended global symbols in atanl.c @ 2019-04-03 12:56 Dan Gohman 2019-04-03 13:49 ` Szabolcs Nagy 2019-04-03 14:16 ` Rich Felker 0 siblings, 2 replies; 4+ messages in thread From: Dan Gohman @ 2019-04-03 12:56 UTC (permalink / raw) To: musl [-- Attachment #1: Type: text/plain, Size: 1404 bytes --] Mark atanhi, atanlo, and aT in atanl.c as static, as they're not intended to be part of the public API. These are already static in the LDBL_MANT_DIG == 64 code, so this patch is just making the LDBL_MANT_DIG == 113 code do the same thing. --- src/math/atanl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/math/atanl.c b/src/math/atanl.c index 79a3edb8..c3b0c926 100644 --- a/src/math/atanl.c +++ b/src/math/atanl.c @@ -70,21 +70,21 @@ static long double T_odd(long double x) #elif LDBL_MANT_DIG == 113 #define EXPMAN(u) ((u.i.se & 0x7fff)<<8 | u.i.top>>8) -const long double atanhi[] = { +static const long double atanhi[] = { 4.63647609000806116214256231461214397e-01L, 7.85398163397448309615660845819875699e-01L, 9.82793723247329067985710611014666038e-01L, 1.57079632679489661923132169163975140e+00L, }; -const long double atanlo[] = { +static const long double atanlo[] = { 4.89509642257333492668618435220297706e-36L, 2.16795253253094525619926100651083806e-35L, -2.31288434538183565909319952098066272e-35L, 4.33590506506189051239852201302167613e-35L, }; -const long double aT[] = { +static const long double aT[] = { 3.33333333333333333333333333333333125e-01L, -1.99999999999999999999999999999180430e-01L, 1.42857142857142857142857142125269827e-01L, -- 2.17.1 [-- Attachment #2: Type: text/html, Size: 1706 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix unintended global symbols in atanl.c 2019-04-03 12:56 [PATCH] Fix unintended global symbols in atanl.c Dan Gohman @ 2019-04-03 13:49 ` Szabolcs Nagy 2019-04-03 14:16 ` Rich Felker 1 sibling, 0 replies; 4+ messages in thread From: Szabolcs Nagy @ 2019-04-03 13:49 UTC (permalink / raw) To: musl; +Cc: Dan Gohman * Dan Gohman <sunfish@mozilla.com> [2019-04-03 05:56:08 -0700]: > Mark atanhi, atanlo, and aT in atanl.c as static, as they're not intended > to be part of the public API. > > These are already static in the LDBL_MANT_DIG == 64 code, so this patch is > just making the LDBL_MANT_DIG == 113 code do the same thing. the patch looks ok thanks. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix unintended global symbols in atanl.c 2019-04-03 12:56 [PATCH] Fix unintended global symbols in atanl.c Dan Gohman 2019-04-03 13:49 ` Szabolcs Nagy @ 2019-04-03 14:16 ` Rich Felker 2019-04-03 19:29 ` Dan Gohman 1 sibling, 1 reply; 4+ messages in thread From: Rich Felker @ 2019-04-03 14:16 UTC (permalink / raw) To: musl On Wed, Apr 03, 2019 at 05:56:08AM -0700, Dan Gohman wrote: > Mark atanhi, atanlo, and aT in atanl.c as static, as they're not intended > to be part of the public API. > > These are already static in the LDBL_MANT_DIG == 64 code, so this patch is > just making the LDBL_MANT_DIG == 113 code do the same thing. > --- > src/math/atanl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/math/atanl.c b/src/math/atanl.c > index 79a3edb8..c3b0c926 100644 > --- a/src/math/atanl.c > +++ b/src/math/atanl.c > @@ -70,21 +70,21 @@ static long double T_odd(long double x) > #elif LDBL_MANT_DIG == 113 > #define EXPMAN(u) ((u.i.se & 0x7fff)<<8 | u.i.top>>8) > > -const long double atanhi[] = { > +static const long double atanhi[] = { > 4.63647609000806116214256231461214397e-01L, > 7.85398163397448309615660845819875699e-01L, > 9.82793723247329067985710611014666038e-01L, > 1.57079632679489661923132169163975140e+00L, > }; > > -const long double atanlo[] = { > +static const long double atanlo[] = { > 4.89509642257333492668618435220297706e-36L, > 2.16795253253094525619926100651083806e-35L, > -2.31288434538183565909319952098066272e-35L, > 4.33590506506189051239852201302167613e-35L, > }; > > -const long double aT[] = { > +static const long double aT[] = { > 3.33333333333333333333333333333333125e-01L, > -1.99999999999999999999999999999180430e-01L, > 1.42857142857142857142857142125269827e-01L, > -- > 2.17.1 Your email system appears to have corrupted the patch; it does not apply. Can you please resend as an attachment in the same git format-patch form? Rich ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix unintended global symbols in atanl.c 2019-04-03 14:16 ` Rich Felker @ 2019-04-03 19:29 ` Dan Gohman 0 siblings, 0 replies; 4+ messages in thread From: Dan Gohman @ 2019-04-03 19:29 UTC (permalink / raw) To: musl [-- Attachment #1.1: Type: text/plain, Size: 1914 bytes --] My apologies. Here is the patch as an attachment. Dan On Wed, Apr 3, 2019 at 7:16 AM Rich Felker <dalias@libc.org> wrote: > On Wed, Apr 03, 2019 at 05:56:08AM -0700, Dan Gohman wrote: > > Mark atanhi, atanlo, and aT in atanl.c as static, as they're not intended > > to be part of the public API. > > > > These are already static in the LDBL_MANT_DIG == 64 code, so this patch > is > > just making the LDBL_MANT_DIG == 113 code do the same thing. > > --- > > src/math/atanl.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/src/math/atanl.c b/src/math/atanl.c > > index 79a3edb8..c3b0c926 100644 > > --- a/src/math/atanl.c > > +++ b/src/math/atanl.c > > @@ -70,21 +70,21 @@ static long double T_odd(long double x) > > #elif LDBL_MANT_DIG == 113 > > #define EXPMAN(u) ((u.i.se & 0x7fff)<<8 | u.i.top>>8) > > > > -const long double atanhi[] = { > > +static const long double atanhi[] = { > > 4.63647609000806116214256231461214397e-01L, > > 7.85398163397448309615660845819875699e-01L, > > 9.82793723247329067985710611014666038e-01L, > > 1.57079632679489661923132169163975140e+00L, > > }; > > > > -const long double atanlo[] = { > > +static const long double atanlo[] = { > > 4.89509642257333492668618435220297706e-36L, > > 2.16795253253094525619926100651083806e-35L, > > -2.31288434538183565909319952098066272e-35L, > > 4.33590506506189051239852201302167613e-35L, > > }; > > > > -const long double aT[] = { > > +static const long double aT[] = { > > 3.33333333333333333333333333333333125e-01L, > > -1.99999999999999999999999999999180430e-01L, > > 1.42857142857142857142857142125269827e-01L, > > -- > > 2.17.1 > > Your email system appears to have corrupted the patch; it does not > apply. Can you please resend as an attachment in the same git > format-patch form? > > Rich > [-- Attachment #1.2: Type: text/html, Size: 2639 bytes --] [-- Attachment #2: 0001-Fix-unintended-global-symbols-in-atanl.c.patch --] [-- Type: text/x-patch, Size: 1549 bytes --] From ab4d50ef34df388236eda4594c524ccf24b9e18e Mon Sep 17 00:00:00 2001 From: Dan Gohman <sunfish@mozilla.com> Date: Wed, 3 Apr 2019 05:48:50 -0700 Subject: [PATCH] Fix unintended global symbols in atanl.c. Mark atanhi, atanlo, and aT in atanl.c as static, as they're not intended to be part of the public API. These are already static in the LDBL_MANT_DIG == 64 code, so this patch is just making the LDBL_MANT_DIG == 113 code do the same thing. --- src/math/atanl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/math/atanl.c b/src/math/atanl.c index 79a3edb8..c3b0c926 100644 --- a/src/math/atanl.c +++ b/src/math/atanl.c @@ -70,21 +70,21 @@ static long double T_odd(long double x) #elif LDBL_MANT_DIG == 113 #define EXPMAN(u) ((u.i.se & 0x7fff)<<8 | u.i.top>>8) -const long double atanhi[] = { +static const long double atanhi[] = { 4.63647609000806116214256231461214397e-01L, 7.85398163397448309615660845819875699e-01L, 9.82793723247329067985710611014666038e-01L, 1.57079632679489661923132169163975140e+00L, }; -const long double atanlo[] = { +static const long double atanlo[] = { 4.89509642257333492668618435220297706e-36L, 2.16795253253094525619926100651083806e-35L, -2.31288434538183565909319952098066272e-35L, 4.33590506506189051239852201302167613e-35L, }; -const long double aT[] = { +static const long double aT[] = { 3.33333333333333333333333333333333125e-01L, -1.99999999999999999999999999999180430e-01L, 1.42857142857142857142857142125269827e-01L, -- 2.17.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-03 19:29 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-04-03 12:56 [PATCH] Fix unintended global symbols in atanl.c Dan Gohman 2019-04-03 13:49 ` Szabolcs Nagy 2019-04-03 14:16 ` Rich Felker 2019-04-03 19:29 ` Dan Gohman
Code repositories for project(s) associated with this public inbox https://git.vuxu.org/mirror/musl/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).