Removing sys/sysmacros.h from sys/types.h

Removing sys/sysmacros.h from sys/types.h

[Benjamin Wright]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Hello,

Would it be possible to remove the sys/sysmacros.h include from sys/types.h?

This change was added in 2011 -
https://git.musl-libc.org/cgit/musl/commit/include/sys/types.h?id=f552c792c7ce5a560f214e1104d93ee5b0833967

However it appears to have been removed from other standard libc
implementations around ~2015 based on this announcement:
https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html

This can cause issues with user defined symbol collision of the symbols
major, minor or makedev.

Thanks,
Ben

[-- Attachment #2: Type: text/html, Size: 786 bytes --]

Re: Removing sys/sysmacros.h from sys/types.h

[Rich Felker]

On Fri, Jun 14, 2019 at 01:20:21PM -0700, Benjamin Wright wrote:
> Hello,
> 
> Would it be possible to remove the sys/sysmacros.h include from sys/types.h?
> 
> This change was added in 2011 -
> https://git.musl-libc.org/cgit/musl/commit/include/sys/types.h?id=f552c792c7ce5a560f214e1104d93ee5b0833967
> 
> However it appears to have been removed from other standard libc
> implementations around ~2015 based on this announcement:
> https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html
> 
> This can cause issues with user defined symbol collision of the symbols
> major, minor or makedev.

Yes, I'd actually forgotten we did this. I'll remove it right away in
time for the next release.

Rich

Re: Removing sys/sysmacros.h from sys/types.h

[Michael Forney]

On 2019-06-14, Rich Felker <dalias@libc.org> wrote:
> On Fri, Jun 14, 2019 at 01:20:21PM -0700, Benjamin Wright wrote:
>> Hello,
>>
>> Would it be possible to remove the sys/sysmacros.h include from
>> sys/types.h?
>>
>> This change was added in 2011 -
>> https://git.musl-libc.org/cgit/musl/commit/include/sys/types.h?id=f552c792c7ce5a560f214e1104d93ee5b0833967
>>
>> However it appears to have been removed from other standard libc
>> implementations around ~2015 based on this announcement:
>> https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html
>>
>> This can cause issues with user defined symbol collision of the symbols
>> major, minor or makedev.
>
> Yes, I'd actually forgotten we did this. I'll remove it right away in
> time for the next release.

I'm just curious if there is a good way to use these macros in
software that is otherwise portable without adding a configure script.
Most BSDs don't have sys/sysmacros.h, and now glibc and musl require
including sys/sysmacros.h to use them.

It's a shame that while these macros are available on most unix-like
operating systems, they can't be accessed in a generic way.

Re: Removing sys/sysmacros.h from sys/types.h

[Rich Felker]

On Sat, Jun 29, 2019 at 02:00:46PM -0700, Michael Forney wrote:
> On 2019-06-14, Rich Felker <dalias@libc.org> wrote:
> > On Fri, Jun 14, 2019 at 01:20:21PM -0700, Benjamin Wright wrote:
> >> Hello,
> >>
> >> Would it be possible to remove the sys/sysmacros.h include from
> >> sys/types.h?
> >>
> >> This change was added in 2011 -
> >> https://git.musl-libc.org/cgit/musl/commit/include/sys/types.h?id=f552c792c7ce5a560f214e1104d93ee5b0833967
> >>
> >> However it appears to have been removed from other standard libc
> >> implementations around ~2015 based on this announcement:
> >> https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html
> >>
> >> This can cause issues with user defined symbol collision of the symbols
> >> major, minor or makedev.
> >
> > Yes, I'd actually forgotten we did this. I'll remove it right away in
> > time for the next release.
> 
> I'm just curious if there is a good way to use these macros in
> software that is otherwise portable without adding a configure script.
> Most BSDs don't have sys/sysmacros.h, and now glibc and musl require
> including sys/sysmacros.h to use them.
> 
> It's a shame that while these macros are available on most unix-like
> operating systems, they can't be accessed in a generic way.

There's really not much of a use for them at all in portable software.
Devices having "major/minor numbers", rather than dev_t just being an
abstract identifier, is an anachronism that's not really compatible
with exploding numbers of device types or operating systems that don't
expose any idea of a type/major.

If you really do need them, you should probably just search for them
with a configure check, first for sys/sysmacros.h, then for any other
historical places they might have been found in.

Rich

Re: Removing sys/sysmacros.h from sys/types.h

[Michael Forney]

On 2019-06-29, Rich Felker <dalias@libc.org> wrote:
>> I'm just curious if there is a good way to use these macros in
>> software that is otherwise portable without adding a configure script.
>> Most BSDs don't have sys/sysmacros.h, and now glibc and musl require
>> including sys/sysmacros.h to use them.
>>
>> It's a shame that while these macros are available on most unix-like
>> operating systems, they can't be accessed in a generic way.
>
> There's really not much of a use for them at all in portable software.
> Devices having "major/minor numbers", rather than dev_t just being an
> abstract identifier, is an anachronism that's not really compatible
> with exploding numbers of device types or operating systems that don't
> expose any idea of a type/major.
>
> If you really do need them, you should probably just search for them
> with a configure check, first for sys/sysmacros.h, then for any other
> historical places they might have been found in.

The case I'm interested in is implementing ls(1), which needs a way to
display the dev_t in a human readable way, and tar(1) since the ustar
format stores devmajor and devminor separately.

But anyway, I guess adding a configure script is the only reliable way
to use them. I wonder if any of the BSDs would consider adding
sys/sysmacros.h...

Thanks for your input.