* [PR PATCH] nautilus-python: fix cross-build
@ 2020-12-25 4:03 ndowens
2020-12-26 0:05 ` [PR REVIEW] " sgn
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: ndowens @ 2020-12-25 4:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
There is a new pull request by ndowens against master on the void-packages repository
https://github.com/ndowens/void-packages nautilus-python
https://github.com/void-linux/void-packages/pull/27416
nautilus-python: fix cross-build
A patch file from https://github.com/void-linux/void-packages/pull/27416.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nautilus-python-27416.patch --]
[-- Type: text/x-diff, Size: 1693 bytes --]
From fe607a6dcc5edc4b5e31cde2b5d1ef3b961d2df5 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Thu, 24 Dec 2020 22:04:09 -0600
Subject: [PATCH] nautilus-python: fix cross-build
---
srcpkgs/nautilus-python/template | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/nautilus-python/template b/srcpkgs/nautilus-python/template
index d4d7d72122b..072aeedb20f 100644
--- a/srcpkgs/nautilus-python/template
+++ b/srcpkgs/nautilus-python/template
@@ -3,8 +3,11 @@ pkgname=nautilus-python
version=1.2.3
revision=3
build_style=gnu-configure
-configure_args="--enable-gtk-doc PYTHON=python3"
-hostmakedepends="automake libtool pkg-config which"
+configure_args="--enable-gtk-doc PYTHON=python3
+ am_cv_python_pythondir=${XBPS_CROSS_BASE}/${py3_lib}/site-packages
+ am_cv_python_pyexecdir=${XBPS_CROSS_BASE}/${py3_lib}/site-packages
+ PYTHON_INCLUDES=-I${XBPS_CROSS_BASE}/${py3_inc}"
+hostmakedepends="automake libtool pkg-config which python3"
makedepends="python3-devel python3-gobject-devel gtk-doc nautilus-devel"
depends="nautilus python3-gobject"
short_desc="Python bindings for the Nautilus extension framework"
@@ -13,6 +16,13 @@ license="GPL-2.0-or-later"
homepage="https://wiki.gnome.org/Projects/NautilusPython"
distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
checksum=073ce0297282259937ab473d189b97a04f42b97197c9292fc3bde9d135282098
-nocross="could not find Python headers"
CFLAGS="-fcommon"
+
+pre_build() {
+ # Needs itself to build HTML_DATA
+ # which fails to be found if cross-built
+ if [ "$CROSS_BUILD" ]; then
+ vsed -i '/DATA/s;$(HTML_DATA);;' docs/Makefile
+ fi
+}
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR REVIEW] nautilus-python: fix cross-build
2020-12-25 4:03 [PR PATCH] nautilus-python: fix cross-build ndowens
@ 2020-12-26 0:05 ` sgn
2020-12-26 0:06 ` sgn
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2020-12-26 0:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/27416#discussion_r548924294
Comment:
This part looks sketchy. `${XBPS_CROSS_BASE}`
I think I'll do this instead.
```diff
diff --git a/srcpkgs/nautilus-python/template b/srcpkgs/nautilus-python/template
index 072aeedb20..2aa4b0f9c6 100644
--- a/srcpkgs/nautilus-python/template
+++ b/srcpkgs/nautilus-python/template
@@ -4,9 +4,8 @@ version=1.2.3
revision=3
build_style=gnu-configure
configure_args="--enable-gtk-doc PYTHON=python3
- am_cv_python_pythondir=${XBPS_CROSS_BASE}/${py3_lib}/site-packages
- am_cv_python_pyexecdir=${XBPS_CROSS_BASE}/${py3_lib}/site-packages
- PYTHON_INCLUDES=-I${XBPS_CROSS_BASE}/${py3_inc}"
+ PYTHON_INCLUDES=-I${XBPS_CROSS_BASE}/${py3_inc}
+ PYTHON_LIBS=-lpython${py3_ver}"
hostmakedepends="automake libtool pkg-config which python3"
makedepends="python3-devel python3-gobject-devel gtk-doc nautilus-devel"
depends="nautilus python3-gobject"
```
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR REVIEW] nautilus-python: fix cross-build
2020-12-25 4:03 [PR PATCH] nautilus-python: fix cross-build ndowens
2020-12-26 0:05 ` [PR REVIEW] " sgn
@ 2020-12-26 0:06 ` sgn
2020-12-26 0:15 ` [PR PATCH] [Updated] " ndowens
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2020-12-26 0:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/27416#discussion_r548924350
Comment:
Maybe just disable gtkdoc?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Updated] nautilus-python: fix cross-build
2020-12-25 4:03 [PR PATCH] nautilus-python: fix cross-build ndowens
2020-12-26 0:05 ` [PR REVIEW] " sgn
2020-12-26 0:06 ` sgn
@ 2020-12-26 0:15 ` ndowens
2020-12-26 4:48 ` [PR REVIEW] " sgn
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ndowens @ 2020-12-26 0:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
There is an updated pull request by ndowens against master on the void-packages repository
https://github.com/ndowens/void-packages nautilus-python
https://github.com/void-linux/void-packages/pull/27416
nautilus-python: fix cross-build
A patch file from https://github.com/void-linux/void-packages/pull/27416.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nautilus-python-27416.patch --]
[-- Type: text/x-diff, Size: 1505 bytes --]
From 8a5c894fd5e2a0b352a0f66cd1758f56e81dfffe Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Thu, 24 Dec 2020 22:04:09 -0600
Subject: [PATCH] nautilus-python: fix cross-build
---
srcpkgs/nautilus-python/template | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/nautilus-python/template b/srcpkgs/nautilus-python/template
index d4d7d72122b..79f2427b08f 100644
--- a/srcpkgs/nautilus-python/template
+++ b/srcpkgs/nautilus-python/template
@@ -3,9 +3,11 @@ pkgname=nautilus-python
version=1.2.3
revision=3
build_style=gnu-configure
-configure_args="--enable-gtk-doc PYTHON=python3"
-hostmakedepends="automake libtool pkg-config which"
-makedepends="python3-devel python3-gobject-devel gtk-doc nautilus-devel"
+configure_args="--disable-gtk-doc PYTHON=python3
+ PYTHON_INCLUDES=-I${XBPS_CROSS_BASE}/${py3_inc}
+ PYTHON_LIBS=-lpython${py3_ver}"
+hostmakedepends="automake libtool pkg-config which python3"
+makedepends="python3-devel python3-gobject-devel nautilus-devel"
depends="nautilus python3-gobject"
short_desc="Python bindings for the Nautilus extension framework"
maintainer="Nafis <mnabid.25@outlook.com>"
@@ -13,6 +15,5 @@ license="GPL-2.0-or-later"
homepage="https://wiki.gnome.org/Projects/NautilusPython"
distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
checksum=073ce0297282259937ab473d189b97a04f42b97197c9292fc3bde9d135282098
-nocross="could not find Python headers"
CFLAGS="-fcommon"
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR REVIEW] nautilus-python: fix cross-build
2020-12-25 4:03 [PR PATCH] nautilus-python: fix cross-build ndowens
` (2 preceding siblings ...)
2020-12-26 0:15 ` [PR PATCH] [Updated] " ndowens
@ 2020-12-26 4:48 ` sgn
2020-12-26 9:38 ` mnabid
2020-12-27 4:28 ` [PR PATCH] [Closed]: " sgn
5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2020-12-26 4:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 280 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/27416#discussion_r548942955
Comment:
When the configure_args changed, please bump revision.
@mnabid Do you still want to have gtk-doc? Should we add a build_options instead?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: nautilus-python: fix cross-build
2020-12-25 4:03 [PR PATCH] nautilus-python: fix cross-build ndowens
` (3 preceding siblings ...)
2020-12-26 4:48 ` [PR REVIEW] " sgn
@ 2020-12-26 9:38 ` mnabid
2020-12-27 4:28 ` [PR PATCH] [Closed]: " sgn
5 siblings, 0 replies; 7+ messages in thread
From: mnabid @ 2020-12-26 9:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/27416#issuecomment-751339005
Comment:
probably add a build_options and disable it by default.
________________________________
From: Đoàn Trần Công Danh <notifications@github.com>
Sent: Saturday, December 26, 2020 10:48 AM
To: void-linux/void-packages <void-packages@noreply.github.com>
Cc: Nafis <mnabid.25@outlook.com>; Mention <mention@noreply.github.com>
Subject: Re: [void-linux/void-packages] nautilus-python: fix cross-build (#27416)
@sgn commented on this pull request.
________________________________
In srcpkgs/nautilus-python/template<https://github.com/void-linux/void-packages/pull/27416#discussion_r548942955>:
> @@ -3,16 +3,17 @@ pkgname=nautilus-python
version=1.2.3
revision=3
build_style=gnu-configure
-configure_args="--enable-gtk-doc PYTHON=python3"
-hostmakedepends="automake libtool pkg-config which"
-makedepends="python3-devel python3-gobject-devel gtk-doc nautilus-devel"
+configure_args="--disable-gtk-doc PYTHON=python3
When the configure_args changed, please bump revision.
@mnabid<https://github.com/mnabid> Do you still want to have gtk-doc? Should we add a build_options instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/void-linux/void-packages/pull/27416#pullrequestreview-558847069>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOZ5LGDX2S2ZRJJHP4A3QNLSWVTI3ANCNFSM4VIZGNBQ>.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Closed]: nautilus-python: fix cross-build
2020-12-25 4:03 [PR PATCH] nautilus-python: fix cross-build ndowens
` (4 preceding siblings ...)
2020-12-26 9:38 ` mnabid
@ 2020-12-27 4:28 ` sgn
5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2020-12-27 4:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
There's a closed pull request on the void-packages repository
nautilus-python: fix cross-build
https://github.com/void-linux/void-packages/pull/27416
Description:
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-12-27 4:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-25 4:03 [PR PATCH] nautilus-python: fix cross-build ndowens
2020-12-26 0:05 ` [PR REVIEW] " sgn
2020-12-26 0:06 ` sgn
2020-12-26 0:15 ` [PR PATCH] [Updated] " ndowens
2020-12-26 4:48 ` [PR REVIEW] " sgn
2020-12-26 9:38 ` mnabid
2020-12-27 4:28 ` [PR PATCH] [Closed]: " sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).