* Re: [PR REVIEW] newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
@ 2021-02-16 22:13 ` ericonr
2021-02-16 22:24 ` tibequadorian
` (17 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-02-16 22:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#discussion_r577175413
Comment:
Why do we force `/dev/shm` instead of good old `/tmp`?
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
2021-02-16 22:13 ` [PR REVIEW] " ericonr
@ 2021-02-16 22:24 ` tibequadorian
2021-02-16 22:35 ` ericonr
` (16 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: tibequadorian @ 2021-02-16 22:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New review comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#discussion_r577181356
Comment:
I took that from the old template but I don't mind removing it.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
2021-02-16 22:13 ` [PR REVIEW] " ericonr
2021-02-16 22:24 ` tibequadorian
@ 2021-02-16 22:35 ` ericonr
2021-02-16 22:36 ` [PR PATCH] [Updated] " tibequadorian
` (15 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-02-16 22:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#discussion_r577187461
Comment:
If it works without, I think that'd be best.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (2 preceding siblings ...)
2021-02-16 22:35 ` ericonr
@ 2021-02-16 22:36 ` tibequadorian
2021-02-17 14:49 ` ericonr
` (14 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: tibequadorian @ 2021-02-16 22:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]
There is an updated pull request by tibequadorian against master on the void-packages repository
https://github.com/tibequadorian/void-packages newsboat
https://github.com/void-linux/void-packages/pull/28801
newsboat: update to 2.22.1.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
Tests fail on CI because they're run as superuser. I ran them locally and it worked fine.
Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests.
closes #27902
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28801.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-28801.patch --]
[-- Type: text/x-diff, Size: 1489 bytes --]
From 63fcf79933b29dd47f024a7aefe76e5b6554f9c3 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 11 Jan 2021 12:08:45 +0100
Subject: [PATCH] newsboat: update to 2.22.1.
---
srcpkgs/newsboat/template | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e0ebdeeea50..e1a4429a62f 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,11 +1,12 @@
# Template file for 'newsboat'
pkgname=newsboat
-version=2.21
+version=2.22.1
revision=1
build_style=configure
build_helper="rust"
configure_script="./config.sh"
make_install_args="prefix=/usr"
+make_check_target="ci-check"
hostmakedepends="ruby-asciidoctor pkg-config cargo git gettext"
makedepends="json-c-devel libcurl-devel libxml2-devel sqlite-devel stfl-devel
rust-std"
@@ -16,11 +17,13 @@ license="MIT"
homepage="https://newsboat.org/"
changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
+checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
-do_check() {
- make test
- (cd test && TERM=$TERM TMPDIR=/dev/shm ./test)
+# tests fail when run by superuser
+make_check=extended
+
+post_patch() {
+ vsed -i Makefile -e "s|\./test|TERM=$TERM \./test|g"
}
post_install() {
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (3 preceding siblings ...)
2021-02-16 22:36 ` [PR PATCH] [Updated] " tibequadorian
@ 2021-02-17 14:49 ` ericonr
2021-02-17 19:46 ` Minoru
` (13 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-02-17 14:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#issuecomment-780607261
Comment:
Tests do run on glibc, but seem to fail on musl: https://gist.github.com/ericonr/74f59140ac7e26a0ac122888d4c22cb5
I'm running tests for the older version, and if it's also broken there I don't think it should be a blocker. Would you mind reporting this to upstream, though?
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (4 preceding siblings ...)
2021-02-17 14:49 ` ericonr
@ 2021-02-17 19:46 ` Minoru
2021-02-17 19:49 ` [PR REVIEW] " Minoru
` (12 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Minoru @ 2021-02-17 19:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
New comment by Minoru on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#issuecomment-780806866
Comment:
Hi, Newsboat maintainer here :wave: Tests on musl [have been broken since at least 2.21](https://github.com/newsboat/newsboat/issues/1216), and it looks like no-one affected is interested in looking into that, while I keep distracting myself with other stuff, so I don't think this should be a blocker to this package either.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (5 preceding siblings ...)
2021-02-17 19:46 ` Minoru
@ 2021-02-17 19:49 ` Minoru
2021-02-17 20:17 ` ericonr
` (11 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Minoru @ 2021-02-17 19:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
New review comment by Minoru on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#discussion_r577898470
Comment:
JFYI: I recommend `/dev/shm` in the README because tests create a lot of temporary files, and putting them onto a tmpfs (of which `/dev/shm` is a common instance) greatly speeds things up. If you're tight on RAM or don't need the extra speed, or if `/tmp` is already a tmpfs, using `/tmp` is fine.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (6 preceding siblings ...)
2021-02-17 19:49 ` [PR REVIEW] " Minoru
@ 2021-02-17 20:17 ` ericonr
2021-02-17 23:23 ` [PR PATCH] [Updated] " tibequadorian
` (10 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-02-17 20:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#issuecomment-780826083
Comment:
I prefer
```
diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e1a4429a62..7960b5d411 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -22,8 +22,8 @@ checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
# tests fail when run by superuser
make_check=extended
-post_patch() {
- vsed -i Makefile -e "s|\./test|TERM=$TERM \./test|g"
+pre_check() {
+ export TERM=xterm
}
post_install() {
```
instead of `vsed`. Also add a comment about the tests failing on musl with a link to the issue.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (7 preceding siblings ...)
2021-02-17 20:17 ` ericonr
@ 2021-02-17 23:23 ` tibequadorian
2021-02-17 23:29 ` tibequadorian
` (9 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: tibequadorian @ 2021-02-17 23:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]
There is an updated pull request by tibequadorian against master on the void-packages repository
https://github.com/tibequadorian/void-packages newsboat
https://github.com/void-linux/void-packages/pull/28801
newsboat: update to 2.22.1.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
Tests fail on CI because they're run as superuser. I ran them locally and it worked fine.
Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests.
closes #27902
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28801.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-28801.patch --]
[-- Type: text/x-diff, Size: 1536 bytes --]
From 2f13126c48d381e0d9e87c742473ef5010557094 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 11 Jan 2021 12:08:45 +0100
Subject: [PATCH] newsboat: update to 2.22.1.
---
srcpkgs/newsboat/template | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e0ebdeeea50..8bbf1edeb75 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,11 +1,12 @@
# Template file for 'newsboat'
pkgname=newsboat
-version=2.21
+version=2.22.1
revision=1
build_style=configure
build_helper="rust"
configure_script="./config.sh"
make_install_args="prefix=/usr"
+make_check_target="ci-check"
hostmakedepends="ruby-asciidoctor pkg-config cargo git gettext"
makedepends="json-c-devel libcurl-devel libxml2-devel sqlite-devel stfl-devel
rust-std"
@@ -16,11 +17,14 @@ license="MIT"
homepage="https://newsboat.org/"
changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
+checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
-do_check() {
- make test
- (cd test && TERM=$TERM TMPDIR=/dev/shm ./test)
+# tests fail when run by superuser
+# they always fail on musl, see https://github.com/newsboat/newsboat/issues/1216
+make_check=extended
+
+pre_check() {
+ export TERM=xterm
}
post_install() {
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (8 preceding siblings ...)
2021-02-17 23:23 ` [PR PATCH] [Updated] " tibequadorian
@ 2021-02-17 23:29 ` tibequadorian
2021-02-17 23:29 ` tibequadorian
` (8 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: tibequadorian @ 2021-02-17 23:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#issuecomment-780922399
Comment:
> export TERM=xterm
When using vsed it evaluates for me to TERM=dumb
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (9 preceding siblings ...)
2021-02-17 23:29 ` tibequadorian
@ 2021-02-17 23:29 ` tibequadorian
2021-02-18 1:06 ` ericonr
` (7 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: tibequadorian @ 2021-02-17 23:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 218 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#issuecomment-780922399
Comment:
> export TERM=xterm
When using vsed it evaluates for me to TERM=dumb
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (10 preceding siblings ...)
2021-02-17 23:29 ` tibequadorian
@ 2021-02-18 1:06 ` ericonr
2021-02-18 1:06 ` ericonr
` (6 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-02-18 1:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 256 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#issuecomment-780961013
Comment:
In that case dumb would have been fine :)
I didn't know there was a default, so xterm felt default enough to me.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (11 preceding siblings ...)
2021-02-18 1:06 ` ericonr
@ 2021-02-18 1:06 ` ericonr
2021-02-18 1:10 ` [PR PATCH] [Updated] " tibequadorian
` (5 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-02-18 1:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#issuecomment-780961013
Comment:
In that case dumb would have been fine :)
I didn't know there was a default, so xterm felt default enough to me.
Maybe `export TERM=$TERM` ?
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (12 preceding siblings ...)
2021-02-18 1:06 ` ericonr
@ 2021-02-18 1:10 ` tibequadorian
2021-02-18 1:10 ` tibequadorian
` (4 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: tibequadorian @ 2021-02-18 1:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]
There is an updated pull request by tibequadorian against master on the void-packages repository
https://github.com/tibequadorian/void-packages newsboat
https://github.com/void-linux/void-packages/pull/28801
newsboat: update to 2.22.1.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
Tests fail on CI because they're run as superuser. I ran them locally and it worked fine.
Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests.
closes #27902
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28801.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-28801.patch --]
[-- Type: text/x-diff, Size: 1535 bytes --]
From b2d39e0673c314427487ce6e943019d543b6d17c Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 11 Jan 2021 12:08:45 +0100
Subject: [PATCH] newsboat: update to 2.22.1.
---
srcpkgs/newsboat/template | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e0ebdeeea50..997c1f6f6a4 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,11 +1,12 @@
# Template file for 'newsboat'
pkgname=newsboat
-version=2.21
+version=2.22.1
revision=1
build_style=configure
build_helper="rust"
configure_script="./config.sh"
make_install_args="prefix=/usr"
+make_check_target="ci-check"
hostmakedepends="ruby-asciidoctor pkg-config cargo git gettext"
makedepends="json-c-devel libcurl-devel libxml2-devel sqlite-devel stfl-devel
rust-std"
@@ -16,11 +17,14 @@ license="MIT"
homepage="https://newsboat.org/"
changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
+checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
-do_check() {
- make test
- (cd test && TERM=$TERM TMPDIR=/dev/shm ./test)
+# tests fail when run by superuser
+# they always fail on musl, see https://github.com/newsboat/newsboat/issues/1216
+make_check=extended
+
+pre_check() {
+ export TERM=dumb
}
post_install() {
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (13 preceding siblings ...)
2021-02-18 1:10 ` [PR PATCH] [Updated] " tibequadorian
@ 2021-02-18 1:10 ` tibequadorian
2021-02-18 1:14 ` tibequadorian
` (3 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: tibequadorian @ 2021-02-18 1:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]
There is an updated pull request by tibequadorian against master on the void-packages repository
https://github.com/tibequadorian/void-packages newsboat
https://github.com/void-linux/void-packages/pull/28801
newsboat: update to 2.22.1.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
Tests fail on CI because they're run as superuser. I ran them locally and it worked fine.
Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests.
closes #27902
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28801.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-28801.patch --]
[-- Type: text/x-diff, Size: 1536 bytes --]
From 0e4498b47b32cfa9ca8aea86ef7b4c390f7f31ce Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 11 Jan 2021 12:08:45 +0100
Subject: [PATCH] newsboat: update to 2.22.1.
---
srcpkgs/newsboat/template | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e0ebdeeea50..689e74ecfbd 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,11 +1,12 @@
# Template file for 'newsboat'
pkgname=newsboat
-version=2.21
+version=2.22.1
revision=1
build_style=configure
build_helper="rust"
configure_script="./config.sh"
make_install_args="prefix=/usr"
+make_check_target="ci-check"
hostmakedepends="ruby-asciidoctor pkg-config cargo git gettext"
makedepends="json-c-devel libcurl-devel libxml2-devel sqlite-devel stfl-devel
rust-std"
@@ -16,11 +17,14 @@ license="MIT"
homepage="https://newsboat.org/"
changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
+checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
-do_check() {
- make test
- (cd test && TERM=$TERM TMPDIR=/dev/shm ./test)
+# tests fail when run by superuser
+# they always fail on musl, see https://github.com/newsboat/newsboat/issues/1216
+make_check=extended
+
+pre_check() {
+ export TERM=$TERM
}
post_install() {
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (14 preceding siblings ...)
2021-02-18 1:10 ` tibequadorian
@ 2021-02-18 1:14 ` tibequadorian
2021-02-18 1:16 ` tibequadorian
` (2 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: tibequadorian @ 2021-02-18 1:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#issuecomment-780965076
Comment:
> Maybe `export TERM=$TERM` ?
isnt that the same as `export TERM`?
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (15 preceding siblings ...)
2021-02-18 1:14 ` tibequadorian
@ 2021-02-18 1:16 ` tibequadorian
2021-02-18 1:17 ` tibequadorian
2021-02-18 2:51 ` [PR PATCH] [Merged]: " ericonr
18 siblings, 0 replies; 20+ messages in thread
From: tibequadorian @ 2021-02-18 1:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#issuecomment-780965076
Comment:
> Maybe `export TERM=$TERM` ?
isnt that the same as `export TERM`?
edit: apparently it isnt
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (16 preceding siblings ...)
2021-02-18 1:16 ` tibequadorian
@ 2021-02-18 1:17 ` tibequadorian
2021-02-18 2:51 ` [PR PATCH] [Merged]: " ericonr
18 siblings, 0 replies; 20+ messages in thread
From: tibequadorian @ 2021-02-18 1:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#issuecomment-780965076
Comment:
> Maybe `export TERM=$TERM` ?
isnt that the same as `export TERM`?
edit: apparently it isnt
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Merged]: newsboat: update to 2.22.1.
2021-02-16 22:09 [PR PATCH] newsboat: update to 2.22.1 tibequadorian
` (17 preceding siblings ...)
2021-02-18 1:17 ` tibequadorian
@ 2021-02-18 2:51 ` ericonr
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-02-18 2:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There's a merged pull request on the void-packages repository
newsboat: update to 2.22.1.
https://github.com/void-linux/void-packages/pull/28801
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
Tests fail on CI because they're run as superuser. I ran them locally and it worked fine.
Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests.
closes #27902
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 20+ messages in thread