[PR PATCH] newsboat: update to 2.22.1.

[PR PATCH] newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1789 bytes --]

There is a new pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages newsboat
https://github.com/void-linux/void-packages/pull/28801

newsboat: update to 2.22.1.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Tests fail on CI because they're run as superuser. I ran them locally and it worked fine.
Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests.

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28801.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-28801.patch --]
[-- Type: text/x-diff, Size: 1505 bytes --]

From bfaf78e1667ea4f5446b7905edaf40ec086636d4 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 11 Jan 2021 12:08:45 +0100
Subject: [PATCH] newsboat: update to 2.22.1.

---
 srcpkgs/newsboat/template | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e0ebdeeea50..930285d6e28 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,11 +1,12 @@
 # Template file for 'newsboat'
 pkgname=newsboat
-version=2.21
+version=2.22.1
 revision=1
 build_style=configure
 build_helper="rust"
 configure_script="./config.sh"
 make_install_args="prefix=/usr"
+make_check_target="ci-check"
 hostmakedepends="ruby-asciidoctor pkg-config cargo git gettext"
 makedepends="json-c-devel libcurl-devel libxml2-devel sqlite-devel stfl-devel
  rust-std"
@@ -16,11 +17,13 @@ license="MIT"
 homepage="https://newsboat.org/"
 changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
 distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
+checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
 
-do_check() {
-	make test
-	(cd test && TERM=$TERM TMPDIR=/dev/shm ./test)
+# tests fail when run by superuser
+make_check=extended
+
+post_patch() {
+	vsed -i Makefile -e "s|\./test|TERM=$TERM TMPDIR=/dev/shm \./test|g"
 }
 
 post_install() {

Re: [PR REVIEW] newsboat: update to 2.22.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#discussion_r577175413

Comment:
Why do we force `/dev/shm` instead of good old `/tmp`?

Re: [PR REVIEW] newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New review comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#discussion_r577181356

Comment:
I took that from the old template but I don't mind removing it.

Re: [PR REVIEW] newsboat: update to 2.22.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#discussion_r577187461

Comment:
If it works without, I think that'd be best.

Re: [PR PATCH] [Updated] newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages newsboat
https://github.com/void-linux/void-packages/pull/28801

newsboat: update to 2.22.1.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Tests fail on CI because they're run as superuser. I ran them locally and it worked fine.
Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests.

closes #27902

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28801.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-28801.patch --]
[-- Type: text/x-diff, Size: 1489 bytes --]

From 63fcf79933b29dd47f024a7aefe76e5b6554f9c3 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 11 Jan 2021 12:08:45 +0100
Subject: [PATCH] newsboat: update to 2.22.1.

---
 srcpkgs/newsboat/template | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e0ebdeeea50..e1a4429a62f 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,11 +1,12 @@
 # Template file for 'newsboat'
 pkgname=newsboat
-version=2.21
+version=2.22.1
 revision=1
 build_style=configure
 build_helper="rust"
 configure_script="./config.sh"
 make_install_args="prefix=/usr"
+make_check_target="ci-check"
 hostmakedepends="ruby-asciidoctor pkg-config cargo git gettext"
 makedepends="json-c-devel libcurl-devel libxml2-devel sqlite-devel stfl-devel
  rust-std"
@@ -16,11 +17,13 @@ license="MIT"
 homepage="https://newsboat.org/"
 changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
 distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
+checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
 
-do_check() {
-	make test
-	(cd test && TERM=$TERM TMPDIR=/dev/shm ./test)
+# tests fail when run by superuser
+make_check=extended
+
+post_patch() {
+	vsed -i Makefile -e "s|\./test|TERM=$TERM \./test|g"
 }
 
 post_install() {

Re: newsboat: update to 2.22.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#issuecomment-780607261

Comment:
Tests do run on glibc, but seem to fail on musl: https://gist.github.com/ericonr/74f59140ac7e26a0ac122888d4c22cb5

I'm running tests for the older version, and if it's also broken there I don't think it should be a blocker. Would you mind reporting this to upstream, though?

Re: newsboat: update to 2.22.1.

[Minoru]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

New comment by Minoru on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#issuecomment-780806866

Comment:
Hi, Newsboat maintainer here :wave: Tests on musl [have been broken since at least 2.21](https://github.com/newsboat/newsboat/issues/1216), and it looks like no-one affected is interested in looking into that, while I keep distracting myself with other stuff, so I don't think this should be a blocker to this package either.

Re: [PR REVIEW] newsboat: update to 2.22.1.

[Minoru]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

New review comment by Minoru on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#discussion_r577898470

Comment:
JFYI: I recommend `/dev/shm` in the README because tests create a lot of temporary files, and putting them onto a tmpfs (of which `/dev/shm` is a common instance) greatly speeds things up. If you're tight on RAM or don't need the extra speed, or if `/tmp` is already a tmpfs, using `/tmp` is fine.

Re: newsboat: update to 2.22.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 723 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#issuecomment-780826083

Comment:
I prefer 

```
diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e1a4429a62..7960b5d411 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -22,8 +22,8 @@ checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
 # tests fail when run by superuser
 make_check=extended
 
-post_patch() {
-	vsed -i Makefile -e "s|\./test|TERM=$TERM \./test|g"
+pre_check() {
+	export TERM=xterm
 }
 
 post_install() {
```

instead of `vsed`. Also add a comment about the tests failing on musl with a link to the issue.

Re: [PR PATCH] [Updated] newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages newsboat
https://github.com/void-linux/void-packages/pull/28801

newsboat: update to 2.22.1.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Tests fail on CI because they're run as superuser. I ran them locally and it worked fine.
Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests.

closes #27902

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28801.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-28801.patch --]
[-- Type: text/x-diff, Size: 1536 bytes --]

From 2f13126c48d381e0d9e87c742473ef5010557094 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 11 Jan 2021 12:08:45 +0100
Subject: [PATCH] newsboat: update to 2.22.1.

---
 srcpkgs/newsboat/template | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e0ebdeeea50..8bbf1edeb75 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,11 +1,12 @@
 # Template file for 'newsboat'
 pkgname=newsboat
-version=2.21
+version=2.22.1
 revision=1
 build_style=configure
 build_helper="rust"
 configure_script="./config.sh"
 make_install_args="prefix=/usr"
+make_check_target="ci-check"
 hostmakedepends="ruby-asciidoctor pkg-config cargo git gettext"
 makedepends="json-c-devel libcurl-devel libxml2-devel sqlite-devel stfl-devel
  rust-std"
@@ -16,11 +17,14 @@ license="MIT"
 homepage="https://newsboat.org/"
 changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
 distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
+checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
 
-do_check() {
-	make test
-	(cd test && TERM=$TERM TMPDIR=/dev/shm ./test)
+# tests fail when run by superuser
+# they always fail on musl, see https://github.com/newsboat/newsboat/issues/1216
+make_check=extended
+
+pre_check() {
+	export TERM=xterm
 }
 
 post_install() {

Re: newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#issuecomment-780922399

Comment:
> export TERM=xterm
When using vsed it evaluates for me to TERM=dumb

Re: newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#issuecomment-780922399

Comment:
> export TERM=xterm

When using vsed it evaluates for me to TERM=dumb

Re: newsboat: update to 2.22.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#issuecomment-780961013

Comment:
In that case dumb would have been fine :)

I didn't know there was a default, so xterm felt default enough to me.

Re: newsboat: update to 2.22.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#issuecomment-780961013

Comment:
In that case dumb would have been fine :)

I didn't know there was a default, so xterm felt default enough to me.

Maybe `export TERM=$TERM` ?

Re: [PR PATCH] [Updated] newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages newsboat
https://github.com/void-linux/void-packages/pull/28801

newsboat: update to 2.22.1.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Tests fail on CI because they're run as superuser. I ran them locally and it worked fine.
Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests.

closes #27902

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28801.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-28801.patch --]
[-- Type: text/x-diff, Size: 1535 bytes --]

From b2d39e0673c314427487ce6e943019d543b6d17c Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 11 Jan 2021 12:08:45 +0100
Subject: [PATCH] newsboat: update to 2.22.1.

---
 srcpkgs/newsboat/template | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e0ebdeeea50..997c1f6f6a4 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,11 +1,12 @@
 # Template file for 'newsboat'
 pkgname=newsboat
-version=2.21
+version=2.22.1
 revision=1
 build_style=configure
 build_helper="rust"
 configure_script="./config.sh"
 make_install_args="prefix=/usr"
+make_check_target="ci-check"
 hostmakedepends="ruby-asciidoctor pkg-config cargo git gettext"
 makedepends="json-c-devel libcurl-devel libxml2-devel sqlite-devel stfl-devel
  rust-std"
@@ -16,11 +17,14 @@ license="MIT"
 homepage="https://newsboat.org/"
 changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
 distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
+checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
 
-do_check() {
-	make test
-	(cd test && TERM=$TERM TMPDIR=/dev/shm ./test)
+# tests fail when run by superuser
+# they always fail on musl, see https://github.com/newsboat/newsboat/issues/1216
+make_check=extended
+
+pre_check() {
+	export TERM=dumb
 }
 
 post_install() {

Re: [PR PATCH] [Updated] newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages newsboat
https://github.com/void-linux/void-packages/pull/28801

newsboat: update to 2.22.1.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Tests fail on CI because they're run as superuser. I ran them locally and it worked fine.
Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests.

closes #27902

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28801.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-28801.patch --]
[-- Type: text/x-diff, Size: 1536 bytes --]

From 0e4498b47b32cfa9ca8aea86ef7b4c390f7f31ce Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 11 Jan 2021 12:08:45 +0100
Subject: [PATCH] newsboat: update to 2.22.1.

---
 srcpkgs/newsboat/template | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e0ebdeeea50..689e74ecfbd 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,11 +1,12 @@
 # Template file for 'newsboat'
 pkgname=newsboat
-version=2.21
+version=2.22.1
 revision=1
 build_style=configure
 build_helper="rust"
 configure_script="./config.sh"
 make_install_args="prefix=/usr"
+make_check_target="ci-check"
 hostmakedepends="ruby-asciidoctor pkg-config cargo git gettext"
 makedepends="json-c-devel libcurl-devel libxml2-devel sqlite-devel stfl-devel
  rust-std"
@@ -16,11 +17,14 @@ license="MIT"
 homepage="https://newsboat.org/"
 changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
 distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
+checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
 
-do_check() {
-	make test
-	(cd test && TERM=$TERM TMPDIR=/dev/shm ./test)
+# tests fail when run by superuser
+# they always fail on musl, see https://github.com/newsboat/newsboat/issues/1216
+make_check=extended
+
+pre_check() {
+	export TERM=$TERM
 }
 
 post_install() {

Re: newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#issuecomment-780965076

Comment:
> Maybe `export TERM=$TERM` ?

isnt that the same as `export TERM`?

Re: newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#issuecomment-780965076

Comment:
> Maybe `export TERM=$TERM` ?

isnt that the same as `export TERM`? 
edit: apparently it isnt

Re: newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/28801#issuecomment-780965076

Comment:
> Maybe `export TERM=$TERM` ?

isnt that the same as `export TERM`? 
edit: apparently it isnt

Re: [PR PATCH] [Merged]: newsboat: update to 2.22.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]

There's a merged pull request on the void-packages repository

newsboat: update to 2.22.1.
https://github.com/void-linux/void-packages/pull/28801

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Tests fail on CI because they're run as superuser. I ran them locally and it worked fine.
Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests.

closes #27902

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139

Comment:
> @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary?

On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown."
However parts of the `ci-check` target in the Makefile look quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch` and checks were indeed successful on my machine, but the CI still fails.

Re: newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139

Comment:
> @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary?

On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown."
However the `ci-check` target in the Makefile looks quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch` and checks were indeed successful on my machine, but the CI still fails.

Re: newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139

Comment:
> @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary?

On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown."
However the `ci-check` target in the Makefile looks quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch` and checks were indeed successful, but the CI still fails.

Re: newsboat: update to 2.22.1.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139

Comment:
> @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary?

On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown."
However the `ci-check` target in the Makefile looks quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch()` and checks were indeed successful, but the CI still fails.

Re: newsboat: update to 2.22.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-763236473

Comment:
@tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary?

Re: newsboat: update to 2.22.1.

[subsonik]

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

New comment by subsonik on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-759765730

Comment:
Thanks for the input @Minoru :)

I've ran the test suite on my machine using an x86_64 chroot and everything passed as an unprivileged user. The x86_64-musl tests fail, as previously noted, but I can confirm that the app itself is working fine on my machine (x86_64-musl).

I'm inexperienced with Void packaging/Travis, unfortunately, so I'm not sure if I can get the tests to run on Travis as an unprivileged user.

I think someone more knowledgeable will need to weigh in here, but in my opinion, besides the musl test failures and Travis running the test suite as a privileged user, this update is good to go. Maybe the test phase should be skipped?

Re: newsboat: update to 2.22.1.

[Minoru]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New comment by Minoru on void-packages repository

https://github.com/void-linux/void-packages/pull/27902#issuecomment-759750365

Comment:
Hi, Newsboat maintainer again :wave: Please see https://github.com/tibequadorian/void-packages/pull/5#issuecomment-758023098 and https://github.com/tibequadorian/void-packages/pull/5#issuecomment-758023098 (someone else was preparing a PR with an update, and I ended up commenting in their fork).