[PR PATCH] pounce: update to 2.5.

[PR PATCH] pounce: update to 2.5.

[ailiop-git]

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

There is a new pull request by ailiop-git against master on the void-packages repository

https://github.com/ailiop-git/void-packages pounce
https://github.com/void-linux/void-packages/pull/33110

pounce: update to 2.5.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33110.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pounce-33110.patch --]
[-- Type: text/x-diff, Size: 967 bytes --]

From 18956053daf5ba27b9fc39a4175943d16bda9363 Mon Sep 17 00:00:00 2001
From: Anthony Iliopoulos <ailiop@altatus.com>
Date: Sat, 25 Sep 2021 09:55:47 +0000
Subject: [PATCH] pounce: update to 2.5.

---
 srcpkgs/pounce/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/pounce/template b/srcpkgs/pounce/template
index 1419b7c21b95..0697f6ded4db 100644
--- a/srcpkgs/pounce/template
+++ b/srcpkgs/pounce/template
@@ -1,6 +1,6 @@
 # Template file for 'pounce'
 pkgname=pounce
-version=2.4
+version=2.5
 revision=1
 build_style=gnu-configure
 make_build_target="all"
@@ -12,4 +12,4 @@ maintainer="Michal Vasilek <michal@vasilek.cz>"
 license="GPL-3.0-or-later"
 homepage="https://git.causal.agency/pounce/"
 distfiles="https://git.causal.agency/pounce/snapshot/pounce-$version.tar.gz"
-checksum=0fe406700a80798eb669db90bef73cc4a644a29a2a36ea7178fed73623050a21
+checksum=c3f88f85ea6b3211d77b8193731704cb01871aee68762d2f6b5e9b102f83d0ad

Re: pounce: update to 2.5.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33110#issuecomment-927104294

Comment:
please check one of the checkboxes in the PR template in all your PRs

Re: pounce: update to 2.5.

[ailiop-git]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New comment by ailiop-git on void-packages repository

https://github.com/void-linux/void-packages/pull/33110#issuecomment-927104511

Comment:
> please check one of the checkboxes in the PR template in all your PRs

why?

Re: pounce: update to 2.5.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33110#issuecomment-927105203

Comment:
> > please check one of the checkboxes in the PR template in all your PRs
> 
> why?

The PR template exists for a reason, it helps people with reviewing your PRs.

Re: pounce: update to 2.5.

[ailiop-git]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

New comment by ailiop-git on void-packages repository

https://github.com/void-linux/void-packages/pull/33110#issuecomment-927105504

Comment:
> > > please check one of the checkboxes in the PR template in all your PRs
> > 
> > 
> > why?
> 
> The PR template exists for a reason, it helps people with reviewing your PRs.

You may assume I'm using to some extend any pkg I'm submitting, although I don't see how this helps reviewers at all.

Unless there's an automated way to check that, I'm not going to go through every submission and manually tick checkboxes.

Re: pounce: update to 2.5.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33110#issuecomment-927107276

Comment:
> You may assume I'm using to some extend any pkg I'm submitting

that's why we have two possible options:
* I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
* I generally don't use the affected packages but briefly tested this PR

> although I don't see how this helps reviewers at all.

Merging a PR isn't just about clicking a button, the person who merges the PR should make sure it will not break anything (by looking at it, trusting the knowledge of the PR author about the specific package, seeing if the checks succeed, testing it before merging, etc.). The checkboxes might in some cases help with that.

> Unless there's an automated way to check that, I'm not going to go through every submission and manually tick checkboxes.

There is no automated way to check this. Real people **manually** review your PRs, so refusing to do something as simple as clicking on a checkbox isn't nice.

Re: pounce: update to 2.5.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/33110#issuecomment-927107433

Comment:
If you want to see commits merged/reviewed properly put some effort into it.

From our point of view, all commits look like untested low effort version bumps that might or might not be tested on a whole lot of 1 system.

E.g. #32707 did break on x86_64-musl, you did never tried to fix it or ask someone to help with it.
Such PR's just make it look like you do not care about these updates.

Re: pounce: update to 2.5.

[ailiop-git]

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

New comment by ailiop-git on void-packages repository

https://github.com/void-linux/void-packages/pull/33110#issuecomment-927108964

Comment:
> From our point of view, all commits look like untested low effort version bumps that might or might not be tested on a whole lot of 1 system.

That sounds about right. I do not see how submitters ticking on any of those boxes helps in changing this assumption. Whether I use it regularly or I "lightly tested it", should not influence a reviewer's decision, and it is anyway a completely vague statement with no content.

The "this is a new package" checkbox is also rather useless, given that this is obvious from the diff.

> E.g. #32707 did break on x86_64-musl, you did never tried to fix it or ask someone to help with it.
> Such PR's just make it look like you do not care about these updates.

Sorry, but I simply do not have the bandwidth to deal with all test failures and all archs. That also goes on to show how irrelevant those checkboxes are, especially given that travis will anyway build all targets. What difference would it make to any reviewer if I stated that I've built this on x86_64? It's obvious from the travis results what works and what not.

Re: pounce: update to 2.5.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/33110#issuecomment-927110812

Comment:
If we didn't care about testing and some level of QA with updates, we could replace most of your contributions with a cronjob. There's a reason we don't do that.

If you don't "have the bandwidth" to address test failures or pay attention to PRs after you dump them in the queue, why are you contributing at all?

Re: pounce: update to 2.5.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 2579 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33110#issuecomment-927111547

Comment:
> > From our point of view, all commits look like untested low effort version bumps that might or might not be tested on a whole lot of 1 system.
> 
> That sounds about right. I do not see how submitters ticking on any of those boxes helps in changing this assumption. Whether I use it regularly or I "lightly tested it", should not influence a reviewer's decision, and it is anyway a completely vague statement with no content.

It is one of many metrics which go into reviewing and merging a PR. Sometimes it is valuable, so let's tick it, it's only one click.
 
> The "this is a new package" checkbox is also rather useless, given that this is obvious from the diff.

The purpose is to make people read the quality requirements if they missed them.

> > E.g. #32707 did break on x86_64-musl, you did never tried to fix it or ask someone to help with it.
> > Such PR's just make it look like you do not care about these updates.
> 
> Sorry, but I simply do not have the bandwidth to deal with all test failures and all archs. That also goes on to show how irrelevant those checkboxes are, especially given that travis will anyway build all targets. What difference would it make to any reviewer if I stated that I've built this on x86_64? It's obvious from the travis results what works and what not.

The "Does it build and run successfully?" section is commented out by default and makes sense to be filled only when CI is skipped.

> When skipping CI, uncomment and fill out the following section.

```
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

```

I agree that it's easy to miss and some people think they need to fill it in all PRs even when CI runs.

Re: pounce: update to 2.5.

[ailiop-git]

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

New comment by ailiop-git on void-packages repository

https://github.com/void-linux/void-packages/pull/33110#issuecomment-927112757

Comment:
> If we didn't care about testing and some level of QA with updates, we could replace most of your contributions with a cronjob. There's a reason we don't do that.

That's great, but you fail to explain how the checkboxes assist with "testing and some level of QA", or how this adds any confidence on top of travis. This is a very poor signal that bears no significance, and quite honestly it seems like a pointless exercise that is being imposed on contributors.

> If you don't "have the bandwidth" to address test failures or pay attention to PRs after you dump them in the queue, why are you contributing at all?

Because the majority of packages contributed aren't failing, and updates are needed. I'm using those packages and I like contributing so that other users can also receive updates in a timely fashion. I do not submit everything I update (e.g. i've been running on glibc-2.33 since March, but I'm aware of the complications and did not push it upstream).

In the end there are updates that would actually benefit from being done (or at least staged) through a crontab. For example #33102 is urgently needed by users due to multiple apache httpd CVEs. Similarly to other packages, unless I contribute, the package may not be updated for months (apparently their maintainers do not care to check the boxes either).

Still you seem to be more preoccupied and worried about checkboxes rather than how this actually affects users.

Re: pounce: update to 2.5.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/33110#issuecomment-927118466

Comment:
1. Answering questions and fixing tests bolsters confidence that you are willing to spend more than 3 seconds firing a shell script to do an update. (Many of your PRs receive no response to maintainers' comments about issues with your contributions.)
2. Addressing the questions shows at least a baseline level of commitment to adhere to some contributor standards. It also tells us whether the update is actively used by the contributor, which helps inspire confidence that obvious defects in the update are more likely to have been caught. You can tell us now that "I only update things I use extensively", but none of us keep a checklist where we can note for all time "@ailiop-git is OK, we know he regularly uses the packages he updates". Do us a favor and remind us, since we tend to go through hundreds or thousands of these PRs from hundreds of different people.

Both tests and PR responsiveness become more important if updates cause breakage and need urgent action. We are less concerned about running the latest version than we are about running versions that aren't fundamentally broken. Your historical inattentiveness to issues within your PRs as well as your now combative response and "CBA" attitude do not inspire confidence that you will be available to fix a broken update should the need arise.

Re: [PR PATCH] [Merged]: pounce: update to 2.5.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

There's a merged pull request on the void-packages repository

pounce: update to 2.5.
https://github.com/void-linux/void-packages/pull/33110

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->