* Re: [PR REVIEW] PolyMC: Update Java runtime dependencies
2022-08-13 12:11 [PR PATCH] PolyMC: Update Java runtime dependencies TrueTechie
@ 2022-08-13 12:17 ` JamiKettunen
2022-08-13 12:19 ` JamiKettunen
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: JamiKettunen @ 2022-08-13 12:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/38648#discussion_r945133209
Comment:
Why? `virtual?java-runtime` will accept any package that provides `java-runtime` virtual dependency, this includes both `openjdk17-jre` and the [current default of `openjdk8-jre`](https://github.com/void-linux/void-packages/blob/4475c34/etc/defaults.virtual#L25).
If you install `openjdk17-jre` you should be able to remove `openjdk8-jre`, or why not keep both. You could also install `openjdk17-jre` before `PolyMC` and then `openjdk8-jre` won't be pulled in.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] PolyMC: Update Java runtime dependencies
2022-08-13 12:11 [PR PATCH] PolyMC: Update Java runtime dependencies TrueTechie
2022-08-13 12:17 ` [PR REVIEW] " JamiKettunen
@ 2022-08-13 12:19 ` JamiKettunen
2022-08-13 12:27 ` JamiKettunen
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: JamiKettunen @ 2022-08-13 12:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/38648#discussion_r945133209
Comment:
Why? `virtual?java-runtime` will accept any package that provides `java-runtime` virtual dependency, this includes both `openjdk17-jre` and the [current distro-wide default of `openjdk8-jre`](https://github.com/void-linux/void-packages/blob/4475c34/etc/defaults.virtual#L25).
If you install `openjdk17-jre` you should be able to remove `openjdk8-jre`, or why not keep both. You could also install `openjdk17-jre` before `PolyMC` and then `openjdk8-jre` won't be pulled in.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] PolyMC: Update Java runtime dependencies
2022-08-13 12:11 [PR PATCH] PolyMC: Update Java runtime dependencies TrueTechie
2022-08-13 12:17 ` [PR REVIEW] " JamiKettunen
2022-08-13 12:19 ` JamiKettunen
@ 2022-08-13 12:27 ` JamiKettunen
2022-08-13 13:51 ` paper42
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: JamiKettunen @ 2022-08-13 12:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/38648#discussion_r945134060
Comment:
Ah nvm attempting to install `PolyMC` pulls in `openjdk11-jre` by default for me on `x86_64-musl`, wonder what exactly makes that the case... Either way this is a bit of a nuanced issue, perhaps @classabbyamp can comment better.
I previously suggested [mentioning the existance of PolyMC's README.voidlinux](https://github.com/void-linux/void-packages/pull/34979#issuecomment-1079054056) but it seems that was completely lost in the comments, but the file should already exist as [`/usr/share/doc/steam/README.voidlinux`](https://github.com/void-linux/void-packages/blob/master/srcpkgs/PolyMC/files/README.voidlinux) on your system.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: PolyMC: Update Java runtime dependencies
2022-08-13 12:11 [PR PATCH] PolyMC: Update Java runtime dependencies TrueTechie
` (2 preceding siblings ...)
2022-08-13 12:27 ` JamiKettunen
@ 2022-08-13 13:51 ` paper42
2022-08-13 14:31 ` [PR REVIEW] " JamiKettunen
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-08-13 13:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/38648#issuecomment-1214163235
Comment:
Different versions of minecraft require different versions of java. We don't want to require all of them, so I think we should keep using the virtual dependency that can be satisfied by jre 8, 11 or 17.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] PolyMC: Update Java runtime dependencies
2022-08-13 12:11 [PR PATCH] PolyMC: Update Java runtime dependencies TrueTechie
` (3 preceding siblings ...)
2022-08-13 13:51 ` paper42
@ 2022-08-13 14:31 ` JamiKettunen
2022-08-13 15:37 ` TrueTechie
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: JamiKettunen @ 2022-08-13 14:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/38648#discussion_r945134060
Comment:
Ah nvm attempting to install `PolyMC` pulls in `openjdk11-jre` by default for me on `x86_64-musl`, wonder what exactly makes that the case... Either way this is a bit of a nuanced issue, perhaps @classabbyamp can comment better.
I previously suggested [mentioning the existance of PolyMC's README.voidlinux](https://github.com/void-linux/void-packages/pull/34979#issuecomment-1079054056) but it seems that was completely lost in the comments, but the file should already exist as [`/usr/share/doc/PolyMC/README.voidlinux`](https://github.com/void-linux/void-packages/blob/master/srcpkgs/PolyMC/files/README.voidlinux) on your system.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] PolyMC: Update Java runtime dependencies
2022-08-13 12:11 [PR PATCH] PolyMC: Update Java runtime dependencies TrueTechie
` (4 preceding siblings ...)
2022-08-13 14:31 ` [PR REVIEW] " JamiKettunen
@ 2022-08-13 15:37 ` TrueTechie
2022-08-13 15:39 ` TrueTechie
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: TrueTechie @ 2022-08-13 15:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
New review comment by TrueTechie on void-packages repository
https://github.com/void-linux/void-packages/pull/38648#discussion_r945161017
Comment:
> Ah nvm attempting to install `PolyMC` pulls in `openjdk11-jre` by default for me on `x86_64-musl`, wonder what exactly makes that the case... Either way this is a bit of a nuanced issue, perhaps @classabbyamp can comment better.
>
> I previously suggested [mentioning the existance of PolyMC's README.voidlinux](https://github.com/void-linux/void-packages/pull/34979#issuecomment-1079054056) but it seems that was completely lost in the comments, but the file should already exist as [`/usr/share/doc/PolyMC/README.voidlinux`](https://github.com/void-linux/void-packages/blob/master/srcpkgs/PolyMC/files/README.voidlinux) on your system.
Fair, but README or not, this still means that the package wouldn't have accurate dependencies which puts into question the point of deps in the first place. Not to mention the extra work for new users who'll have to switch one version out for another.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: PolyMC: Update Java runtime dependencies
2022-08-13 12:11 [PR PATCH] PolyMC: Update Java runtime dependencies TrueTechie
` (5 preceding siblings ...)
2022-08-13 15:37 ` TrueTechie
@ 2022-08-13 15:39 ` TrueTechie
2022-08-13 16:48 ` classabbyamp
2022-08-13 16:55 ` [PR PATCH] [Closed]: " classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: TrueTechie @ 2022-08-13 15:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
New comment by TrueTechie on void-packages repository
https://github.com/void-linux/void-packages/pull/38648#issuecomment-1214178431
Comment:
> Different versions of minecraft require different versions of java. We don't want to require all of them, so I think we should keep using the virtual dependency that can be satisfied by jre 8, 11 or 17.
Fair, but having specifically the up-to-date version of the game that most people want to play be the one that doesn't work. If it's a later version of Java by default, less players have to go out of their way to change it manually.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: PolyMC: Update Java runtime dependencies
2022-08-13 12:11 [PR PATCH] PolyMC: Update Java runtime dependencies TrueTechie
` (6 preceding siblings ...)
2022-08-13 15:39 ` TrueTechie
@ 2022-08-13 16:48 ` classabbyamp
2022-08-13 16:55 ` [PR PATCH] [Closed]: " classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-08-13 16:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/38648#issuecomment-1214188332
Comment:
Void policy is to only include the *absolutely required* software in dependencies, not optional software. PolyMC can work with any of the three openjdk runtimes we currently package, so that requirement is put in the depends.
PolyMC provides a nice, clear error message if it doesn't have the correct jdk *and* README.voidlinux (which is [the standard way](https://docs.voidlinux.org/config/package-documentation/index.html) to let users know about void-specific documentation with a package) says the same thing.
Forcing the dependency to `openjdk17-jre` would cause errors if a user only wanted to have other versions of openjdk on their system:
```
xbps-install PolyMC
...
xbps-remove openjdk17-jre
openjdk17-jre-17.0.3+7_1 in transaction breaks installed pkg `PolyMC-1.4.1_2'
```
This is not good.
`virtual?openjdk-runtime` is the correct dependency for PolyMC.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Closed]: PolyMC: Update Java runtime dependencies
2022-08-13 12:11 [PR PATCH] PolyMC: Update Java runtime dependencies TrueTechie
` (7 preceding siblings ...)
2022-08-13 16:48 ` classabbyamp
@ 2022-08-13 16:55 ` classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-08-13 16:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
There's a closed pull request on the void-packages repository
PolyMC: Update Java runtime dependencies
https://github.com/void-linux/void-packages/pull/38648
Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64_glibc
Fixes #38645
^ permalink raw reply [flat|nested] 10+ messages in thread