[PR PATCH] PolyMC: Update Java runtime dependencies

[PR PATCH] PolyMC: Update Java runtime dependencies

[TrueTechie]

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

There is a new pull request by TrueTechie against master on the void-packages repository

https://github.com/TrueTechie/void-packages master
https://github.com/void-linux/void-packages/pull/38648

PolyMC: Update Java runtime dependencies
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64_glibc)

Fixes #38645


A patch file from https://github.com/void-linux/void-packages/pull/38648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-38648.patch --]
[-- Type: text/x-diff, Size: 1090 bytes --]

From 0c3d7682458be11b90ad5b92c0aca240863b47d1 Mon Sep 17 00:00:00 2001
From: TrueTechie <TrueTechie@mailo.com>
Date: Sat, 13 Aug 2022 07:48:52 -0400
Subject: [PATCH] PolyMC: Update Java runtime dependencies

---
 srcpkgs/PolyMC/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/PolyMC/template b/srcpkgs/PolyMC/template
index fd8da7afb88a..f41defae6d89 100644
--- a/srcpkgs/PolyMC/template
+++ b/srcpkgs/PolyMC/template
@@ -1,14 +1,14 @@
 # Template file for 'PolyMC'
 pkgname=PolyMC
 version=1.4.1
-revision=1
+revision=2
 build_style=cmake
 configure_args="-DLauncher_BUILD_PLATFORM=Void
  -DLauncher_VERSION_BUILD=${revision}"
-hostmakedepends="extra-cmake-modules openjdk8 pkg-config qt5-host-tools
+hostmakedepends="extra-cmake-modules openjdk17 pkg-config qt5-host-tools
  qt5-qmake scdoc"
 makedepends="qt5-devel"
-depends="virtual?java-runtime qt5-svg qt5-imageformats xrandr"
+depends="openjdk17-jre qt5-svg qt5-imageformats xrandr"
 short_desc="Custom launcher for Minecraft"
 maintainer="Philipp David <pd@3b.pm>"
 license="GPL-3.0-only"

Re: [PR REVIEW] PolyMC: Update Java runtime dependencies

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/38648#discussion_r945133209

Comment:
Why? `virtual?java-runtime` will accept any package that provides `java-runtime` virtual dependency, this includes both `openjdk17-jre` and the [current default of `openjdk8-jre`](https://github.com/void-linux/void-packages/blob/4475c34/etc/defaults.virtual#L25).

If you install `openjdk17-jre` you should be able to remove `openjdk8-jre`, or why not keep both. You could also install `openjdk17-jre` before `PolyMC` and then `openjdk8-jre` won't be pulled in.

Re: [PR REVIEW] PolyMC: Update Java runtime dependencies

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/38648#discussion_r945133209

Comment:
Why? `virtual?java-runtime` will accept any package that provides `java-runtime` virtual dependency, this includes both `openjdk17-jre` and the [current distro-wide default of `openjdk8-jre`](https://github.com/void-linux/void-packages/blob/4475c34/etc/defaults.virtual#L25).

If you install `openjdk17-jre` you should be able to remove `openjdk8-jre`, or why not keep both. You could also install `openjdk17-jre` before `PolyMC` and then `openjdk8-jre` won't be pulled in.

Re: [PR REVIEW] PolyMC: Update Java runtime dependencies

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/38648#discussion_r945134060

Comment:
Ah nvm attempting to install `PolyMC` pulls in `openjdk11-jre` by default for me on `x86_64-musl`, wonder what exactly makes that the case... Either way this is a bit of a nuanced issue, perhaps @classabbyamp can comment better.

I previously suggested [mentioning the existance of PolyMC's README.voidlinux](https://github.com/void-linux/void-packages/pull/34979#issuecomment-1079054056) but it seems that was completely lost in the comments, but the file should already exist as [`/usr/share/doc/steam/README.voidlinux`](https://github.com/void-linux/void-packages/blob/master/srcpkgs/PolyMC/files/README.voidlinux) on your system.

Re: PolyMC: Update Java runtime dependencies

[paper42]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38648#issuecomment-1214163235

Comment:
Different versions of minecraft require different versions of java. We don't want to require all of them, so I think we should keep using the virtual dependency that can be satisfied by jre 8, 11 or 17.

Re: [PR REVIEW] PolyMC: Update Java runtime dependencies

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 788 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/38648#discussion_r945134060

Comment:
Ah nvm attempting to install `PolyMC` pulls in `openjdk11-jre` by default for me on `x86_64-musl`, wonder what exactly makes that the case... Either way this is a bit of a nuanced issue, perhaps @classabbyamp can comment better.

I previously suggested [mentioning the existance of PolyMC's README.voidlinux](https://github.com/void-linux/void-packages/pull/34979#issuecomment-1079054056) but it seems that was completely lost in the comments, but the file should already exist as [`/usr/share/doc/PolyMC/README.voidlinux`](https://github.com/void-linux/void-packages/blob/master/srcpkgs/PolyMC/files/README.voidlinux) on your system.

Re: [PR REVIEW] PolyMC: Update Java runtime dependencies

[TrueTechie]

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

New review comment by TrueTechie on void-packages repository

https://github.com/void-linux/void-packages/pull/38648#discussion_r945161017

Comment:
> Ah nvm attempting to install `PolyMC` pulls in `openjdk11-jre` by default for me on `x86_64-musl`, wonder what exactly makes that the case... Either way this is a bit of a nuanced issue, perhaps @classabbyamp can comment better.
> 
> I previously suggested [mentioning the existance of PolyMC's README.voidlinux](https://github.com/void-linux/void-packages/pull/34979#issuecomment-1079054056) but it seems that was completely lost in the comments, but the file should already exist as [`/usr/share/doc/PolyMC/README.voidlinux`](https://github.com/void-linux/void-packages/blob/master/srcpkgs/PolyMC/files/README.voidlinux) on your system.

Fair, but README or not, this still means that the package wouldn't have accurate dependencies which puts into question the point of deps in the first place. Not to mention the extra work for new users who'll have to switch one version out for another.

Re: PolyMC: Update Java runtime dependencies

[TrueTechie]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

New comment by TrueTechie on void-packages repository

https://github.com/void-linux/void-packages/pull/38648#issuecomment-1214178431

Comment:
> Different versions of minecraft require different versions of java. We don't want to require all of them, so I think we should keep using the virtual dependency that can be satisfied by jre 8, 11 or 17.

Fair, but having specifically the up-to-date version of the game that most people want to play be the one that doesn't work. If it's a later version of Java by default, less players have to go out of their way to change it manually.

Re: PolyMC: Update Java runtime dependencies

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38648#issuecomment-1214188332

Comment:
Void policy is to only include the *absolutely required* software in dependencies, not optional software. PolyMC can work with any of the three openjdk runtimes we currently package, so that requirement is put in the depends.

PolyMC provides a nice, clear error message if it doesn't have the correct jdk *and* README.voidlinux (which is [the standard way](https://docs.voidlinux.org/config/package-documentation/index.html) to let users know about void-specific documentation with a package) says the same thing.

Forcing the dependency to `openjdk17-jre` would cause errors if a user only wanted to have other versions of openjdk on their system:
```
xbps-install PolyMC
...
xbps-remove openjdk17-jre
openjdk17-jre-17.0.3+7_1 in transaction breaks installed pkg `PolyMC-1.4.1_2'
```
This is not good.

`virtual?openjdk-runtime` is the correct dependency for PolyMC.

Re: [PR PATCH] [Closed]: PolyMC: Update Java runtime dependencies

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

There's a closed pull request on the void-packages repository

PolyMC: Update Java runtime dependencies
https://github.com/void-linux/void-packages/pull/38648

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64_glibc

Fixes #38645