* Re: [PR PATCH] [Updated] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
@ 2022-11-17 10:48 ` icp1994
2022-11-17 11:02 ` [PR REVIEW] " paper42
` (23 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: icp1994 @ 2022-11-17 10:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
There is an updated pull request by icp1994 against master on the void-packages repository
https://github.com/icp1994/void-packages pydepfix
https://github.com/void-linux/void-packages/pull/40569
srcpkgs: add missing python3 dependency in python3 packages
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/40569.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pydepfix-40569.patch --]
[-- Type: text/x-diff, Size: 16590 bytes --]
From b4f1bb6fce8729e44c8d17a93c901bb013b1b057 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:27:29 +0530
Subject: [PATCH 01/17] libvirt-python3: add python3 as dep
---
srcpkgs/libvirt-python3/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/libvirt-python3/template b/srcpkgs/libvirt-python3/template
index bc94c71d6a389..6885784f177f1 100644
--- a/srcpkgs/libvirt-python3/template
+++ b/srcpkgs/libvirt-python3/template
@@ -1,11 +1,12 @@
# Template file for 'libvirt-python3'
pkgname=libvirt-python3
version=8.9.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="pkg-config python3-devel python3-setuptools libvirt-devel
libapparmor-devel"
makedepends="libvirt-devel python3-devel"
+depends="python3"
checkdepends="python3-pytest python3-lxml python3-nose"
short_desc="Libvirt virtualization API Python3 binding"
maintainer="Helmut Pozimski <helmut@pozimski.eu>"
From 866bdefed8b006b85945f62740e235bf40074500 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:30:05 +0530
Subject: [PATCH 02/17] ps_mem: add python3 as dep
---
srcpkgs/ps_mem/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/ps_mem/template b/srcpkgs/ps_mem/template
index 35698523d95e2..bc97b0d92a9bd 100644
--- a/srcpkgs/ps_mem/template
+++ b/srcpkgs/ps_mem/template
@@ -1,9 +1,10 @@
# Template file for 'ps_mem'
pkgname=ps_mem
version=3.14
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
+depends="python3"
short_desc="Utility to accurately report the core memory usage for a program"
maintainer="wael <40663@proton.me>"
license="LGPL-2.1-only"
From e4dc98bfff36aab271b25ba14879ad9c59bd84ae Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:36:43 +0530
Subject: [PATCH 03/17] python3-cvxopt: add python3 as dep
---
srcpkgs/python3-cvxopt/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-cvxopt/template b/srcpkgs/python3-cvxopt/template
index 4044fbfea2a77..770533353df89 100644
--- a/srcpkgs/python3-cvxopt/template
+++ b/srcpkgs/python3-cvxopt/template
@@ -1,11 +1,12 @@
# Template file for 'python3-cvxopt'
pkgname=python3-cvxopt
version=1.3.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
makedepends="python3-devel blas-devel lapack-devel SuiteSparse-devel gsl-devel
glpk-devel fftw-devel"
+depends="python3"
checkdepends="python3-pytest"
short_desc="Python software for convex optimization"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
From d7394b99fecf9095ce5623061d552a8dbe7efd00 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:40:27 +0530
Subject: [PATCH 04/17] python3-cysignals: add python3 as dep
---
srcpkgs/python3-cysignals/template | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/python3-cysignals/template b/srcpkgs/python3-cysignals/template
index 52396d21b0997..bd9563353ba07 100644
--- a/srcpkgs/python3-cysignals/template
+++ b/srcpkgs/python3-cysignals/template
@@ -1,11 +1,12 @@
# Template file for 'python3-cysignals'
pkgname=python3-cysignals
version=1.11.2
-revision=3
+revision=4
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython autoconf"
makedepends="python3-devel pari-devel"
-short_desc="Interrupt and signal handling for Cython "
+depends="python3"
+short_desc="Interrupt and signal handling for Cython"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="LGPL-3.0-or-later"
homepage="https://github.com/sagemath/cysignals"
From c871ebca3d25e2413e4067bf1b44697531f2e869 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:42:42 +0530
Subject: [PATCH 05/17] python3-docstring-to-markdown: add python3 as dep
---
srcpkgs/python3-docstring-to-markdown/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-docstring-to-markdown/template b/srcpkgs/python3-docstring-to-markdown/template
index 3b35f6bf7bfb1..1fb42cafc3c51 100644
--- a/srcpkgs/python3-docstring-to-markdown/template
+++ b/srcpkgs/python3-docstring-to-markdown/template
@@ -1,9 +1,10 @@
# Template file for 'python3-docstring-to-markdown'
pkgname=python3-docstring-to-markdown
version=0.10
-revision=1
+revision=2
build_style=python3-module
hostmakedepends="python3-setuptools_scm"
+depends="python3"
short_desc="Python implementation of the Language Server Protocol"
maintainer="Cameron Nemo <cam@nohom.org>"
license="LGPL-2.1-only"
From 01f0752416996d9268524760558731cf12857e7a Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:10:08 +0530
Subject: [PATCH 06/17] python3-evdev: add python3 as dep, fix tests
---
srcpkgs/python3-evdev/template | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-evdev/template b/srcpkgs/python3-evdev/template
index 87cbf84776153..105bba7e3c742 100644
--- a/srcpkgs/python3-evdev/template
+++ b/srcpkgs/python3-evdev/template
@@ -1,10 +1,12 @@
# Template file for 'python3-evdev'
pkgname=python3-evdev
version=1.6.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
makedepends="python3-devel"
+depends="python3"
+checkdepends="python3-pytest"
short_desc="Python3 bindings for the Linux input subsystem"
maintainer="Orphaned <orphan@voidlinux.org>"
license="BSD-3-Clause"
@@ -12,6 +14,11 @@ homepage="https://github.com/gvalkov/python-evdev"
distfiles="https://github.com/gvalkov/python-evdev/archive/v${version}.tar.gz"
checksum=85877121b46e0eacf390c1ee4a07e6f5fcb3c603c1649efcccdd554f2fe0c3ab
+pre_check() {
+ python3 setup.py build_ext --inplace
+ rm tests/test_uinput.py # permission issue with /dev/uinput
+}
+
post_install() {
vlicense LICENSE
}
From a17efb0efea93d9258eeea2e0ecd1df1c84e48e5 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:51:39 +0530
Subject: [PATCH 07/17] python3-execnet: add python3 as dep
---
srcpkgs/python3-execnet/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-execnet/template b/srcpkgs/python3-execnet/template
index e086bc625ec12..3b7593451dc80 100644
--- a/srcpkgs/python3-execnet/template
+++ b/srcpkgs/python3-execnet/template
@@ -1,9 +1,10 @@
# Template file for 'python3-execnet'
pkgname=python3-execnet
version=1.9.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-setuptools_scm"
+depends="python3"
checkdepends="python3-pytest"
short_desc="Distributed Python deployment and communication"
maintainer="classabbyamp <void@placeviolette.net>"
From 58749a49d97783477f61236336b9e4d1487675c3 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:54:19 +0530
Subject: [PATCH 08/17] python3-fastjsonschema: add python3 as dep
---
srcpkgs/python3-fastjsonschema/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-fastjsonschema/template b/srcpkgs/python3-fastjsonschema/template
index bd77a036455fd..707f9852cb877 100644
--- a/srcpkgs/python3-fastjsonschema/template
+++ b/srcpkgs/python3-fastjsonschema/template
@@ -1,10 +1,11 @@
# Template file for 'python3-fastjsonschema'
pkgname=python3-fastjsonschema
version=2.15.3
-revision=2
+revision=3
build_style=python3-module
make_check_args="--deselect tests/benchmarks/test_benchmark.py"
hostmakedepends="python3-setuptools"
+depends="python3"
checkdepends="python3-pytest"
short_desc="Fastest Python implementation of JSON schema"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
From 4926e843c6ccdfb6a18d2cc3701a233419eeac69 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:59:15 +0530
Subject: [PATCH 09/17] python3-fpylll: add python3 as dep
---
srcpkgs/python3-fpylll/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-fpylll/template b/srcpkgs/python3-fpylll/template
index 143112ea17baf..817dede1e5396 100644
--- a/srcpkgs/python3-fpylll/template
+++ b/srcpkgs/python3-fpylll/template
@@ -1,11 +1,12 @@
# Template file for 'python3-fpylll'
pkgname=python3-fpylll
version=0.5.7
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-Cython"
makedepends="python3-cysignals python3-devel gmp-devel mpfr-devel fplll-devel
pari-devel"
+depends="python3"
checkdepends="python3-pytest python3-numpy"
short_desc="Python wrapper to fplll (floating point lattice algorithms)"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
From bf4dae63fd40e70fd768d5566e57949a29692ca8 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:35:25 +0530
Subject: [PATCH 10/17] python3-jaraco.context: add python3 as dep, fix tests
---
srcpkgs/python3-jaraco.context/template | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-jaraco.context/template b/srcpkgs/python3-jaraco.context/template
index b3959500e5a92..7240e679bf018 100644
--- a/srcpkgs/python3-jaraco.context/template
+++ b/srcpkgs/python3-jaraco.context/template
@@ -1,9 +1,11 @@
# Template file for 'python3-jaraco.context'
pkgname=python3-jaraco.context
version=4.1.1
-revision=2
+revision=3
build_style=python3-pep517
hostmakedepends="python3-wheel python3-setuptools_scm"
+depends="python3"
+checkdepends="python3-pytest"
short_desc="Context managers by jaraco"
maintainer="Orphaned <orphan@voidlinux.org>"
license="MIT"
From cdf6abccd46f2c9f5ba9bb24f60b30fa25e2d890 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 02:04:09 +0530
Subject: [PATCH 11/17] python3-logfury: add python3 as dep
---
srcpkgs/python3-logfury/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-logfury/template b/srcpkgs/python3-logfury/template
index 72fd345953e54..6ec34675e3c2a 100644
--- a/srcpkgs/python3-logfury/template
+++ b/srcpkgs/python3-logfury/template
@@ -1,9 +1,10 @@
# Template file for 'python3-logfury'
pkgname=python3-logfury
version=1.0.1
-revision=3
+revision=4
build_style=python3-module
hostmakedepends="python3-setuptools_scm"
+depends="python3"
short_desc="Low-boilerplate logging of method calls (Python3)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="BSD-3-Clause"
From a0e3286c9df1bd1e1a631bdb8a6731a2474d186b Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:06:47 +0530
Subject: [PATCH 12/17] python3-lrcalc: add python3 as dep
---
srcpkgs/python3-lrcalc/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-lrcalc/template b/srcpkgs/python3-lrcalc/template
index 7be7c4e2be8c3..4c52a412d31da 100644
--- a/srcpkgs/python3-lrcalc/template
+++ b/srcpkgs/python3-lrcalc/template
@@ -1,10 +1,11 @@
# Template file for 'python3-lrcalc'
pkgname=python3-lrcalc
version=2.1
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython"
makedepends="python3-devel lrcalc-devel"
+depends="python3"
short_desc="Python bindings for the Littlewood-Richardson Calculator library"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="GPL-3.0-or-later"
From 6848f821c06d002aa3c9478e743116188468b6f2 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:09:11 +0530
Subject: [PATCH 13/17] python3-memory_allocator: add python3 as dep
---
srcpkgs/python3-memory_allocator/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-memory_allocator/template b/srcpkgs/python3-memory_allocator/template
index 71276c4f473e0..e9e0808a3cd02 100644
--- a/srcpkgs/python3-memory_allocator/template
+++ b/srcpkgs/python3-memory_allocator/template
@@ -1,10 +1,11 @@
# Template file for 'python3-memory_allocator'
pkgname=python3-memory_allocator
version=0.1.3
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython"
makedepends="python3-devel"
+depends="python3"
short_desc="Extension class to allocate memory easily with cython"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="GPL-3.0-or-later"
From e7976c2d863168a128251be5a46933d3a2cdb3fb Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:11:01 +0530
Subject: [PATCH 14/17] python3-pplpy: add python3 as dep, fix tests
---
srcpkgs/python3-pplpy/template | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-pplpy/template b/srcpkgs/python3-pplpy/template
index fdd39c496549a..6cf941dde8b9d 100644
--- a/srcpkgs/python3-pplpy/template
+++ b/srcpkgs/python3-pplpy/template
@@ -1,11 +1,12 @@
# Template file for 'python3-pplpy'
pkgname=python3-pplpy
version=0.8.7
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython"
makedepends="python3-cysignals python3-gmpy2 python3-devel gmp-devel
gmpxx-devel ppl-devel mpfr-devel libmpc-devel pari-devel"
+depends="python3"
short_desc="Python wrapper to the C++ Parma Polyhedra Library (PPL)"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="GPL-3.0-or-later"
@@ -13,3 +14,7 @@ homepage="https://gitlab.com/videlec/pplpy"
changelog="https://gitlab.com/videlec/pplpy/-/raw/master/CHANGES.txt"
distfiles="${PYPI_SITE}/p/pplpy/pplpy-${version}.tar.gz"
checksum=500bd0f4ae1a76956fae7fcba77854f5ec3e64fce76803664983763c3f2bd8bd
+
+pre_check() {
+ export PYTHONPATH=$(cd build/lib* && pwd)
+}
From 9f37c4193e90ceda002fa2cdb6279b029b8333cc Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:25:43 +0530
Subject: [PATCH 15/17] python3-primecountpy: add python3 as dep
---
srcpkgs/python3-primecountpy/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-primecountpy/template b/srcpkgs/python3-primecountpy/template
index 3f6bdb62fbfc7..0cd0b212fb8e9 100644
--- a/srcpkgs/python3-primecountpy/template
+++ b/srcpkgs/python3-primecountpy/template
@@ -1,10 +1,11 @@
# Template file for 'python3-primecountpy'
pkgname=python3-primecountpy
version=0.1.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython"
makedepends="python3-cysignals python3-devel primecount-devel pari-devel"
+depends="python3"
short_desc="Python interface to the C++ library primecount"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="GPL-3.0-or-later"
From 1a5ed009d933359045981fd2094123c74d714da9 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:27:19 +0530
Subject: [PATCH 16/17] python3-pycotap: add python3 as dep
---
srcpkgs/python3-pycotap/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-pycotap/template b/srcpkgs/python3-pycotap/template
index c85721f5b31b1..fe63eb584b778 100644
--- a/srcpkgs/python3-pycotap/template
+++ b/srcpkgs/python3-pycotap/template
@@ -1,9 +1,10 @@
# Template file for 'python3-pycotap'
pkgname=python3-pycotap
version=1.2.2
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
+depends="python3"
short_desc="Tiny test runner that outputs TAP results to standard output"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-or-later"
From b6fe581dc976985be26ab1504713f699291f3097 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:30:07 +0530
Subject: [PATCH 17/17] python3-utils: add python3 as dep
---
srcpkgs/python3-utils/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-utils/template b/srcpkgs/python3-utils/template
index 4fec3f5b5aa76..3537bb2ad69ef 100644
--- a/srcpkgs/python3-utils/template
+++ b/srcpkgs/python3-utils/template
@@ -1,11 +1,12 @@
# Template file for 'python3-utils'
pkgname=python3-utils
version=3.1.0
-revision=2
+revision=3
build_style=python3-module
# skip coverage and mypy tests https://github.com/WoLpH/python-utils/issues/29
make_check_args="-o addopts=--doctest-modules"
hostmakedepends="python3-setuptools"
+depends="python3"
checkdepends="python3-pytest python3-pytest-asyncio"
short_desc="Convenient utilities not included with the standard Python3 install"
maintainer="Karl Nilsson <karl.robert.nilsson@gmail.com>"
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
2022-11-17 10:48 ` [PR PATCH] [Updated] " icp1994
@ 2022-11-17 11:02 ` paper42
2022-11-17 11:07 ` paper42
` (22 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: paper42 @ 2022-11-17 11:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025047015
Comment:
Check can run multiple times, but rm will only succeed the first time because the file will be deleted then. Use -f or maybe better, add --deselect to pytest args instead.
```suggestion
PYTHONPATH="$(cd build/lib* && pwd)" pytest
rm -f tests/test_uinput.py # permission issue with /dev/uinput
```
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
2022-11-17 10:48 ` [PR PATCH] [Updated] " icp1994
2022-11-17 11:02 ` [PR REVIEW] " paper42
@ 2022-11-17 11:07 ` paper42
2022-11-17 11:08 ` paper42
` (21 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: paper42 @ 2022-11-17 11:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025051561
Comment:
and add python3-pytest to checkdepends
```suggestion
pre_check() {
PYTHONPATH=$(cd build/lib* && pwd) pytest
```
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (2 preceding siblings ...)
2022-11-17 11:07 ` paper42
@ 2022-11-17 11:08 ` paper42
2022-11-17 13:14 ` icp1994
` (20 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: paper42 @ 2022-11-17 11:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025047015
Comment:
Check can run multiple times, but rm will only succeed the first time because the file will be deleted then. Use -f or maybe better, add --deselect to pytest args instead.
```suggestion
rm -f tests/test_uinput.py # permission issue with /dev/uinput
PYTHONPATH="$(cd build/lib* && pwd)" pytest
```
EDIT: ^ and this should be in do_check
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (3 preceding siblings ...)
2022-11-17 11:08 ` paper42
@ 2022-11-17 13:14 ` icp1994
2022-11-17 13:29 ` icp1994
` (19 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: icp1994 @ 2022-11-17 13:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
New review comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025173539
Comment:
Huh! I actually tried that before submitting but with `python3 -m pytest`, as seen in the python3-module build_style, which didn't work. So, under `do_check()`:
`PYTHONPATH="$(cd build/lib* && pwd)" pytest --ignore tests/test_uinput.py` -> works
`PYTHONPATH="$(cd build/lib* && pwd)" python3 -m pytest --ignore tests/test_uinput.py` -> fails with import issues.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (4 preceding siblings ...)
2022-11-17 13:14 ` icp1994
@ 2022-11-17 13:29 ` icp1994
2022-11-17 13:32 ` paper42
` (18 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: icp1994 @ 2022-11-17 13:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 9010 bytes --]
New review comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025190470
Comment:
There are a couple extra tests being run by the setup,py test method. Here's the output in the current state:
```
=> python3-pplpy-0.8.7_3: running do_check ...
/builddir/python3-pplpy-0.8.7/setup.py:14: SetuptoolsDeprecationWarning: As setuptools moves its configuration towards `pyproject.toml`,
`setuptools.config.read_configuration` became deprecated.
For the time being, you can use the `setuptools.config.setupcfg` module
to access a backward compatible API, but this module is provisional
and might be removed in the future.
conf_dict = read_configuration(os.path.join(dir_path, "setup.cfg"))
running test
copying ./tests/testpplpy.pyx -> /tmp/tmp3ane4nvz
creating /tmp/tmp3ane4nvz/__pycache__
copying ./tests/__pycache__/test_constraint.cpython-311-pytest-7.1.3.pyc -> /tmp/tmp3ane4nvz/__pycache__
copying ./tests/__pycache__/test_variable.cpython-311-pytest-7.1.3.pyc -> /tmp/tmp3ane4nvz/__pycache__
copying ./tests/testpplpy2.pyx -> /tmp/tmp3ane4nvz
copying ./tests/setup2.py -> /tmp/tmp3ane4nvz
copying ./tests/test_constraint.py -> /tmp/tmp3ane4nvz
copying ./tests/runtests.py -> /tmp/tmp3ane4nvz
copying ./tests/setup.py -> /tmp/tmp3ane4nvz
copying ./tests/test_variable.py -> /tmp/tmp3ane4nvz
test_creation_invalid (test_variable.TestVariable.test_creation_invalid) ... ok
test_creation_valid (test_variable.TestVariable.test_creation_valid) ... ok
----------------------------------------------------------------------
Ran 2 tests in 0.000s
OK
test_creation_empty (test_constraint.TestConstraint.test_creation_empty) ... ok
test_creation_invalid (test_constraint.TestConstraint.test_creation_invalid) ... ok
test_creation_other (test_constraint.TestConstraint.test_creation_other) ... ok
test_creation_empty (test_constraint.TestConstraint_System.test_creation_empty) ... ok
test_creation_invalid (test_constraint.TestConstraint_System.test_creation_invalid) ... ok
test_creation_other (test_constraint.TestConstraint_System.test_creation_other) ... ok
----------------------------------------------------------------------
Ran 6 tests in 0.001s
OK
Running pplpy doctests
--------------------------------------------------------------------------------
<module 'ppl' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/__init__.py'>
TestResults(failed=0, attempted=34)
--------------------------------------------------------------------------------
<module 'ppl.linear_algebra' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/linear_algebra.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=402)
--------------------------------------------------------------------------------
<module 'ppl.mip_problem' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/mip_problem.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=394)
--------------------------------------------------------------------------------
<module 'ppl.polyhedron' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/polyhedron.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=1204)
--------------------------------------------------------------------------------
<module 'ppl.generator' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/generator.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=468)
--------------------------------------------------------------------------------
<module 'ppl.constraint' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/constraint.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=478)
--------------------------------------------------------------------------------
<module 'ppl.congruence' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/congruence.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=156)
--------------------------------------------------------------------------------
<module 'ppl.bit_arrays' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/bit_arrays.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=102)
--------------------------------------------------------------------------------
Running unittests
--------------------------------------------------------------------------------
/usr/lib/python3.11/site-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /tmp/tmp3ane4nvz/testpplpy.pyx
tree = Parsing.p_module(s, pxd, full_module_name)
Compiling testpplpy.pyx because it changed.
[1/1] Cythonizing testpplpy.pyx
running build_ext
building 'testpplpy' extension
creating build
creating build/temp.linux-x86_64-cpython-311
cc -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -g -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -g -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/python3-pplpy-0.8.7=. -fPIC -I/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl -I/usr/include/python3.11 -c testpplpy.cpp -o build/temp.linux-x86_64-cpython-311/testpplpy.o
creating build/lib.linux-x86_64-cpython-311
g++ -shared -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/python3-pplpy-0.8.7=. build/temp.linux-x86_64-cpython-311/testpplpy.o -L/usr/lib64 -lppl -o build/lib.linux-x86_64-cpython-311/testpplpy.cpython-311-x86_64-linux-gnu.so
copying build/lib.linux-x86_64-cpython-311/testpplpy.cpython-311-x86_64-linux-gnu.so ->
--------------------------------------------------------------------------------
Cython test 1 OK
--------------------------------------------------------------------------------
Generator_System {ray(1, 0, -1), ray(0, 1, -1), point(0/1, 0/1, 1/1)}
dim = 3
--------------------------------------------------------------------------------
Cython example 1 OK
--------------------------------------------------------------------------------
/usr/lib/python3.11/site-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /tmp/tmp3ane4nvz/testpplpy2.pyx
tree = Parsing.p_module(s, pxd, full_module_name)
Compiling testpplpy2.pyx because it changed.
[1/1] Cythonizing testpplpy2.pyx
running build_ext
building 'testpplpy2' extension
cc -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -g -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -g -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/python3-pplpy-0.8.7=. -fPIC -I/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl -I/usr/include/python3.11 -c testpplpy2.cpp -o build/temp.linux-x86_64-cpython-311/testpplpy2.o
g++ -shared -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/python3-pplpy-0.8.7=. build/temp.linux-x86_64-cpython-311/testpplpy2.o -L/usr/lib64 -lppl -o build/lib.linux-x86_64-cpython-311/testpplpy2.cpython-311-x86_64-linux-gnu.so
copying build/lib.linux-x86_64-cpython-311/testpplpy2.cpython-311-x86_64-linux-gnu.so ->
--------------------------------------------------------------------------------
Cython test 2 OK
--------------------------------------------------------------------------------
Generator_System {ray(1, 0, -1), ray(0, 1, -1), point(0/1, 0/1, 1/1)}
dim = 3
--------------------------------------------------------------------------------
Cython example 2 OK
--------------------------------------------------------------------------------
=> python3-pplpy-0.8.7_3: running pre-install hook: 00-libdir ...
```
The pytest output in comparison:
```
=> python3-pplpy-0.8.7_3: running do_check ...
============================= test session starts ==============================
platform linux -- Python 3.11.0, pytest-7.1.3, pluggy-1.0.0
rootdir: /builddir/python3-pplpy-0.8.7
collected 8 items
tests/test_constraint.py ...... [ 75%]
tests/test_variable.py .. [100%]
============================== 8 passed in 0.04s ===============================
=> python3-pplpy-0.8.7_3: running pre-install hook: 00-libdir ...
```
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (5 preceding siblings ...)
2022-11-17 13:29 ` icp1994
@ 2022-11-17 13:32 ` paper42
2022-11-17 13:34 ` paper42
` (17 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: paper42 @ 2022-11-17 13:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 292 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025194036
Comment:
hmm, I would still move to pytest, using setup.py is deprecated and someone is going to change it to pytest next time because they won't notice.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (6 preceding siblings ...)
2022-11-17 13:32 ` paper42
@ 2022-11-17 13:34 ` paper42
2022-11-17 13:38 ` icp1994
` (16 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: paper42 @ 2022-11-17 13:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025195336
Comment:
Yeah, this is a bit weird. Just yesterday this came up in #xbps on IRC. `python3 -m pytest` and `pytest` are different in how they set PYTHONPATH.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (7 preceding siblings ...)
2022-11-17 13:34 ` paper42
@ 2022-11-17 13:38 ` icp1994
2022-11-17 13:39 ` icp1994
` (15 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: icp1994 @ 2022-11-17 13:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
New review comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025199745
Comment:
Do you know why in the python3-module build_style do_check(), the setup.py test section does not have the custom PYTHONPATH like it is in the pytest section? That would resolve having to export PYTHONPATH in some templates I have seen recently.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (8 preceding siblings ...)
2022-11-17 13:38 ` icp1994
@ 2022-11-17 13:39 ` icp1994
2022-11-17 13:39 ` paper42
` (14 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: icp1994 @ 2022-11-17 13:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
New review comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025201286
Comment:
I see, thanks for the info.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (9 preceding siblings ...)
2022-11-17 13:39 ` icp1994
@ 2022-11-17 13:39 ` paper42
2022-11-17 13:45 ` ahesford
` (13 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: paper42 @ 2022-11-17 13:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025201834
Comment:
I don't know that, but @ahesford might.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (10 preceding siblings ...)
2022-11-17 13:39 ` paper42
@ 2022-11-17 13:45 ` ahesford
2022-11-17 13:48 ` [PR PATCH] [Updated] " icp1994
` (12 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: ahesford @ 2022-11-17 13:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025210318
Comment:
Somebody (maybe sgn, but I can't remember for sure) added the path to fix some failing tests. There was no impetus to fix the other alternative.
In fact, given that testing via the setup script is deprecated and most times runs no tests at all, we should just drop it from the build style.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR PATCH] [Updated] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (11 preceding siblings ...)
2022-11-17 13:45 ` ahesford
@ 2022-11-17 13:48 ` icp1994
2022-11-17 13:53 ` [PR REVIEW] " icp1994
` (11 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: icp1994 @ 2022-11-17 13:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
There is an updated pull request by icp1994 against master on the void-packages repository
https://github.com/icp1994/void-packages pydepfix
https://github.com/void-linux/void-packages/pull/40569
srcpkgs: add missing python3 dependency in python3 packages
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/40569.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pydepfix-40569.patch --]
[-- Type: text/x-diff, Size: 16631 bytes --]
From b4f1bb6fce8729e44c8d17a93c901bb013b1b057 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:27:29 +0530
Subject: [PATCH 01/17] libvirt-python3: add python3 as dep
---
srcpkgs/libvirt-python3/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/libvirt-python3/template b/srcpkgs/libvirt-python3/template
index bc94c71d6a38..6885784f177f 100644
--- a/srcpkgs/libvirt-python3/template
+++ b/srcpkgs/libvirt-python3/template
@@ -1,11 +1,12 @@
# Template file for 'libvirt-python3'
pkgname=libvirt-python3
version=8.9.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="pkg-config python3-devel python3-setuptools libvirt-devel
libapparmor-devel"
makedepends="libvirt-devel python3-devel"
+depends="python3"
checkdepends="python3-pytest python3-lxml python3-nose"
short_desc="Libvirt virtualization API Python3 binding"
maintainer="Helmut Pozimski <helmut@pozimski.eu>"
From 866bdefed8b006b85945f62740e235bf40074500 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:30:05 +0530
Subject: [PATCH 02/17] ps_mem: add python3 as dep
---
srcpkgs/ps_mem/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/ps_mem/template b/srcpkgs/ps_mem/template
index 35698523d95e..bc97b0d92a9b 100644
--- a/srcpkgs/ps_mem/template
+++ b/srcpkgs/ps_mem/template
@@ -1,9 +1,10 @@
# Template file for 'ps_mem'
pkgname=ps_mem
version=3.14
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
+depends="python3"
short_desc="Utility to accurately report the core memory usage for a program"
maintainer="wael <40663@proton.me>"
license="LGPL-2.1-only"
From e4dc98bfff36aab271b25ba14879ad9c59bd84ae Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:36:43 +0530
Subject: [PATCH 03/17] python3-cvxopt: add python3 as dep
---
srcpkgs/python3-cvxopt/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-cvxopt/template b/srcpkgs/python3-cvxopt/template
index 4044fbfea2a7..770533353df8 100644
--- a/srcpkgs/python3-cvxopt/template
+++ b/srcpkgs/python3-cvxopt/template
@@ -1,11 +1,12 @@
# Template file for 'python3-cvxopt'
pkgname=python3-cvxopt
version=1.3.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
makedepends="python3-devel blas-devel lapack-devel SuiteSparse-devel gsl-devel
glpk-devel fftw-devel"
+depends="python3"
checkdepends="python3-pytest"
short_desc="Python software for convex optimization"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
From d7394b99fecf9095ce5623061d552a8dbe7efd00 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:40:27 +0530
Subject: [PATCH 04/17] python3-cysignals: add python3 as dep
---
srcpkgs/python3-cysignals/template | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/python3-cysignals/template b/srcpkgs/python3-cysignals/template
index 52396d21b099..bd9563353ba0 100644
--- a/srcpkgs/python3-cysignals/template
+++ b/srcpkgs/python3-cysignals/template
@@ -1,11 +1,12 @@
# Template file for 'python3-cysignals'
pkgname=python3-cysignals
version=1.11.2
-revision=3
+revision=4
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython autoconf"
makedepends="python3-devel pari-devel"
-short_desc="Interrupt and signal handling for Cython "
+depends="python3"
+short_desc="Interrupt and signal handling for Cython"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="LGPL-3.0-or-later"
homepage="https://github.com/sagemath/cysignals"
From c871ebca3d25e2413e4067bf1b44697531f2e869 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:42:42 +0530
Subject: [PATCH 05/17] python3-docstring-to-markdown: add python3 as dep
---
srcpkgs/python3-docstring-to-markdown/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-docstring-to-markdown/template b/srcpkgs/python3-docstring-to-markdown/template
index 3b35f6bf7bfb..1fb42cafc3c5 100644
--- a/srcpkgs/python3-docstring-to-markdown/template
+++ b/srcpkgs/python3-docstring-to-markdown/template
@@ -1,9 +1,10 @@
# Template file for 'python3-docstring-to-markdown'
pkgname=python3-docstring-to-markdown
version=0.10
-revision=1
+revision=2
build_style=python3-module
hostmakedepends="python3-setuptools_scm"
+depends="python3"
short_desc="Python implementation of the Language Server Protocol"
maintainer="Cameron Nemo <cam@nohom.org>"
license="LGPL-2.1-only"
From 7aa4605fc47de09f44640c62d5a0378d6b390fbc Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:10:08 +0530
Subject: [PATCH 06/17] python3-evdev: add python3 as dep, fix tests
---
srcpkgs/python3-evdev/template | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-evdev/template b/srcpkgs/python3-evdev/template
index 87cbf8477615..6a08a003f89e 100644
--- a/srcpkgs/python3-evdev/template
+++ b/srcpkgs/python3-evdev/template
@@ -1,10 +1,12 @@
# Template file for 'python3-evdev'
pkgname=python3-evdev
version=1.6.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
makedepends="python3-devel"
+depends="python3"
+checkdepends="python3-pytest"
short_desc="Python3 bindings for the Linux input subsystem"
maintainer="Orphaned <orphan@voidlinux.org>"
license="BSD-3-Clause"
@@ -12,6 +14,11 @@ homepage="https://github.com/gvalkov/python-evdev"
distfiles="https://github.com/gvalkov/python-evdev/archive/v${version}.tar.gz"
checksum=85877121b46e0eacf390c1ee4a07e6f5fcb3c603c1649efcccdd554f2fe0c3ab
+do_check() {
+ # ignored uinput tests due to permission issues agasint /dev/uinput
+ PYTHONPATH="$(cd build/lib* && pwd)" pytest --ignore tests/test_uinput.py
+}
+
post_install() {
vlicense LICENSE
}
From e0c4d75d75affc5cf0858882316aad98983e389b Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:51:39 +0530
Subject: [PATCH 07/17] python3-execnet: add python3 as dep
---
srcpkgs/python3-execnet/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-execnet/template b/srcpkgs/python3-execnet/template
index e086bc625ec1..3b7593451dc8 100644
--- a/srcpkgs/python3-execnet/template
+++ b/srcpkgs/python3-execnet/template
@@ -1,9 +1,10 @@
# Template file for 'python3-execnet'
pkgname=python3-execnet
version=1.9.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-setuptools_scm"
+depends="python3"
checkdepends="python3-pytest"
short_desc="Distributed Python deployment and communication"
maintainer="classabbyamp <void@placeviolette.net>"
From e71e0836dfc0878eeaabb849410b5a47baf24cd0 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:54:19 +0530
Subject: [PATCH 08/17] python3-fastjsonschema: add python3 as dep
---
srcpkgs/python3-fastjsonschema/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-fastjsonschema/template b/srcpkgs/python3-fastjsonschema/template
index bd77a036455f..707f9852cb87 100644
--- a/srcpkgs/python3-fastjsonschema/template
+++ b/srcpkgs/python3-fastjsonschema/template
@@ -1,10 +1,11 @@
# Template file for 'python3-fastjsonschema'
pkgname=python3-fastjsonschema
version=2.15.3
-revision=2
+revision=3
build_style=python3-module
make_check_args="--deselect tests/benchmarks/test_benchmark.py"
hostmakedepends="python3-setuptools"
+depends="python3"
checkdepends="python3-pytest"
short_desc="Fastest Python implementation of JSON schema"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
From 5c5d47be421d338cc842ddfe2fd605d79917a46a Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:59:15 +0530
Subject: [PATCH 09/17] python3-fpylll: add python3 as dep
---
srcpkgs/python3-fpylll/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-fpylll/template b/srcpkgs/python3-fpylll/template
index 143112ea17ba..817dede1e539 100644
--- a/srcpkgs/python3-fpylll/template
+++ b/srcpkgs/python3-fpylll/template
@@ -1,11 +1,12 @@
# Template file for 'python3-fpylll'
pkgname=python3-fpylll
version=0.5.7
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-Cython"
makedepends="python3-cysignals python3-devel gmp-devel mpfr-devel fplll-devel
pari-devel"
+depends="python3"
checkdepends="python3-pytest python3-numpy"
short_desc="Python wrapper to fplll (floating point lattice algorithms)"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
From 1fecc9b3b85536ba03f8db6e1e4b39029af35aae Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:35:25 +0530
Subject: [PATCH 10/17] python3-jaraco.context: add python3 as dep, fix tests
---
srcpkgs/python3-jaraco.context/template | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-jaraco.context/template b/srcpkgs/python3-jaraco.context/template
index b3959500e5a9..7240e679bf01 100644
--- a/srcpkgs/python3-jaraco.context/template
+++ b/srcpkgs/python3-jaraco.context/template
@@ -1,9 +1,11 @@
# Template file for 'python3-jaraco.context'
pkgname=python3-jaraco.context
version=4.1.1
-revision=2
+revision=3
build_style=python3-pep517
hostmakedepends="python3-wheel python3-setuptools_scm"
+depends="python3"
+checkdepends="python3-pytest"
short_desc="Context managers by jaraco"
maintainer="Orphaned <orphan@voidlinux.org>"
license="MIT"
From 261317cb7662a961fe0aed82d17c74e741655085 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 02:04:09 +0530
Subject: [PATCH 11/17] python3-logfury: add python3 as dep
---
srcpkgs/python3-logfury/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-logfury/template b/srcpkgs/python3-logfury/template
index 72fd345953e5..6ec34675e3c2 100644
--- a/srcpkgs/python3-logfury/template
+++ b/srcpkgs/python3-logfury/template
@@ -1,9 +1,10 @@
# Template file for 'python3-logfury'
pkgname=python3-logfury
version=1.0.1
-revision=3
+revision=4
build_style=python3-module
hostmakedepends="python3-setuptools_scm"
+depends="python3"
short_desc="Low-boilerplate logging of method calls (Python3)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="BSD-3-Clause"
From eb6b2eac9c9be08feb9660e77908d81dffe289eb Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:06:47 +0530
Subject: [PATCH 12/17] python3-lrcalc: add python3 as dep
---
srcpkgs/python3-lrcalc/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-lrcalc/template b/srcpkgs/python3-lrcalc/template
index 7be7c4e2be8c..4c52a412d31d 100644
--- a/srcpkgs/python3-lrcalc/template
+++ b/srcpkgs/python3-lrcalc/template
@@ -1,10 +1,11 @@
# Template file for 'python3-lrcalc'
pkgname=python3-lrcalc
version=2.1
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython"
makedepends="python3-devel lrcalc-devel"
+depends="python3"
short_desc="Python bindings for the Littlewood-Richardson Calculator library"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="GPL-3.0-or-later"
From 9e4afbf697c810ce9bc761bf1825056326c6e0d1 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:09:11 +0530
Subject: [PATCH 13/17] python3-memory_allocator: add python3 as dep
---
srcpkgs/python3-memory_allocator/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-memory_allocator/template b/srcpkgs/python3-memory_allocator/template
index 71276c4f473e..e9e0808a3cd0 100644
--- a/srcpkgs/python3-memory_allocator/template
+++ b/srcpkgs/python3-memory_allocator/template
@@ -1,10 +1,11 @@
# Template file for 'python3-memory_allocator'
pkgname=python3-memory_allocator
version=0.1.3
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython"
makedepends="python3-devel"
+depends="python3"
short_desc="Extension class to allocate memory easily with cython"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="GPL-3.0-or-later"
From 4570f7646f0abdc291eaaee4185a71c091ec3eca Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:11:01 +0530
Subject: [PATCH 14/17] python3-pplpy: add python3 as dep, fix tests
---
srcpkgs/python3-pplpy/template | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-pplpy/template b/srcpkgs/python3-pplpy/template
index fdd39c496549..aa2f06f273cb 100644
--- a/srcpkgs/python3-pplpy/template
+++ b/srcpkgs/python3-pplpy/template
@@ -1,11 +1,13 @@
# Template file for 'python3-pplpy'
pkgname=python3-pplpy
version=0.8.7
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython"
makedepends="python3-cysignals python3-gmpy2 python3-devel gmp-devel
gmpxx-devel ppl-devel mpfr-devel libmpc-devel pari-devel"
+depends="python3"
+checkdepends="python3-pytest"
short_desc="Python wrapper to the C++ Parma Polyhedra Library (PPL)"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="GPL-3.0-or-later"
@@ -13,3 +15,7 @@ homepage="https://gitlab.com/videlec/pplpy"
changelog="https://gitlab.com/videlec/pplpy/-/raw/master/CHANGES.txt"
distfiles="${PYPI_SITE}/p/pplpy/pplpy-${version}.tar.gz"
checksum=500bd0f4ae1a76956fae7fcba77854f5ec3e64fce76803664983763c3f2bd8bd
+
+do_check() {
+ PYTHONPATH=$(cd build/lib* && pwd) pytest
+}
From 45147db61e1a8ae4cc4580b4ed057de1b3d2316a Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:25:43 +0530
Subject: [PATCH 15/17] python3-primecountpy: add python3 as dep
---
srcpkgs/python3-primecountpy/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-primecountpy/template b/srcpkgs/python3-primecountpy/template
index 3f6bdb62fbfc..0cd0b212fb8e 100644
--- a/srcpkgs/python3-primecountpy/template
+++ b/srcpkgs/python3-primecountpy/template
@@ -1,10 +1,11 @@
# Template file for 'python3-primecountpy'
pkgname=python3-primecountpy
version=0.1.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython"
makedepends="python3-cysignals python3-devel primecount-devel pari-devel"
+depends="python3"
short_desc="Python interface to the C++ library primecount"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="GPL-3.0-or-later"
From a1c962241437735d078d781bbae0e61af88c37b0 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:27:19 +0530
Subject: [PATCH 16/17] python3-pycotap: add python3 as dep
---
srcpkgs/python3-pycotap/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-pycotap/template b/srcpkgs/python3-pycotap/template
index c85721f5b31b..fe63eb584b77 100644
--- a/srcpkgs/python3-pycotap/template
+++ b/srcpkgs/python3-pycotap/template
@@ -1,9 +1,10 @@
# Template file for 'python3-pycotap'
pkgname=python3-pycotap
version=1.2.2
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
+depends="python3"
short_desc="Tiny test runner that outputs TAP results to standard output"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-or-later"
From c048eef215342be3112f0bb53e07ab685f913fd2 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:30:07 +0530
Subject: [PATCH 17/17] python3-utils: add python3 as dep
---
srcpkgs/python3-utils/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-utils/template b/srcpkgs/python3-utils/template
index 4fec3f5b5aa7..3537bb2ad69e 100644
--- a/srcpkgs/python3-utils/template
+++ b/srcpkgs/python3-utils/template
@@ -1,11 +1,12 @@
# Template file for 'python3-utils'
pkgname=python3-utils
version=3.1.0
-revision=2
+revision=3
build_style=python3-module
# skip coverage and mypy tests https://github.com/WoLpH/python-utils/issues/29
make_check_args="-o addopts=--doctest-modules"
hostmakedepends="python3-setuptools"
+depends="python3"
checkdepends="python3-pytest python3-pytest-asyncio"
short_desc="Convenient utilities not included with the standard Python3 install"
maintainer="Karl Nilsson <karl.robert.nilsson@gmail.com>"
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (12 preceding siblings ...)
2022-11-17 13:48 ` [PR PATCH] [Updated] " icp1994
@ 2022-11-17 13:53 ` icp1994
2022-11-17 14:00 ` ahesford
` (10 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: icp1994 @ 2022-11-17 13:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 286 bytes --]
New review comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025220505
Comment:
Since you are here, any downside of using pytest instead of python3 -m pytest in build styles? (see resolved discussion above for context)
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (13 preceding siblings ...)
2022-11-17 13:53 ` [PR REVIEW] " icp1994
@ 2022-11-17 14:00 ` ahesford
2022-11-21 21:19 ` tornaria
` (9 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: ahesford @ 2022-11-17 14:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025230818
Comment:
I think `python3 -m pytest` solved some issues at the time we added support for pytest in the build style. I'm not sure if it's still relevant. If the build style is changed, we should run through tests in at least a random sample of packages to have confidence that the change isn't causing more harm than good.
Keeping the module form in the pep517 style is probably the right behavior, because it's better to try running tests from the current directory than to fail when the pep517 builder leaves no stages package available for test.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (14 preceding siblings ...)
2022-11-17 14:00 ` ahesford
@ 2022-11-21 21:19 ` tornaria
2022-11-21 21:30 ` ahesford
` (8 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: tornaria @ 2022-11-21 21:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
New review comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1028524506
Comment:
Please don't change the way tests are run. The commit claims to "fix tests" but in fact is breaking them in the worst possible way: not running them at all.
Some projects have attempts at using pytest for testing, in the sense that they wrote a couple of silly tests that run via pytest. But then they don't migrate the whole testsuite to pytest. Hence, if you run pytest it might succeed, running a few trivial tests and making you believe tests passed, when in fact the important tests have not run at all.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (15 preceding siblings ...)
2022-11-21 21:19 ` tornaria
@ 2022-11-21 21:30 ` ahesford
2022-11-21 21:44 ` tornaria
` (7 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: ahesford @ 2022-11-21 21:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1028532386
Comment:
The majority of projects I've seen in our repo silently do nothing with `python3 setup.py test` besides print a deprecation warning. If dropping support for this case highlights more overlooked tests than keeping it does, it's the right thing to do. We can always add back `python3 setup.py test` in manual `do_check` overrides in the templates that still rely on this behavior if the set isn't too large.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (16 preceding siblings ...)
2022-11-21 21:30 ` ahesford
@ 2022-11-21 21:44 ` tornaria
2022-11-21 21:46 ` ahesford
` (6 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: tornaria @ 2022-11-21 21:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
New review comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1028542109
Comment:
I meant don't change custom `do_check()` overrides. Also: don't remove a custom `do_check()`. Maybe it's there for a reason. Feel free to ping me if you believe some of my custom `do_check()`s are incorrect or unnecessary.
Here in this thread it is clearly documented that, for this particular package (python3-pplpy), running setup test will run many many more tests. So, don't change it. Same for python3-cypari2 (see #40667).
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (17 preceding siblings ...)
2022-11-21 21:44 ` tornaria
@ 2022-11-21 21:46 ` ahesford
2022-11-22 5:36 ` icp1994
` (5 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: ahesford @ 2022-11-21 21:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1028543699
Comment:
I agree, if custom `do_check` overrides exist, it should be understood that removing it doesn't degrade the test experience before doing so.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (18 preceding siblings ...)
2022-11-21 21:46 ` ahesford
@ 2022-11-22 5:36 ` icp1994
2022-12-16 18:19 ` paper42
` (4 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: icp1994 @ 2022-11-22 5:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
New review comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1028856843
Comment:
> The commit claims to "fix tests" but in fact is breaking them in the worst possible way: not running them at all.
Well, my patch was on top of https://github.com/void-linux/void-packages/commit/ecdf957b863134bdfe26208e39d5b877a9ce49f0 which broke the tests - so from my perspective it was indeed a "fix"
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (19 preceding siblings ...)
2022-11-22 5:36 ` icp1994
@ 2022-12-16 18:19 ` paper42
2022-12-17 13:25 ` [PR PATCH] [Updated] " icp1994
` (3 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: paper42 @ 2022-12-16 18:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#issuecomment-1355361241
Comment:
@icp1994 could you rebase this?
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR PATCH] [Updated] srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (20 preceding siblings ...)
2022-12-16 18:19 ` paper42
@ 2022-12-17 13:25 ` icp1994
2022-12-17 17:26 ` tornaria
` (2 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: icp1994 @ 2022-12-17 13:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
There is an updated pull request by icp1994 against master on the void-packages repository
https://github.com/icp1994/void-packages pydepfix
https://github.com/void-linux/void-packages/pull/40569
srcpkgs: add missing python3 dependency in python3 packages
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/40569.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pydepfix-40569.patch --]
[-- Type: text/x-diff, Size: 16643 bytes --]
From e66b85a74a2805de365a9cb01e452b4ae33cc714 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:27:29 +0530
Subject: [PATCH 01/17] libvirt-python3: add python3 as dep
---
srcpkgs/libvirt-python3/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/libvirt-python3/template b/srcpkgs/libvirt-python3/template
index f48cc3437f5e..5c4a6734ff08 100644
--- a/srcpkgs/libvirt-python3/template
+++ b/srcpkgs/libvirt-python3/template
@@ -1,11 +1,12 @@
# Template file for 'libvirt-python3'
pkgname=libvirt-python3
version=8.10.0
-revision=1
+revision=2
build_style=python3-module
hostmakedepends="pkg-config python3-devel python3-setuptools libvirt-devel
libapparmor-devel"
makedepends="libvirt-devel python3-devel"
+depends="python3"
checkdepends="python3-pytest python3-lxml python3-nose"
short_desc="Libvirt virtualization API Python3 binding"
maintainer="Helmut Pozimski <helmut@pozimski.eu>"
From 74a3e75f3dcec85cfc4b2fbba81364714070822e Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:30:05 +0530
Subject: [PATCH 02/17] ps_mem: add python3 as dep
---
srcpkgs/ps_mem/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/ps_mem/template b/srcpkgs/ps_mem/template
index 35698523d95e..bc97b0d92a9b 100644
--- a/srcpkgs/ps_mem/template
+++ b/srcpkgs/ps_mem/template
@@ -1,9 +1,10 @@
# Template file for 'ps_mem'
pkgname=ps_mem
version=3.14
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
+depends="python3"
short_desc="Utility to accurately report the core memory usage for a program"
maintainer="wael <40663@proton.me>"
license="LGPL-2.1-only"
From 70d05af9e2c6a623ad5c33dad60185566594dbef Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:36:43 +0530
Subject: [PATCH 03/17] python3-cvxopt: add python3 as dep
---
srcpkgs/python3-cvxopt/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-cvxopt/template b/srcpkgs/python3-cvxopt/template
index 944086e37837..666a63af1be0 100644
--- a/srcpkgs/python3-cvxopt/template
+++ b/srcpkgs/python3-cvxopt/template
@@ -1,11 +1,12 @@
# Template file for 'python3-cvxopt'
pkgname=python3-cvxopt
version=1.3.0
-revision=3
+revision=4
build_style=python3-module
hostmakedepends="python3-setuptools"
makedepends="python3-devel SuiteSparse-devel gsl-devel glpk-devel fftw-devel
$(vopt_if openblas 'openblas-devel' 'lapack-devel')"
+depends="python3"
checkdepends="python3-pytest"
short_desc="Python software for convex optimization"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
From 968e779a885f7b037031552df130a525afa33822 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:40:27 +0530
Subject: [PATCH 04/17] python3-cysignals: add python3 as dep
---
srcpkgs/python3-cysignals/template | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/python3-cysignals/template b/srcpkgs/python3-cysignals/template
index 52396d21b099..bd9563353ba0 100644
--- a/srcpkgs/python3-cysignals/template
+++ b/srcpkgs/python3-cysignals/template
@@ -1,11 +1,12 @@
# Template file for 'python3-cysignals'
pkgname=python3-cysignals
version=1.11.2
-revision=3
+revision=4
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython autoconf"
makedepends="python3-devel pari-devel"
-short_desc="Interrupt and signal handling for Cython "
+depends="python3"
+short_desc="Interrupt and signal handling for Cython"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="LGPL-3.0-or-later"
homepage="https://github.com/sagemath/cysignals"
From 5bd4cb82fe2ba613f310cc73cf6b9e0bcf48d763 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:42:42 +0530
Subject: [PATCH 05/17] python3-docstring-to-markdown: add python3 as dep
---
srcpkgs/python3-docstring-to-markdown/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-docstring-to-markdown/template b/srcpkgs/python3-docstring-to-markdown/template
index 3b35f6bf7bfb..1fb42cafc3c5 100644
--- a/srcpkgs/python3-docstring-to-markdown/template
+++ b/srcpkgs/python3-docstring-to-markdown/template
@@ -1,9 +1,10 @@
# Template file for 'python3-docstring-to-markdown'
pkgname=python3-docstring-to-markdown
version=0.10
-revision=1
+revision=2
build_style=python3-module
hostmakedepends="python3-setuptools_scm"
+depends="python3"
short_desc="Python implementation of the Language Server Protocol"
maintainer="Cameron Nemo <cam@nohom.org>"
license="LGPL-2.1-only"
From fb161ad5d73bf349c59be3c4e9f3a5691c634357 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:10:08 +0530
Subject: [PATCH 06/17] python3-evdev: add python3 as dep, fix tests
---
srcpkgs/python3-evdev/template | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-evdev/template b/srcpkgs/python3-evdev/template
index 87cbf8477615..6a08a003f89e 100644
--- a/srcpkgs/python3-evdev/template
+++ b/srcpkgs/python3-evdev/template
@@ -1,10 +1,12 @@
# Template file for 'python3-evdev'
pkgname=python3-evdev
version=1.6.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
makedepends="python3-devel"
+depends="python3"
+checkdepends="python3-pytest"
short_desc="Python3 bindings for the Linux input subsystem"
maintainer="Orphaned <orphan@voidlinux.org>"
license="BSD-3-Clause"
@@ -12,6 +14,11 @@ homepage="https://github.com/gvalkov/python-evdev"
distfiles="https://github.com/gvalkov/python-evdev/archive/v${version}.tar.gz"
checksum=85877121b46e0eacf390c1ee4a07e6f5fcb3c603c1649efcccdd554f2fe0c3ab
+do_check() {
+ # ignored uinput tests due to permission issues agasint /dev/uinput
+ PYTHONPATH="$(cd build/lib* && pwd)" pytest --ignore tests/test_uinput.py
+}
+
post_install() {
vlicense LICENSE
}
From 2cd7e00532aba344787c8abbda3c1c70bb5c6109 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:51:39 +0530
Subject: [PATCH 07/17] python3-execnet: add python3 as dep
---
srcpkgs/python3-execnet/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-execnet/template b/srcpkgs/python3-execnet/template
index e086bc625ec1..3b7593451dc8 100644
--- a/srcpkgs/python3-execnet/template
+++ b/srcpkgs/python3-execnet/template
@@ -1,9 +1,10 @@
# Template file for 'python3-execnet'
pkgname=python3-execnet
version=1.9.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-setuptools_scm"
+depends="python3"
checkdepends="python3-pytest"
short_desc="Distributed Python deployment and communication"
maintainer="classabbyamp <void@placeviolette.net>"
From 6aaa27f92e0ed30086581ac83382da9b1e47792a Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:54:19 +0530
Subject: [PATCH 08/17] python3-fastjsonschema: add python3 as dep
---
srcpkgs/python3-fastjsonschema/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-fastjsonschema/template b/srcpkgs/python3-fastjsonschema/template
index bd77a036455f..707f9852cb87 100644
--- a/srcpkgs/python3-fastjsonschema/template
+++ b/srcpkgs/python3-fastjsonschema/template
@@ -1,10 +1,11 @@
# Template file for 'python3-fastjsonschema'
pkgname=python3-fastjsonschema
version=2.15.3
-revision=2
+revision=3
build_style=python3-module
make_check_args="--deselect tests/benchmarks/test_benchmark.py"
hostmakedepends="python3-setuptools"
+depends="python3"
checkdepends="python3-pytest"
short_desc="Fastest Python implementation of JSON schema"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
From c54e1b8945801690fd331e2105d08dc001edcb25 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 01:59:15 +0530
Subject: [PATCH 09/17] python3-fpylll: add python3 as dep
---
srcpkgs/python3-fpylll/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-fpylll/template b/srcpkgs/python3-fpylll/template
index 143112ea17ba..817dede1e539 100644
--- a/srcpkgs/python3-fpylll/template
+++ b/srcpkgs/python3-fpylll/template
@@ -1,11 +1,12 @@
# Template file for 'python3-fpylll'
pkgname=python3-fpylll
version=0.5.7
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-Cython"
makedepends="python3-cysignals python3-devel gmp-devel mpfr-devel fplll-devel
pari-devel"
+depends="python3"
checkdepends="python3-pytest python3-numpy"
short_desc="Python wrapper to fplll (floating point lattice algorithms)"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
From ee67309489fdfd2d7ab6bd485c408d8599897d73 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:35:25 +0530
Subject: [PATCH 10/17] python3-jaraco.context: add python3 as dep, fix tests
---
srcpkgs/python3-jaraco.context/template | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-jaraco.context/template b/srcpkgs/python3-jaraco.context/template
index b3959500e5a9..7240e679bf01 100644
--- a/srcpkgs/python3-jaraco.context/template
+++ b/srcpkgs/python3-jaraco.context/template
@@ -1,9 +1,11 @@
# Template file for 'python3-jaraco.context'
pkgname=python3-jaraco.context
version=4.1.1
-revision=2
+revision=3
build_style=python3-pep517
hostmakedepends="python3-wheel python3-setuptools_scm"
+depends="python3"
+checkdepends="python3-pytest"
short_desc="Context managers by jaraco"
maintainer="Orphaned <orphan@voidlinux.org>"
license="MIT"
From 3f87497f2a2d495fad4f4bfbf2b7afe0c9b40e6d Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 16 Nov 2022 02:04:09 +0530
Subject: [PATCH 11/17] python3-logfury: add python3 as dep
---
srcpkgs/python3-logfury/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-logfury/template b/srcpkgs/python3-logfury/template
index 72fd345953e5..6ec34675e3c2 100644
--- a/srcpkgs/python3-logfury/template
+++ b/srcpkgs/python3-logfury/template
@@ -1,9 +1,10 @@
# Template file for 'python3-logfury'
pkgname=python3-logfury
version=1.0.1
-revision=3
+revision=4
build_style=python3-module
hostmakedepends="python3-setuptools_scm"
+depends="python3"
short_desc="Low-boilerplate logging of method calls (Python3)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="BSD-3-Clause"
From 06b0f23e563a9452da73b54514018ca8e0d133db Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:06:47 +0530
Subject: [PATCH 12/17] python3-lrcalc: add python3 as dep
---
srcpkgs/python3-lrcalc/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-lrcalc/template b/srcpkgs/python3-lrcalc/template
index 7be7c4e2be8c..4c52a412d31d 100644
--- a/srcpkgs/python3-lrcalc/template
+++ b/srcpkgs/python3-lrcalc/template
@@ -1,10 +1,11 @@
# Template file for 'python3-lrcalc'
pkgname=python3-lrcalc
version=2.1
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython"
makedepends="python3-devel lrcalc-devel"
+depends="python3"
short_desc="Python bindings for the Littlewood-Richardson Calculator library"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="GPL-3.0-or-later"
From 8a85f5a5f14959c85c2417a791c4ef6cce7a90ee Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:09:11 +0530
Subject: [PATCH 13/17] python3-memory_allocator: add python3 as dep
---
srcpkgs/python3-memory_allocator/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-memory_allocator/template b/srcpkgs/python3-memory_allocator/template
index 71276c4f473e..e9e0808a3cd0 100644
--- a/srcpkgs/python3-memory_allocator/template
+++ b/srcpkgs/python3-memory_allocator/template
@@ -1,10 +1,11 @@
# Template file for 'python3-memory_allocator'
pkgname=python3-memory_allocator
version=0.1.3
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython"
makedepends="python3-devel"
+depends="python3"
short_desc="Extension class to allocate memory easily with cython"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="GPL-3.0-or-later"
From 83ce4e50523b02acf752db49197b57d1c08e4910 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:11:01 +0530
Subject: [PATCH 14/17] python3-pplpy: add python3 as dep, fix tests
---
srcpkgs/python3-pplpy/template | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-pplpy/template b/srcpkgs/python3-pplpy/template
index fdd39c496549..67139ff96031 100644
--- a/srcpkgs/python3-pplpy/template
+++ b/srcpkgs/python3-pplpy/template
@@ -1,11 +1,12 @@
# Template file for 'python3-pplpy'
pkgname=python3-pplpy
version=0.8.7
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython"
makedepends="python3-cysignals python3-gmpy2 python3-devel gmp-devel
gmpxx-devel ppl-devel mpfr-devel libmpc-devel pari-devel"
+depends="python3"
short_desc="Python wrapper to the C++ Parma Polyhedra Library (PPL)"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="GPL-3.0-or-later"
@@ -13,3 +14,7 @@ homepage="https://gitlab.com/videlec/pplpy"
changelog="https://gitlab.com/videlec/pplpy/-/raw/master/CHANGES.txt"
distfiles="${PYPI_SITE}/p/pplpy/pplpy-${version}.tar.gz"
checksum=500bd0f4ae1a76956fae7fcba77854f5ec3e64fce76803664983763c3f2bd8bd
+
+do_check() {
+ PYTHONPATH=$(cd build/lib* && pwd) python3 setup.py test
+}
From df18dc2a99575623224918ec5858438285705026 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:25:43 +0530
Subject: [PATCH 15/17] python3-primecountpy: add python3 as dep
---
srcpkgs/python3-primecountpy/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-primecountpy/template b/srcpkgs/python3-primecountpy/template
index 3f6bdb62fbfc..0cd0b212fb8e 100644
--- a/srcpkgs/python3-primecountpy/template
+++ b/srcpkgs/python3-primecountpy/template
@@ -1,10 +1,11 @@
# Template file for 'python3-primecountpy'
pkgname=python3-primecountpy
version=0.1.0
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools python3-Cython"
makedepends="python3-cysignals python3-devel primecount-devel pari-devel"
+depends="python3"
short_desc="Python interface to the C++ library primecount"
maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="GPL-3.0-or-later"
From e8709c40c9b8999c947b20b9fb857eaa9fa4df33 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:27:19 +0530
Subject: [PATCH 16/17] python3-pycotap: add python3 as dep
---
srcpkgs/python3-pycotap/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-pycotap/template b/srcpkgs/python3-pycotap/template
index c85721f5b31b..fe63eb584b77 100644
--- a/srcpkgs/python3-pycotap/template
+++ b/srcpkgs/python3-pycotap/template
@@ -1,9 +1,10 @@
# Template file for 'python3-pycotap'
pkgname=python3-pycotap
version=1.2.2
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
+depends="python3"
short_desc="Tiny test runner that outputs TAP results to standard output"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-or-later"
From a4e1629b7a36155838c3cf325d78e910e156b394 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 17 Nov 2022 01:30:07 +0530
Subject: [PATCH 17/17] python3-utils: add python3 as dep
---
srcpkgs/python3-utils/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/python3-utils/template b/srcpkgs/python3-utils/template
index 4fec3f5b5aa7..3537bb2ad69e 100644
--- a/srcpkgs/python3-utils/template
+++ b/srcpkgs/python3-utils/template
@@ -1,11 +1,12 @@
# Template file for 'python3-utils'
pkgname=python3-utils
version=3.1.0
-revision=2
+revision=3
build_style=python3-module
# skip coverage and mypy tests https://github.com/WoLpH/python-utils/issues/29
make_check_args="-o addopts=--doctest-modules"
hostmakedepends="python3-setuptools"
+depends="python3"
checkdepends="python3-pytest python3-pytest-asyncio"
short_desc="Convenient utilities not included with the standard Python3 install"
maintainer="Karl Nilsson <karl.robert.nilsson@gmail.com>"
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (21 preceding siblings ...)
2022-12-17 13:25 ` [PR PATCH] [Updated] " icp1994
@ 2022-12-17 17:26 ` tornaria
2022-12-17 19:55 ` paper42
2022-12-18 11:02 ` [PR PATCH] [Merged]: " paper42
24 siblings, 0 replies; 26+ messages in thread
From: tornaria @ 2022-12-17 17:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#issuecomment-1356344330
Comment:
lgtm. I don't now how I missed the tests for python3-pplpy :shrug:
Should these packages be revbumped because of this? Is it worth it? Changing the template the packages will be fixed as they are upgraded (although some packages are slower than others in that regard).
Re: python3-fastjsonschema, there is an update (see #40222).
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (22 preceding siblings ...)
2022-12-17 17:26 ` tornaria
@ 2022-12-17 19:55 ` paper42
2022-12-18 11:02 ` [PR PATCH] [Merged]: " paper42
24 siblings, 0 replies; 26+ messages in thread
From: paper42 @ 2022-12-17 19:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#issuecomment-1356444792
Comment:
> Should these packages be revbumped because of this? Is it worth it? Changing the template the packages will be fixed as they are upgraded (although some packages are slower than others in that regard).
They definitely have to be revbumped, if someone installs one of these packages and they don't have python3 installed yet, they will end up with a broken package. Not revbumping means the package doesn't build, so this would not be fixed until someone revbumps/updates the package.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PR PATCH] [Merged]: srcpkgs: add missing python3 dependency in python3 packages
2022-11-17 10:26 [PR PATCH] srcpkgs: add missing python3 dependency in python3 packages icp1994
` (23 preceding siblings ...)
2022-12-17 19:55 ` paper42
@ 2022-12-18 11:02 ` paper42
24 siblings, 0 replies; 26+ messages in thread
From: paper42 @ 2022-12-18 11:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
There's a merged pull request on the void-packages repository
srcpkgs: add missing python3 dependency in python3 packages
https://github.com/void-linux/void-packages/pull/40569
Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
^ permalink raw reply [flat|nested] 26+ messages in thread