Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: ffcast-2.5.0
@ 2020-12-13 22:47 kawaiiamber
  2020-12-14  8:30 ` paper42
                   ` (14 more replies)
  0 siblings, 15 replies; 16+ messages in thread
From: kawaiiamber @ 2020-12-13 22:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

There is a new pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages ffcast
https://github.com/void-linux/void-packages/pull/27130

New package: ffcast-2.5.0
# About
Adds the package [ffcast](https://github.com/lolilolicon/FFcast).
## Issues
This is my second ever time trying to contribute. I successfully got the source to build and run on my machine, but I don't think I'm using xbps-src or correct template notation to build it as `xbps-src pkg ffcast` seems to fail and I'm not sure why, so it will most likely fail the checks here. I read the manual, and maybe it's a little over me. Any help would be <3

A patch file from https://github.com/void-linux/void-packages/pull/27130.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ffcast-27130.patch --]
[-- Type: text/x-diff, Size: 1201 bytes --]

From 69fb895b0b1402c2a563f715d01fdde57469daa3 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 13 Dec 2020 15:42:48 -0700
Subject: [PATCH] New package: ffcast-2.5.0

---
 srcpkgs/ffcast/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/ffcast/template

diff --git a/srcpkgs/ffcast/template b/srcpkgs/ffcast/template
new file mode 100644
index 00000000000..1ca463151fd
--- /dev/null
+++ b/srcpkgs/ffcast/template
@@ -0,0 +1,23 @@
+# Template file for 'ffcast'
+pkgname=ffcast
+version=2.5.0
+revision=1
+makedepends="autoconf automake"
+depends="bash ffmpeg ImageMagick xdpyinfo xprop xwininfo"
+short_desc="Run command on rectangular screen regions"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/lolilolicon/FFcast"
+distfiles="https://github.com/lolilolicon/FFcast/archive/${version}.tar.gz"
+checksum=09ebf44f76a1813eb8db78df0256f7a1cd259562cf87908b6d683f7fd1ec6b30
+
+do_build() {
+	bootstrap
+	configure --prefix /usr --libexecdir /usr/lib
+	make
+}
+
+do_install() {
+	make install
+	vinstall README.asciidoc 644 usr/share/doc/$pkgname
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
@ 2020-12-14  8:30 ` paper42
  2020-12-14  8:30 ` paper42
                   ` (13 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: paper42 @ 2020-12-14  8:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/27130#issuecomment-744271947

Comment:
The error says:
```
/void-packages/common/xbps-src/shutils/common.sh: line 31: cd: /builddir/ffcast-2.5.0: No such file or directory
=> ERROR: ffcast-2.5.0_1: cannot access wrksrc directory [/builddir/ffcast-2.5.0]
```
when we try looking inside this directory:
```
$ ls masterdir/builddir
FFcast-2.5.0
```
we can see there is no ffcast-2.5.0 directory, there is only **FF**cast-2.5.0. This means we need to tell the build-system to use it. Add `wrksrc=FFcast-${version}`.
The next problem is that you are using command `bootstrap` and `configure`. These are not executables installed in `$PATH`, they are executable files in the current directory which means you have to run them as the README suggests - `./bootstrap` and `./configure`. Now the package should build, but the template is not ideal.

There is no reason to install README.asciidoc, because it only has information about compiling the package.

./configure and make in do_build and make install in do_install is quite common, so we can add `build_style=gnu-configure` which will add basically:
```
do_configure() {
./configure with the correct flags
}
do_build() {
make
}
do_install() {
make install
}
```
We need to make sure we don't rewrite the functions do_build and do_install that build_style provided to us, so we need to move the one remaining command - `./bootstrap` we need to run **before** do_configure to pre_configure.

The last issue I see is that makedepends should be renamed to hostmakedepends.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
  2020-12-14  8:30 ` paper42
@ 2020-12-14  8:30 ` paper42
  2020-12-14 18:17 ` [PR PATCH] [Updated] " kawaiiamber
                   ` (12 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: paper42 @ 2020-12-14  8:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1663 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/27130#issuecomment-744271947

Comment:
The error says:
```
/void-packages/common/xbps-src/shutils/common.sh: line 31: cd: /builddir/ffcast-2.5.0: No such file or directory
=> ERROR: ffcast-2.5.0_1: cannot access wrksrc directory [/builddir/ffcast-2.5.0]
```
when we try looking inside this directory:
```
$ ls masterdir/builddir
FFcast-2.5.0
```
we can see there is no ffcast-2.5.0 directory, there is only **FF**cast-2.5.0. This means we need to tell the build-system to use it. Add `wrksrc=FFcast-${version}`.
The next problem is that you are using command `bootstrap` and `configure`. These are not executables installed in `$PATH`, they are executable files in the current directory which means you have to run them as the README suggests - `./bootstrap` and `./configure`. Now the package should build, but the template is not ideal.

There is no reason to install README.asciidoc, because it only has information about compiling the package.

./configure and make in do_build and make install in do_install is quite common, so we can add `build_style=gnu-configure` which will add basically:
```
do_configure() {
    ./configure with the correct flags
}
do_build() {
    make
}
do_install() {
    make install
}
```
We need to make sure we don't rewrite the functions do_build and do_install that build_style provided to us, so we need to move the one remaining command - `./bootstrap` we need to run **before** do_configure to pre_configure.

The last issue I see is that makedepends should be renamed to hostmakedepends.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
  2020-12-14  8:30 ` paper42
  2020-12-14  8:30 ` paper42
@ 2020-12-14 18:17 ` kawaiiamber
  2020-12-14 18:18 ` kawaiiamber
                   ` (11 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2020-12-14 18:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages ffcast
https://github.com/void-linux/void-packages/pull/27130

New package: ffcast-2.5.0
# About
Adds the package [ffcast](https://github.com/lolilolicon/FFcast).
## Issues
This is my second ever time trying to contribute. I successfully got the source to build and run on my machine, but I don't think I'm using xbps-src or correct template notation to build it as `xbps-src pkg ffcast` seems to fail and I'm not sure why, so it will most likely fail the checks here. I read the manual, and maybe it's a little over me. Any help would be <3

A patch file from https://github.com/void-linux/void-packages/pull/27130.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ffcast-27130.patch --]
[-- Type: text/x-diff, Size: 2538 bytes --]

From 69fb895b0b1402c2a563f715d01fdde57469daa3 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 13 Dec 2020 15:42:48 -0700
Subject: [PATCH 1/2] New package: ffcast-2.5.0

---
 srcpkgs/ffcast/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/ffcast/template

diff --git a/srcpkgs/ffcast/template b/srcpkgs/ffcast/template
new file mode 100644
index 00000000000..1ca463151fd
--- /dev/null
+++ b/srcpkgs/ffcast/template
@@ -0,0 +1,23 @@
+# Template file for 'ffcast'
+pkgname=ffcast
+version=2.5.0
+revision=1
+makedepends="autoconf automake"
+depends="bash ffmpeg ImageMagick xdpyinfo xprop xwininfo"
+short_desc="Run command on rectangular screen regions"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/lolilolicon/FFcast"
+distfiles="https://github.com/lolilolicon/FFcast/archive/${version}.tar.gz"
+checksum=09ebf44f76a1813eb8db78df0256f7a1cd259562cf87908b6d683f7fd1ec6b30
+
+do_build() {
+	bootstrap
+	configure --prefix /usr --libexecdir /usr/lib
+	make
+}
+
+do_install() {
+	make install
+	vinstall README.asciidoc 644 usr/share/doc/$pkgname
+}

From bda5a6e0ba1d1f624936f899b348f0628f16ada1 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Mon, 14 Dec 2020 11:17:19 -0700
Subject: [PATCH 2/2] New package: ffcast-2.5.0

---
 srcpkgs/ffcast/template | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/ffcast/template b/srcpkgs/ffcast/template
index 1ca463151fd..b391a1dfb12 100644
--- a/srcpkgs/ffcast/template
+++ b/srcpkgs/ffcast/template
@@ -2,7 +2,9 @@
 pkgname=ffcast
 version=2.5.0
 revision=1
-makedepends="autoconf automake"
+wrksrc=FFcast-${version}
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
 depends="bash ffmpeg ImageMagick xdpyinfo xprop xwininfo"
 short_desc="Run command on rectangular screen regions"
 maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
@@ -11,13 +13,18 @@ homepage="https://github.com/lolilolicon/FFcast"
 distfiles="https://github.com/lolilolicon/FFcast/archive/${version}.tar.gz"
 checksum=09ebf44f76a1813eb8db78df0256f7a1cd259562cf87908b6d683f7fd1ec6b30
 
+pre_configure() {
+	./bootstrap
+}
+
+do_configure() {
+	./configure --prefix /usr --libexecdir /usr/lib
+}
+
 do_build() {
-	bootstrap
-	configure --prefix /usr --libexecdir /usr/lib
 	make
 }
 
 do_install() {
 	make install
-	vinstall README.asciidoc 644 usr/share/doc/$pkgname
 }

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
                   ` (2 preceding siblings ...)
  2020-12-14 18:17 ` [PR PATCH] [Updated] " kawaiiamber
@ 2020-12-14 18:18 ` kawaiiamber
  2020-12-14 18:19 ` kawaiiamber
                   ` (10 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2020-12-14 18:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages ffcast
https://github.com/void-linux/void-packages/pull/27130

New package: ffcast-2.5.0
# About
Adds the package [ffcast](https://github.com/lolilolicon/FFcast).
## Issues
This is my second ever time trying to contribute. I successfully got the source to build and run on my machine, but I don't think I'm using xbps-src or correct template notation to build it as `xbps-src pkg ffcast` seems to fail and I'm not sure why, so it will most likely fail the checks here. I read the manual, and maybe it's a little over me. Any help would be <3

A patch file from https://github.com/void-linux/void-packages/pull/27130.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ffcast-27130.patch --]
[-- Type: text/x-diff, Size: 1288 bytes --]

From daac97df101675bfbbfd0db8c422a66b4bc53bbb Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 13 Dec 2020 15:42:48 -0700
Subject: [PATCH] New package: ffcast-2.5.0

New package: ffcast-2.5.0
---
 srcpkgs/ffcast/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/ffcast/template

diff --git a/srcpkgs/ffcast/template b/srcpkgs/ffcast/template
new file mode 100644
index 00000000000..b391a1dfb12
--- /dev/null
+++ b/srcpkgs/ffcast/template
@@ -0,0 +1,30 @@
+# Template file for 'ffcast'
+pkgname=ffcast
+version=2.5.0
+revision=1
+wrksrc=FFcast-${version}
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+depends="bash ffmpeg ImageMagick xdpyinfo xprop xwininfo"
+short_desc="Run command on rectangular screen regions"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/lolilolicon/FFcast"
+distfiles="https://github.com/lolilolicon/FFcast/archive/${version}.tar.gz"
+checksum=09ebf44f76a1813eb8db78df0256f7a1cd259562cf87908b6d683f7fd1ec6b30
+
+pre_configure() {
+	./bootstrap
+}
+
+do_configure() {
+	./configure --prefix /usr --libexecdir /usr/lib
+}
+
+do_build() {
+	make
+}
+
+do_install() {
+	make install
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
                   ` (3 preceding siblings ...)
  2020-12-14 18:18 ` kawaiiamber
@ 2020-12-14 18:19 ` kawaiiamber
  2020-12-14 18:27 ` [PR REVIEW] " ericonr
                   ` (9 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2020-12-14 18:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/27130#issuecomment-744621191

Comment:
Okay, I think I implemented the changes as desired. Sorry for the delay. Thank you so so so much. <3

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
                   ` (4 preceding siblings ...)
  2020-12-14 18:19 ` kawaiiamber
@ 2020-12-14 18:27 ` ericonr
  2020-12-14 18:29 ` [PR PATCH] [Updated] " kawaiiamber
                   ` (8 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2020-12-14 18:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27130#discussion_r542612772

Comment:
You don't need (or want) these. Just let the build style do its thing.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
                   ` (5 preceding siblings ...)
  2020-12-14 18:27 ` [PR REVIEW] " ericonr
@ 2020-12-14 18:29 ` kawaiiamber
  2020-12-14 18:29 ` kawaiiamber
                   ` (7 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2020-12-14 18:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages ffcast
https://github.com/void-linux/void-packages/pull/27130

New package: ffcast-2.5.0
# About
Adds the package [ffcast](https://github.com/lolilolicon/FFcast).
## Issues
This is my second ever time trying to contribute. I successfully got the source to build and run on my machine, but I don't think I'm using xbps-src or correct template notation to build it as `xbps-src pkg ffcast` seems to fail and I'm not sure why, so it will most likely fail the checks here. I read the manual, and maybe it's a little over me. Any help would be <3

A patch file from https://github.com/void-linux/void-packages/pull/27130.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ffcast-27130.patch --]
[-- Type: text/x-diff, Size: 2006 bytes --]

From daac97df101675bfbbfd0db8c422a66b4bc53bbb Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 13 Dec 2020 15:42:48 -0700
Subject: [PATCH 1/2] New package: ffcast-2.5.0

New package: ffcast-2.5.0
---
 srcpkgs/ffcast/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/ffcast/template

diff --git a/srcpkgs/ffcast/template b/srcpkgs/ffcast/template
new file mode 100644
index 00000000000..b391a1dfb12
--- /dev/null
+++ b/srcpkgs/ffcast/template
@@ -0,0 +1,30 @@
+# Template file for 'ffcast'
+pkgname=ffcast
+version=2.5.0
+revision=1
+wrksrc=FFcast-${version}
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+depends="bash ffmpeg ImageMagick xdpyinfo xprop xwininfo"
+short_desc="Run command on rectangular screen regions"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/lolilolicon/FFcast"
+distfiles="https://github.com/lolilolicon/FFcast/archive/${version}.tar.gz"
+checksum=09ebf44f76a1813eb8db78df0256f7a1cd259562cf87908b6d683f7fd1ec6b30
+
+pre_configure() {
+	./bootstrap
+}
+
+do_configure() {
+	./configure --prefix /usr --libexecdir /usr/lib
+}
+
+do_build() {
+	make
+}
+
+do_install() {
+	make install
+}

From 1a726f51c8c912690f485eb93c76fd4f99c175a4 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Mon, 14 Dec 2020 11:28:45 -0700
Subject: [PATCH 2/2] New package: ffcast-2.5.0

---
 srcpkgs/ffcast/template | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/srcpkgs/ffcast/template b/srcpkgs/ffcast/template
index b391a1dfb12..9db55a7ce0a 100644
--- a/srcpkgs/ffcast/template
+++ b/srcpkgs/ffcast/template
@@ -16,15 +16,3 @@ checksum=09ebf44f76a1813eb8db78df0256f7a1cd259562cf87908b6d683f7fd1ec6b30
 pre_configure() {
 	./bootstrap
 }
-
-do_configure() {
-	./configure --prefix /usr --libexecdir /usr/lib
-}
-
-do_build() {
-	make
-}
-
-do_install() {
-	make install
-}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
                   ` (6 preceding siblings ...)
  2020-12-14 18:29 ` [PR PATCH] [Updated] " kawaiiamber
@ 2020-12-14 18:29 ` kawaiiamber
  2020-12-14 18:30 ` [PR REVIEW] " kawaiiamber
                   ` (6 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2020-12-14 18:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages ffcast
https://github.com/void-linux/void-packages/pull/27130

New package: ffcast-2.5.0
# About
Adds the package [ffcast](https://github.com/lolilolicon/FFcast).
## Issues
This is my second ever time trying to contribute. I successfully got the source to build and run on my machine, but I don't think I'm using xbps-src or correct template notation to build it as `xbps-src pkg ffcast` seems to fail and I'm not sure why, so it will most likely fail the checks here. I read the manual, and maybe it's a little over me. Any help would be <3

A patch file from https://github.com/void-linux/void-packages/pull/27130.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ffcast-27130.patch --]
[-- Type: text/x-diff, Size: 1141 bytes --]

From 832cecd43e8031566db6550ee8fa49c177e98874 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 13 Dec 2020 15:42:48 -0700
Subject: [PATCH] New package: ffcast-2.5.0

New package: ffcast-2.5.0
---
 srcpkgs/ffcast/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/ffcast/template

diff --git a/srcpkgs/ffcast/template b/srcpkgs/ffcast/template
new file mode 100644
index 00000000000..9db55a7ce0a
--- /dev/null
+++ b/srcpkgs/ffcast/template
@@ -0,0 +1,18 @@
+# Template file for 'ffcast'
+pkgname=ffcast
+version=2.5.0
+revision=1
+wrksrc=FFcast-${version}
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+depends="bash ffmpeg ImageMagick xdpyinfo xprop xwininfo"
+short_desc="Run command on rectangular screen regions"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/lolilolicon/FFcast"
+distfiles="https://github.com/lolilolicon/FFcast/archive/${version}.tar.gz"
+checksum=09ebf44f76a1813eb8db78df0256f7a1cd259562cf87908b6d683f7fd1ec6b30
+
+pre_configure() {
+	./bootstrap
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
                   ` (7 preceding siblings ...)
  2020-12-14 18:29 ` kawaiiamber
@ 2020-12-14 18:30 ` kawaiiamber
  2020-12-14 18:36 ` ericonr
                   ` (5 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2020-12-14 18:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New review comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/27130#discussion_r542616264

Comment:
Sorry about that. I have removed those lines. Thank you very much.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
                   ` (8 preceding siblings ...)
  2020-12-14 18:30 ` [PR REVIEW] " kawaiiamber
@ 2020-12-14 18:36 ` ericonr
  2020-12-14 18:39 ` kawaiiamber
                   ` (4 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2020-12-14 18:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27130#issuecomment-744630506

Comment:
You probably need to disable the xrectsel functionality in `configure_args`. But idk how useful the program is without it...

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
                   ` (9 preceding siblings ...)
  2020-12-14 18:36 ` ericonr
@ 2020-12-14 18:39 ` kawaiiamber
  2020-12-14 23:21 ` [PR PATCH] [Updated] " kawaiiamber
                   ` (3 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2020-12-14 18:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/27130#issuecomment-744632435

Comment:
How would I do that?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
                   ` (10 preceding siblings ...)
  2020-12-14 18:39 ` kawaiiamber
@ 2020-12-14 23:21 ` kawaiiamber
  2020-12-14 23:22 ` kawaiiamber
                   ` (2 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2020-12-14 23:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages ffcast
https://github.com/void-linux/void-packages/pull/27130

New package: ffcast-2.5.0
# About
Adds the package [ffcast](https://github.com/lolilolicon/FFcast).
## Issues
This is my second ever time trying to contribute. I successfully got the source to build and run on my machine, but I don't think I'm using xbps-src or correct template notation to build it as `xbps-src pkg ffcast` seems to fail and I'm not sure why, so it will most likely fail the checks here. I read the manual, and maybe it's a little over me. Any help would be <3

A patch file from https://github.com/void-linux/void-packages/pull/27130.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ffcast-27130.patch --]
[-- Type: text/x-diff, Size: 1175 bytes --]

From c572b68debf54ae179883f80aa136c363c910747 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 13 Dec 2020 15:42:48 -0700
Subject: [PATCH] New package: ffcast-2.5.0

New package: ffcast-2.5.0
---
 srcpkgs/ffcast/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/ffcast/template

diff --git a/srcpkgs/ffcast/template b/srcpkgs/ffcast/template
new file mode 100644
index 00000000000..f362a494c0e
--- /dev/null
+++ b/srcpkgs/ffcast/template
@@ -0,0 +1,19 @@
+# Template file for 'ffcast'
+pkgname=ffcast
+version=2.5.0
+revision=1
+archs="x86_64 i686 x86_64-musl"
+wrksrc=FFcast-${version}
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+depends="bash ffmpeg ImageMagick xdpyinfo xprop xwininfo"
+short_desc="Run command on rectangular screen regions"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/lolilolicon/FFcast"
+distfiles="https://github.com/lolilolicon/FFcast/archive/${version}.tar.gz"
+checksum=09ebf44f76a1813eb8db78df0256f7a1cd259562cf87908b6d683f7fd1ec6b30
+
+pre_configure() {
+	./bootstrap
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
                   ` (11 preceding siblings ...)
  2020-12-14 23:21 ` [PR PATCH] [Updated] " kawaiiamber
@ 2020-12-14 23:22 ` kawaiiamber
  2021-04-18 21:57 ` ericonr
  2021-04-18 21:57 ` [PR PATCH] [Closed]: " ericonr
  14 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2020-12-14 23:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/27130#issuecomment-744789689

Comment:
Updated archs and, for now, doesn't include `xrectsel` build option.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
                   ` (12 preceding siblings ...)
  2020-12-14 23:22 ` kawaiiamber
@ 2021-04-18 21:57 ` ericonr
  2021-04-18 21:57 ` [PR PATCH] [Closed]: " ericonr
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-04-18 21:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27130#issuecomment-822068361

Comment:
This seems to be mostly a user installable shell script, and the only reason it needs to be "compiled" is that they want to embed version information in it...

Will close for now, though I'm open to changing my mind.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Closed]: New package: ffcast-2.5.0
  2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
                   ` (13 preceding siblings ...)
  2021-04-18 21:57 ` ericonr
@ 2021-04-18 21:57 ` ericonr
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-04-18 21:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

There's a closed pull request on the void-packages repository

New package: ffcast-2.5.0
https://github.com/void-linux/void-packages/pull/27130

Description:
# About
Adds the package [ffcast](https://github.com/lolilolicon/FFcast).
## Issues
This is my second ever time trying to contribute. I successfully got the source to build and run on my machine, but I don't think I'm using xbps-src or correct template notation to build it as `xbps-src pkg ffcast` seems to fail and I'm not sure why, so it will most likely fail the checks here. I read the manual, and maybe it's a little over me. Any help would be <3

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2021-04-18 21:57 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-13 22:47 [PR PATCH] New package: ffcast-2.5.0 kawaiiamber
2020-12-14  8:30 ` paper42
2020-12-14  8:30 ` paper42
2020-12-14 18:17 ` [PR PATCH] [Updated] " kawaiiamber
2020-12-14 18:18 ` kawaiiamber
2020-12-14 18:19 ` kawaiiamber
2020-12-14 18:27 ` [PR REVIEW] " ericonr
2020-12-14 18:29 ` [PR PATCH] [Updated] " kawaiiamber
2020-12-14 18:29 ` kawaiiamber
2020-12-14 18:30 ` [PR REVIEW] " kawaiiamber
2020-12-14 18:36 ` ericonr
2020-12-14 18:39 ` kawaiiamber
2020-12-14 23:21 ` [PR PATCH] [Updated] " kawaiiamber
2020-12-14 23:22 ` kawaiiamber
2021-04-18 21:57 ` ericonr
2021-04-18 21:57 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).