Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] pulseaudio: remove rtkit dependency.
@ 2021-02-15  2:23 ericonr
  2021-02-15  4:46 ` [PR PATCH] [Updated] " ericonr
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: ericonr @ 2021-02-15  2:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages pulse
https://github.com/void-linux/void-packages/pull/28771

pulseaudio: remove rtkit dependency.
PulseAudio doesn't need rtkit available to work for basic usage, so
it's better to only pull it in when a user wants realtime (the error
messages should also be clear enough).

Since rtkit now pulls in a complex dependency in polkit, we can avoid
pulseaudio also pulling the whole thing in.

I have yet to test this adequately.

@q66

A patch file from https://github.com/void-linux/void-packages/pull/28771.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulse-28771.patch --]
[-- Type: text/x-diff, Size: 1496 bytes --]

From 123bb8173c804b9291e4d81a4f62b8cb44ef6f4c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 14 Feb 2021 23:21:17 -0300
Subject: [PATCH] pulseaudio: remove rtkit dependency.

PulseAudio doesn't need rtkit available to work for basic usage, so
it's better to only pull it in when a user wants realtime (the error
messages should also be clear enough).

Since rtkit now pulls in a complex dependency in polkit, we can avoid
pulseaudio also pulling the whole thing in.
---
 srcpkgs/pulseaudio/template | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/pulseaudio/template b/srcpkgs/pulseaudio/template
index d54b9c5ba69..ca71b65cadf 100644
--- a/srcpkgs/pulseaudio/template
+++ b/srcpkgs/pulseaudio/template
@@ -1,7 +1,7 @@
 # Template file for 'pulseaudio'
 pkgname=pulseaudio
 version=14.0
-revision=3
+revision=4
 build_style=meson
 configure_args="-Djack=enabled -Dlirc=disabled -Dhal-compat=false -Dorc=enabled
  -Dgtk=disabled -Dsystemd=disabled -Dwebrtc-aec=enabled
@@ -14,7 +14,6 @@ makedepends="$(vopt_if avahi avahi-libs-devel) eudev-libudev-devel fftw-devel ja
  libcap-devel libcap-progs libglib-devel libltdl-devel libressl-devel
  libsndfile-devel libsoxr-devel orc-devel sbc-devel speex-devel tdb-devel
  webrtc-audio-processing-devel xcb-util-devel check-devel"
-depends="rtkit"
 conf_files="/etc/pulse/*"
 short_desc="Featureful, general-purpose sound server"
 maintainer="Orphaned <orphan@voidlinux.org>"

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] pulseaudio: remove rtkit dependency.
  2021-02-15  2:23 [PR PATCH] pulseaudio: remove rtkit dependency ericonr
@ 2021-02-15  4:46 ` ericonr
  2021-02-15  4:48 ` [PR PATCH] [Updated] pulseaudio: remove rtkit dependency and update to 14.2 ericonr
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-02-15  4:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages pulse
https://github.com/void-linux/void-packages/pull/28771

pulseaudio: remove rtkit dependency.
PulseAudio doesn't need rtkit available to work for basic usage, so
it's better to only pull it in when a user wants realtime (the error
messages should also be clear enough).

Since rtkit now pulls in a complex dependency in polkit, we can avoid
pulseaudio also pulling the whole thing in.

I have yet to test this throroughly. Basic functionality is fine.

@q66

A patch file from https://github.com/void-linux/void-packages/pull/28771.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulse-28771.patch --]
[-- Type: text/x-diff, Size: 2879 bytes --]

From 51224ebdfe44a6cf18db7c26dd89ae8eba6d3634 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 14 Feb 2021 23:21:17 -0300
Subject: [PATCH] pulseaudio: update to 14.2.

Also remove rtkit dependency:

   PulseAudio doesn't need rtkit available to work for basic usage, so
   it's better to only pull it in when a user wants realtime (the error
   messages should also be clear enough).

   Since rtkit now pulls in a complex dependency in polkit, we can avoid
   pulseaudio also pulling the whole thing in.

Add comments about elogind and unit tests.

Closes: #27973 [via git-merge-pr]
---
 common/shlibs               |  4 ++--
 srcpkgs/pulseaudio/template | 11 +++++++----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index fda9284996c..8d32c3af15c 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -731,8 +731,8 @@ libasyncns.so.0 libasyncns-0.8_1
 libpulse.so.0 libpulseaudio-1.0_1
 libpulse-mainloop-glib.so.0 libpulseaudio-1.0_1
 libpulse-simple.so.0 libpulseaudio-1.0_1
-libpulsecommon-14.0.so libpulseaudio-14.0_1
-libpulsecore-14.0.so libpulseaudio-14.0_1
+libpulsecommon-14.2.so libpulseaudio-14.2_1
+libpulsecore-14.2.so libpulseaudio-14.2_1
 libprojectM.so.3 projectM-3.1.7_2
 liborc-0.4.so.0 orc-0.4.11_1
 liborc-test-0.4.so.0 orc-0.4.11_1
diff --git a/srcpkgs/pulseaudio/template b/srcpkgs/pulseaudio/template
index d54b9c5ba69..c21c39dffca 100644
--- a/srcpkgs/pulseaudio/template
+++ b/srcpkgs/pulseaudio/template
@@ -1,8 +1,9 @@
 # Template file for 'pulseaudio'
 pkgname=pulseaudio
-version=14.0
-revision=3
+version=14.2
+revision=1
 build_style=meson
+# XXX: new version should be able to enable systemd functionality using elogind
 configure_args="-Djack=enabled -Dlirc=disabled -Dhal-compat=false -Dorc=enabled
  -Dgtk=disabled -Dsystemd=disabled -Dwebrtc-aec=enabled
  -Dbluez5=true -Dbluez5-ofono-headset=false -Dbluez5-native-headset=true
@@ -14,15 +15,17 @@ makedepends="$(vopt_if avahi avahi-libs-devel) eudev-libudev-devel fftw-devel ja
  libcap-devel libcap-progs libglib-devel libltdl-devel libressl-devel
  libsndfile-devel libsoxr-devel orc-devel sbc-devel speex-devel tdb-devel
  webrtc-audio-processing-devel xcb-util-devel check-devel"
-depends="rtkit"
 conf_files="/etc/pulse/*"
 short_desc="Featureful, general-purpose sound server"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://www.freedesktop.org/wiki/Software/PulseAudio"
 distfiles="${FREEDESKTOP_SITE}/${pkgname}/releases/${pkgname}-${version}.tar.xz"
-checksum=a834775d9382b055504e5ee7625dc50768daac29329531deb6597bf05e06c261
+checksum=75d3f7742c1ae449049a4c88900e454b8b350ecaa8c544f3488a2562a9ff66f1
 python_version=3
+# FIXME: core-util-test fails
+make_check=yes
+
 system_groups="pulse-access"
 system_accounts="pulse"
 pulse_groups="audio"

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] pulseaudio: remove rtkit dependency and update to 14.2
  2021-02-15  2:23 [PR PATCH] pulseaudio: remove rtkit dependency ericonr
  2021-02-15  4:46 ` [PR PATCH] [Updated] " ericonr
@ 2021-02-15  4:48 ` ericonr
  2021-02-15  4:49 ` ericonr
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-02-15  4:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages pulse
https://github.com/void-linux/void-packages/pull/28771

pulseaudio: remove rtkit dependency and update to 14.2
PulseAudio doesn't need rtkit available to work for basic usage, so
it's better to only pull it in when a user wants realtime (the error
messages should also be clear enough).

Since rtkit now pulls in a complex dependency in polkit, we can avoid
pulseaudio also pulling the whole thing in.

I have yet to test this throroughly. Basic functionality is fine.

@q66

A patch file from https://github.com/void-linux/void-packages/pull/28771.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulse-28771.patch --]
[-- Type: text/x-diff, Size: 3672 bytes --]

From 51224ebdfe44a6cf18db7c26dd89ae8eba6d3634 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 14 Feb 2021 23:21:17 -0300
Subject: [PATCH 1/2] pulseaudio: update to 14.2.

Also remove rtkit dependency:

   PulseAudio doesn't need rtkit available to work for basic usage, so
   it's better to only pull it in when a user wants realtime (the error
   messages should also be clear enough).

   Since rtkit now pulls in a complex dependency in polkit, we can avoid
   pulseaudio also pulling the whole thing in.

Add comments about elogind and unit tests.

Closes: #27973 [via git-merge-pr]
---
 common/shlibs               |  4 ++--
 srcpkgs/pulseaudio/template | 11 +++++++----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index fda9284996c..8d32c3af15c 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -731,8 +731,8 @@ libasyncns.so.0 libasyncns-0.8_1
 libpulse.so.0 libpulseaudio-1.0_1
 libpulse-mainloop-glib.so.0 libpulseaudio-1.0_1
 libpulse-simple.so.0 libpulseaudio-1.0_1
-libpulsecommon-14.0.so libpulseaudio-14.0_1
-libpulsecore-14.0.so libpulseaudio-14.0_1
+libpulsecommon-14.2.so libpulseaudio-14.2_1
+libpulsecore-14.2.so libpulseaudio-14.2_1
 libprojectM.so.3 projectM-3.1.7_2
 liborc-0.4.so.0 orc-0.4.11_1
 liborc-test-0.4.so.0 orc-0.4.11_1
diff --git a/srcpkgs/pulseaudio/template b/srcpkgs/pulseaudio/template
index d54b9c5ba69..c21c39dffca 100644
--- a/srcpkgs/pulseaudio/template
+++ b/srcpkgs/pulseaudio/template
@@ -1,8 +1,9 @@
 # Template file for 'pulseaudio'
 pkgname=pulseaudio
-version=14.0
-revision=3
+version=14.2
+revision=1
 build_style=meson
+# XXX: new version should be able to enable systemd functionality using elogind
 configure_args="-Djack=enabled -Dlirc=disabled -Dhal-compat=false -Dorc=enabled
  -Dgtk=disabled -Dsystemd=disabled -Dwebrtc-aec=enabled
  -Dbluez5=true -Dbluez5-ofono-headset=false -Dbluez5-native-headset=true
@@ -14,15 +15,17 @@ makedepends="$(vopt_if avahi avahi-libs-devel) eudev-libudev-devel fftw-devel ja
  libcap-devel libcap-progs libglib-devel libltdl-devel libressl-devel
  libsndfile-devel libsoxr-devel orc-devel sbc-devel speex-devel tdb-devel
  webrtc-audio-processing-devel xcb-util-devel check-devel"
-depends="rtkit"
 conf_files="/etc/pulse/*"
 short_desc="Featureful, general-purpose sound server"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://www.freedesktop.org/wiki/Software/PulseAudio"
 distfiles="${FREEDESKTOP_SITE}/${pkgname}/releases/${pkgname}-${version}.tar.xz"
-checksum=a834775d9382b055504e5ee7625dc50768daac29329531deb6597bf05e06c261
+checksum=75d3f7742c1ae449049a4c88900e454b8b350ecaa8c544f3488a2562a9ff66f1
 python_version=3
+# FIXME: core-util-test fails
+make_check=yes
+
 system_groups="pulse-access"
 system_accounts="pulse"
 pulse_groups="audio"

From 5863cf249ddf9c21f4b3c7606625b70bcb00cbb4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 15 Feb 2021 01:47:15 -0300
Subject: [PATCH 2/2] pulseaudio-module-sndio: revbump for pulseaudio.

---
 srcpkgs/pulseaudio-module-sndio/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/pulseaudio-module-sndio/template b/srcpkgs/pulseaudio-module-sndio/template
index b43a0b40b4d..7b261e7ae06 100644
--- a/srcpkgs/pulseaudio-module-sndio/template
+++ b/srcpkgs/pulseaudio-module-sndio/template
@@ -1,7 +1,7 @@
 # Template file for 'pulseaudio-module-sndio'
 pkgname=pulseaudio-module-sndio
 version=13.0
-revision=2
+revision=3
 build_style=gnu-makefile
 make_use_env=yes
 hostmakedepends="pulseaudio pkg-config"

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] pulseaudio: remove rtkit dependency and update to 14.2
  2021-02-15  2:23 [PR PATCH] pulseaudio: remove rtkit dependency ericonr
  2021-02-15  4:46 ` [PR PATCH] [Updated] " ericonr
  2021-02-15  4:48 ` [PR PATCH] [Updated] pulseaudio: remove rtkit dependency and update to 14.2 ericonr
@ 2021-02-15  4:49 ` ericonr
  2021-02-15  8:30 ` q66
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-02-15  4:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages pulse
https://github.com/void-linux/void-packages/pull/28771

pulseaudio: remove rtkit dependency and update to 14.2
PulseAudio doesn't need rtkit available to work for basic usage, so
it's better to only pull it in when a user wants realtime (the error
messages should also be clear enough).

Since rtkit now pulls in a complex dependency in polkit, we can avoid
pulseaudio also pulling the whole thing in.

I have yet to test this throroughly. Basic functionality is fine.

@q66

A patch file from https://github.com/void-linux/void-packages/pull/28771.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulse-28771.patch --]
[-- Type: text/x-diff, Size: 3740 bytes --]

From 6624868eaf3e74760c565500391838f4bf157618 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 14 Feb 2021 23:21:17 -0300
Subject: [PATCH 1/2] pulseaudio: update to 14.2.

Also remove rtkit dependency:

   PulseAudio doesn't need rtkit available to work for basic usage, so
   it's better to only pull it in when a user wants realtime (the error
   messages should also be clear enough).

   Since rtkit now pulls in a complex dependency in polkit, we can avoid
   pulseaudio also pulling the whole thing in.

Add comments about elogind and unit tests.

Closes: #27973 [via git-merge-pr]

Co-authored-by: UsernameRandomlyGenerated <coredavid@tutanota.com>
---
 common/shlibs               |  4 ++--
 srcpkgs/pulseaudio/template | 11 +++++++----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index fda9284996c..8d32c3af15c 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -731,8 +731,8 @@ libasyncns.so.0 libasyncns-0.8_1
 libpulse.so.0 libpulseaudio-1.0_1
 libpulse-mainloop-glib.so.0 libpulseaudio-1.0_1
 libpulse-simple.so.0 libpulseaudio-1.0_1
-libpulsecommon-14.0.so libpulseaudio-14.0_1
-libpulsecore-14.0.so libpulseaudio-14.0_1
+libpulsecommon-14.2.so libpulseaudio-14.2_1
+libpulsecore-14.2.so libpulseaudio-14.2_1
 libprojectM.so.3 projectM-3.1.7_2
 liborc-0.4.so.0 orc-0.4.11_1
 liborc-test-0.4.so.0 orc-0.4.11_1
diff --git a/srcpkgs/pulseaudio/template b/srcpkgs/pulseaudio/template
index d54b9c5ba69..c21c39dffca 100644
--- a/srcpkgs/pulseaudio/template
+++ b/srcpkgs/pulseaudio/template
@@ -1,8 +1,9 @@
 # Template file for 'pulseaudio'
 pkgname=pulseaudio
-version=14.0
-revision=3
+version=14.2
+revision=1
 build_style=meson
+# XXX: new version should be able to enable systemd functionality using elogind
 configure_args="-Djack=enabled -Dlirc=disabled -Dhal-compat=false -Dorc=enabled
  -Dgtk=disabled -Dsystemd=disabled -Dwebrtc-aec=enabled
  -Dbluez5=true -Dbluez5-ofono-headset=false -Dbluez5-native-headset=true
@@ -14,15 +15,17 @@ makedepends="$(vopt_if avahi avahi-libs-devel) eudev-libudev-devel fftw-devel ja
  libcap-devel libcap-progs libglib-devel libltdl-devel libressl-devel
  libsndfile-devel libsoxr-devel orc-devel sbc-devel speex-devel tdb-devel
  webrtc-audio-processing-devel xcb-util-devel check-devel"
-depends="rtkit"
 conf_files="/etc/pulse/*"
 short_desc="Featureful, general-purpose sound server"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://www.freedesktop.org/wiki/Software/PulseAudio"
 distfiles="${FREEDESKTOP_SITE}/${pkgname}/releases/${pkgname}-${version}.tar.xz"
-checksum=a834775d9382b055504e5ee7625dc50768daac29329531deb6597bf05e06c261
+checksum=75d3f7742c1ae449049a4c88900e454b8b350ecaa8c544f3488a2562a9ff66f1
 python_version=3
+# FIXME: core-util-test fails
+make_check=yes
+
 system_groups="pulse-access"
 system_accounts="pulse"
 pulse_groups="audio"

From 1b379e98f4caa426e0096a0957bc89c54fa64e1a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 15 Feb 2021 01:47:15 -0300
Subject: [PATCH 2/2] pulseaudio-module-sndio: revbump for pulseaudio.

---
 srcpkgs/pulseaudio-module-sndio/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/pulseaudio-module-sndio/template b/srcpkgs/pulseaudio-module-sndio/template
index b43a0b40b4d..7b261e7ae06 100644
--- a/srcpkgs/pulseaudio-module-sndio/template
+++ b/srcpkgs/pulseaudio-module-sndio/template
@@ -1,7 +1,7 @@
 # Template file for 'pulseaudio-module-sndio'
 pkgname=pulseaudio-module-sndio
 version=13.0
-revision=2
+revision=3
 build_style=gnu-makefile
 make_use_env=yes
 hostmakedepends="pulseaudio pkg-config"

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: pulseaudio: remove rtkit dependency and update to 14.2
  2021-02-15  2:23 [PR PATCH] pulseaudio: remove rtkit dependency ericonr
                   ` (2 preceding siblings ...)
  2021-02-15  4:49 ` ericonr
@ 2021-02-15  8:30 ` q66
  2021-02-16  9:56 ` fosslinux
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: q66 @ 2021-02-15  8:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/28771#issuecomment-779050173

Comment:
no, not really

this will just result in 1) people not knowing what to install when they need it 2) rtkit becoming an orphan and getting autoremoved on existing systems

you just shouldn't have added polkit dependency in rtkit in the first place 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: pulseaudio: remove rtkit dependency and update to 14.2
  2021-02-15  2:23 [PR PATCH] pulseaudio: remove rtkit dependency ericonr
                   ` (3 preceding siblings ...)
  2021-02-15  8:30 ` q66
@ 2021-02-16  9:56 ` fosslinux
  2021-02-16  9:58 ` fosslinux
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: fosslinux @ 2021-02-16  9:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/28771#issuecomment-779721509

Comment:
Why not, https://github.com/heftig/rtkit/blob/master/README#L226 says it is needed (is upstream just wrong about requirements for their own software (wouldn't be the first time lol))

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: pulseaudio: remove rtkit dependency and update to 14.2
  2021-02-15  2:23 [PR PATCH] pulseaudio: remove rtkit dependency ericonr
                   ` (4 preceding siblings ...)
  2021-02-16  9:56 ` fosslinux
@ 2021-02-16  9:58 ` fosslinux
  2021-02-16 18:52 ` ericonr
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: fosslinux @ 2021-02-16  9:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/28771#issuecomment-779721509

Comment:
Why not, https://github.com/heftig/rtkit/blob/master/README#L226 says it is needed (is upstream just wrong about requirements for their own software (wouldn't be the first time lol))

hm, but https://github.com/heftig/rtkit/blob/c295fa849f52b487be6433e69e08b46251950399/meson.build#L21 says that it is optional.


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: pulseaudio: remove rtkit dependency and update to 14.2
  2021-02-15  2:23 [PR PATCH] pulseaudio: remove rtkit dependency ericonr
                   ` (5 preceding siblings ...)
  2021-02-16  9:58 ` fosslinux
@ 2021-02-16 18:52 ` ericonr
  2021-02-16 18:53 ` ericonr
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-02-16 18:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28771#issuecomment-780046267

Comment:
@fosslinux it's optional only because they can use it to determine where to dump the polkit config file https://github.com/heftig/rtkit/blob/c295fa849f52b487be6433e69e08b46251950399/meson.build#L53

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: pulseaudio: remove rtkit dependency and update to 14.2
  2021-02-15  2:23 [PR PATCH] pulseaudio: remove rtkit dependency ericonr
                   ` (6 preceding siblings ...)
  2021-02-16 18:52 ` ericonr
@ 2021-02-16 18:53 ` ericonr
  2021-02-16 19:26 ` [PR PATCH] [Updated] " ericonr
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-02-16 18:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28771#issuecomment-780046267

Comment:
@fosslinux it's optional only because they can use it to determine where to dump the polkit config file https://github.com/heftig/rtkit/blob/c295fa849f52b487be6433e69e08b46251950399/meson.build#L53 , otherwise they have a fallback. And this is at build time, not at runtime (you shouldn't check for runtime dependencies like that at build time, after all).

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] pulseaudio: remove rtkit dependency and update to 14.2
  2021-02-15  2:23 [PR PATCH] pulseaudio: remove rtkit dependency ericonr
                   ` (7 preceding siblings ...)
  2021-02-16 18:53 ` ericonr
@ 2021-02-16 19:26 ` ericonr
  2021-02-16 19:28 ` [PR PATCH] [Merged]: " ericonr
  2021-02-17  4:51 ` fosslinux
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-02-16 19:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages pulse
https://github.com/void-linux/void-packages/pull/28771

pulseaudio: remove rtkit dependency and update to 14.2
PulseAudio doesn't need rtkit available to work for basic usage, so
it's better to only pull it in when a user wants realtime (the error
messages should also be clear enough).

Since rtkit now pulls in a complex dependency in polkit, we can avoid
pulseaudio also pulling the whole thing in.

I have yet to test this throroughly. Basic functionality is fine.

@q66

A patch file from https://github.com/void-linux/void-packages/pull/28771.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulse-28771.patch --]
[-- Type: text/x-diff, Size: 3013 bytes --]

From 51447d1608993401946c6c91e6be5833d9bbf415 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 14 Feb 2021 23:21:17 -0300
Subject: [PATCH 1/2] pulseaudio: update to 14.2.

Add comments about elogind and unit tests.

Closes: #27973 [via git-merge-pr]

Co-authored-by: UsernameRandomlyGenerated <coredavid@tutanota.com>
---
 common/shlibs               |  4 ++--
 srcpkgs/pulseaudio/template | 10 +++++++---
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index fda9284996c..8d32c3af15c 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -731,8 +731,8 @@ libasyncns.so.0 libasyncns-0.8_1
 libpulse.so.0 libpulseaudio-1.0_1
 libpulse-mainloop-glib.so.0 libpulseaudio-1.0_1
 libpulse-simple.so.0 libpulseaudio-1.0_1
-libpulsecommon-14.0.so libpulseaudio-14.0_1
-libpulsecore-14.0.so libpulseaudio-14.0_1
+libpulsecommon-14.2.so libpulseaudio-14.2_1
+libpulsecore-14.2.so libpulseaudio-14.2_1
 libprojectM.so.3 projectM-3.1.7_2
 liborc-0.4.so.0 orc-0.4.11_1
 liborc-test-0.4.so.0 orc-0.4.11_1
diff --git a/srcpkgs/pulseaudio/template b/srcpkgs/pulseaudio/template
index d54b9c5ba69..6819c2c1b70 100644
--- a/srcpkgs/pulseaudio/template
+++ b/srcpkgs/pulseaudio/template
@@ -1,8 +1,9 @@
 # Template file for 'pulseaudio'
 pkgname=pulseaudio
-version=14.0
-revision=3
+version=14.2
+revision=1
 build_style=meson
+# XXX: new version should be able to enable systemd functionality using elogind
 configure_args="-Djack=enabled -Dlirc=disabled -Dhal-compat=false -Dorc=enabled
  -Dgtk=disabled -Dsystemd=disabled -Dwebrtc-aec=enabled
  -Dbluez5=true -Dbluez5-ofono-headset=false -Dbluez5-native-headset=true
@@ -21,8 +22,11 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://www.freedesktop.org/wiki/Software/PulseAudio"
 distfiles="${FREEDESKTOP_SITE}/${pkgname}/releases/${pkgname}-${version}.tar.xz"
-checksum=a834775d9382b055504e5ee7625dc50768daac29329531deb6597bf05e06c261
+checksum=75d3f7742c1ae449049a4c88900e454b8b350ecaa8c544f3488a2562a9ff66f1
 python_version=3
+# FIXME: core-util-test fails
+make_check=yes
+
 system_groups="pulse-access"
 system_accounts="pulse"
 pulse_groups="audio"

From 37ac5824cbf5705e635af65fe8eb78a3067d23d9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 15 Feb 2021 01:47:15 -0300
Subject: [PATCH 2/2] pulseaudio-module-sndio: revbump for pulseaudio.

---
 srcpkgs/pulseaudio-module-sndio/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/pulseaudio-module-sndio/template b/srcpkgs/pulseaudio-module-sndio/template
index b43a0b40b4d..7b261e7ae06 100644
--- a/srcpkgs/pulseaudio-module-sndio/template
+++ b/srcpkgs/pulseaudio-module-sndio/template
@@ -1,7 +1,7 @@
 # Template file for 'pulseaudio-module-sndio'
 pkgname=pulseaudio-module-sndio
 version=13.0
-revision=2
+revision=3
 build_style=gnu-makefile
 make_use_env=yes
 hostmakedepends="pulseaudio pkg-config"

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Merged]: pulseaudio: remove rtkit dependency and update to 14.2
  2021-02-15  2:23 [PR PATCH] pulseaudio: remove rtkit dependency ericonr
                   ` (8 preceding siblings ...)
  2021-02-16 19:26 ` [PR PATCH] [Updated] " ericonr
@ 2021-02-16 19:28 ` ericonr
  2021-02-17  4:51 ` fosslinux
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-02-16 19:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

There's a merged pull request on the void-packages repository

pulseaudio: remove rtkit dependency and update to 14.2
https://github.com/void-linux/void-packages/pull/28771

Description:
PulseAudio doesn't need rtkit available to work for basic usage, so
it's better to only pull it in when a user wants realtime (the error
messages should also be clear enough).

Since rtkit now pulls in a complex dependency in polkit, we can avoid
pulseaudio also pulling the whole thing in.

I have yet to test this throroughly. Basic functionality is fine.

@q66

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: pulseaudio: remove rtkit dependency and update to 14.2
  2021-02-15  2:23 [PR PATCH] pulseaudio: remove rtkit dependency ericonr
                   ` (9 preceding siblings ...)
  2021-02-16 19:28 ` [PR PATCH] [Merged]: " ericonr
@ 2021-02-17  4:51 ` fosslinux
  10 siblings, 0 replies; 12+ messages in thread
From: fosslinux @ 2021-02-17  4:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/28771#issuecomment-780296827

Comment:
Oh, duh, silly me! Yeah, ofc it wont detect for runtime at buildtime lol

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-02-17  4:51 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15  2:23 [PR PATCH] pulseaudio: remove rtkit dependency ericonr
2021-02-15  4:46 ` [PR PATCH] [Updated] " ericonr
2021-02-15  4:48 ` [PR PATCH] [Updated] pulseaudio: remove rtkit dependency and update to 14.2 ericonr
2021-02-15  4:49 ` ericonr
2021-02-15  8:30 ` q66
2021-02-16  9:56 ` fosslinux
2021-02-16  9:58 ` fosslinux
2021-02-16 18:52 ` ericonr
2021-02-16 18:53 ` ericonr
2021-02-16 19:26 ` [PR PATCH] [Updated] " ericonr
2021-02-16 19:28 ` [PR PATCH] [Merged]: " ericonr
2021-02-17  4:51 ` fosslinux

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).